Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-23 Thread Neels Hofmeyr
On Sat, 2011-02-19 at 04:53 +0100, Stefan Sperling wrote: > On Fri, Feb 18, 2011 at 09:19:56PM -0500, Greg Stein wrote: > > Can somebody provide a pointer to some of the latest speed analysis? > > Neels is on vacation this week. When he returns, I'll prod him > about running his performance tests

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Stefan Sperling
On Fri, Feb 18, 2011 at 09:19:56PM -0500, Greg Stein wrote: > Can somebody provide a pointer to some of the latest speed analysis? Neels is on vacation this week. When he returns, I'll prod him about running his performance tests again and sharing the results.

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Greg Stein
On Fri, Feb 18, 2011 at 11:38, Julian Foad wrote: > On Fri, 2011-02-18 at 17:20 +0100, Branko Čibej wrote: >... >> If I read that patch correctly, you expect to use one sqlite transaction >> per pristine file? While this may not affect WC performance now, it'll >> surely show up once other queries

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Julian Foad
On Fri, 2011-02-18 at 17:20 +0100, Branko Čibej wrote: > On 18.02.2011 16:51, Julian Foad wrote: > > On Fri, 2011-02-18 at 16:01 +0100, Branko Čibej wrote: > >> On 18.02.2011 15:49, Julian Foad wrote: > >>> svn_error_t * > >>> +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db, > >>> + sv

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Branko Čibej
On 18.02.2011 16:51, Julian Foad wrote: > On Fri, 2011-02-18 at 16:01 +0100, Branko Čibej wrote: >> On 18.02.2011 15:49, Julian Foad wrote: >>> svn_error_t * >>> +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db, >>> + svn_sqlite__transaction_callback_t cb_func, >>> + void *cb_baton, >>>

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Julian Foad
On Fri, 2011-02-18 at 16:01 +0100, Branko Čibej wrote: > On 18.02.2011 15:49, Julian Foad wrote: > > svn_error_t * > > +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db, > > + svn_sqlite__transaction_callback_t cb_func, > > + void *cb_baton, > > + apr_pool_t *scratch_pool /* NULL allowed

Re: [PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Branko Čibej
On 18.02.2011 15:49, Julian Foad wrote: > svn_error_t * > +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db, > + svn_sqlite__transaction_callback_t cb_func, > + void *cb_baton, > + apr_pool_t *scratch_pool /* NULL allowed */) > +{ So you created a new (private) function that's a copy-pa

[PATCH in progress] Pristine text store - pristine_install

2011-02-18 Thread Julian Foad
I have started adjusting the pristine store access functions to implement the spec in 'notes/wc-ng/pristine-store'. The attached patch goes most of the way to sorting out the 'install' function, except that testing for whether it's already installed is still done by looking on disk for the file wh