On Fri, 2011-02-18 at 17:20 +0100, Branko Čibej wrote:
> On 18.02.2011 16:51, Julian Foad wrote:
> > On Fri, 2011-02-18 at 16:01 +0100, Branko Čibej wrote:
> >> On 18.02.2011 15:49, Julian Foad wrote:
> >>> svn_error_t *
> >>> +svn_sqlite__with_immediate_transaction(svn_sqlite__db_t *db,
> >>> + svn_sqlite__transaction_callback_t cb_func,
> >>> + void *cb_baton,
> >>> + apr_pool_t *scratch_pool /* NULL allowed */)
> >>> +{
> >> So you created a new (private) function that's a copy-paste of another
> >> (private) function, both of which are new on trunk, and the difference
> >> between them are in one line of the function body.
> >>
> >> What's wrong with that picture?
> > Ok OK! You caught me. Normally I consider myself the last person who
> > would duplicate code. I'll certainly un-duplicate before commit.
> >
> > Any comments on functionality?
>
> :)
>
> If I read that patch correctly, you expect to use one sqlite transaction
> per pristine file? While this may not affect WC performance now, it'll
> surely show up once other queries are optimized and transactions made a
> bit less granular.
Yup - I mentioned that earlier today in the other thread "Pristine store
- spec": I think I'll need to extend so that a buch of pristines can be
installed at once. Glad to find you're thinking the same. But I'll get
the concurrency guarantees sorted out before extending it.
- Julian
