Re: [PATCH] svnlook.py: Make it usable as a library

2013-11-14 Thread Julian Foad
anatoly techtonik wrote: >>  -__version__ = '2012.05.24' > > Because svnlook.py is used in hook scripts, it is usually copied > out of revision control. Version is useful to track new changes. That makes sense. I'm not sure what to put in the __version__ string, but the most common way to identi

Re: [PATCH] svnlook.py: Make it usable as a library

2013-11-13 Thread anatoly techtonik
Wow. Thanks for the review and committing the stuff so quick. About dates, I need to check if the behaviour changed for myself. Here is the diff commented - my original version first. > $ diff -bu3 svnlook.py svnlook.py\?revision\=1541558 -p ... > -__version__ = '2012.05.24' > - Because svnlook

Re: [PATCH] svnlook.py: Make it usable as a library

2013-11-13 Thread Julian Foad
(I sound so grumpy. Let me try again.) Thank you, Anatoly, for bothering to contribute your changes back to the community. Your main changes look good and well commented. I like them and I've committed them. It always makes it easier and thus more likely that someone will commit your patch if

Re: [PATCH] svnlook.py: Make it usable as a library

2013-11-13 Thread Julian Foad
Hi, anatoly. Your patch contains:   * make usable as a library by adding getter methods;   * when printing a date, use a different formatting;   * minor changes:     adding a source code version label;     setting self.rev to youngest rev even if a txn-id is provided;     s/youngest/latest/ in

Re: [PATCH] svnlook.py: Make it usable as a library

2013-11-10 Thread anatoly techtonik
On Sun, Nov 10, 2013 at 1:09 AM, Gabriela Gibson wrote: > On Sat, Nov 9, 2013 at 9:03 AM, anatoly techtonik wrote: > >> ping >> >> Please, CC. >> >> On Mon, May 28, 2012 at 7:26 PM, anatoly techtonik >> wrote: >> > [[[ >> > * tools/examples/svnlook.py: Make it usable as a library >> > ]]] >> > >>

Re: [PATCH] svnlook.py: Make it usable as a library

2013-11-09 Thread Gabriela Gibson
*sigh* googlemail ninja's me once again... On Sat, Nov 9, 2013 at 9:03 AM, anatoly techtonik wrote: > ping > > Please, CC. > > On Mon, May 28, 2012 at 7:26 PM, anatoly techtonik > wrote: > > [[[ > > * tools/examples/svnlook.py: Make it usable as a library > > ]]] > > > > Of course it would be be

Re: [PATCH] svnlook.py: Make it usable as a library

2013-11-09 Thread anatoly techtonik
ping Please, CC. On Mon, May 28, 2012 at 7:26 PM, anatoly techtonik wrote: > [[[ > * tools/examples/svnlook.py: Make it usable as a library > ]]] > > Of course it would be better to use iterator interface instead of > copying lists in memory, but I don't know if Subversion bindings have > one. N

[PATCH] svnlook.py: Make it usable as a library

2012-05-28 Thread anatoly techtonik
[[[ * tools/examples/svnlook.py: Make it usable as a library ]]] Of course it would be better to use iterator interface instead of copying lists in memory, but I don't know if Subversion bindings have one. Not all commands are implemented, as I don't have time to rewrite everything, but at least i