Hi, anatoly. Your patch contains:
* make usable as a library by adding getter methods; * when printing a date, use a different formatting; * minor changes: adding a source code version label; setting self.rev to youngest rev even if a txn-id is provided; s/youngest/latest/ in the help. * no log message. The main changes (adding getter methods) look good. I have tested the changes by hand, written a log message, and committed: <http://svn.apache.org/r1541558>. The change to the display of dates is a separate issue. I don't really care what format it displays, but this code has a problem: it now displays a date even when there is no "svn:date" property. Are any of the minor changes important or useful? Thanks. - Julian anatoly techtonik wrote on 2013-11-09: > ping > > Please, CC. > > On Mon, May 28, 2012 at 7:26 PM, anatoly techtonik <techto...@gmail.com> > wrote: >> [[[ >> * tools/examples/svnlook.py: Make it usable as a library >> ]]] >> >> Of course it would be better to use iterator interface instead of >> copying lists in memory, but I don't know if Subversion bindings have >> one. Not all commands are implemented, as I don't have time to >> rewrite everything, but at least it is clearly documented what is left, >> so it should easy do to if anyone will need it for their hook scripts. >> >> This is the same as: >> https://github.com/apache/subversion/pull/1/files >> >> Please, CC. >
