Re: [PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, Jul 01, 2013 at 15:40:18 +0200: > On Mon, Jul 01, 2013 at 04:05:54PM +0300, Daniel Shahaf wrote: > > Daniel Shahaf wrote on Mon, Jul 01, 2013 at 15:52:32 +0300: > > > No, we should extend the test to run 'svn ls' or 'svnadmin verify' to > > > ensure that creating the p

Re: [PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Stefan Sperling
On Mon, Jul 01, 2013 at 04:05:54PM +0300, Daniel Shahaf wrote: > Daniel Shahaf wrote on Mon, Jul 01, 2013 at 15:52:32 +0300: > > No, we should extend the test to run 'svn ls' or 'svnadmin verify' to > > ensure that creating the path with \n in it didn't break anything. Fair enough, that's good eno

Re: [PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Daniel Shahaf
Daniel Shahaf wrote on Mon, Jul 01, 2013 at 15:52:32 +0300: > Stefan Sperling wrote on Mon, Jul 01, 2013 at 14:45:42 +0200: > > On Mon, Jul 01, 2013 at 03:10:26PM +0300, Daniel Shahaf wrote: > > > Stefan Sperling wrote on Mon, Jul 01, 2013 at 13:52:08 +0200: > > > > On Mon, Jul 01, 2013 at 02:33:06

Re: [PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, Jul 01, 2013 at 14:45:42 +0200: > On Mon, Jul 01, 2013 at 03:10:26PM +0300, Daniel Shahaf wrote: > > Stefan Sperling wrote on Mon, Jul 01, 2013 at 13:52:08 +0200: > > > On Mon, Jul 01, 2013 at 02:33:06PM +0300, Daniel Shahaf wrote: > > > > I don't remember whether I po

Re: [PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Stefan Sperling
On Mon, Jul 01, 2013 at 03:10:26PM +0300, Daniel Shahaf wrote: > Stefan Sperling wrote on Mon, Jul 01, 2013 at 13:52:08 +0200: > > On Mon, Jul 01, 2013 at 02:33:06PM +0300, Daniel Shahaf wrote: > > > I don't remember whether I pointed this out when Stefan originally wrote > > > that code: > > > >

Re: [PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, Jul 01, 2013 at 13:52:08 +0200: > On Mon, Jul 01, 2013 at 02:33:06PM +0300, Daniel Shahaf wrote: > > I don't remember whether I pointed this out when Stefan originally wrote > > that code: > > > > [[[ > > * subversion/tests/libsvn_fs/fs-test.c > > (filename_trailing

Re: [PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Stefan Sperling
On Mon, Jul 01, 2013 at 02:33:06PM +0300, Daniel Shahaf wrote: > I don't remember whether I pointed this out when Stefan originally wrote > that code: > > [[[ > * subversion/tests/libsvn_fs/fs-test.c > (filename_trailing_newline): Switch from a blacklist approach to > to a whitelist approach

Re: [PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Stefan Fuhrmann
On Mon, Jul 1, 2013 at 1:33 PM, Daniel Shahaf wrote: > I don't remember whether I pointed this out when Stefan originally wrote > that code: > > [[[ > * subversion/tests/libsvn_fs/fs-test.c > (filename_trailing_newline): Switch from a blacklist approach to > to a whitelist approach, for def

[PATCH] default to expecting new FS backends to support \n in filenames

2013-07-01 Thread Daniel Shahaf
I don't remember whether I pointed this out when Stefan originally wrote that code: [[[ * subversion/tests/libsvn_fs/fs-test.c (filename_trailing_newline): Switch from a blacklist approach to to a whitelist approach, for defining backends that don't implement the API correctly. ]]] Ind