Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-12-17 Thread Julian Foad
Johan Corveleyn wrote on 2020-12-17: > I quickly wanted to point out that the backport-proposal of this > change to 1.14.x is missing one vote, and that your own vote isn't > "complete", because the proposal was later amended [...] Thank you for the heads-up, Johan. Reviewed and approved. -- - J

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-12-17 Thread Johan Corveleyn
On Wed, Sep 23, 2020 at 5:05 PM Julian Foad wrote: > > Committed in r1881958. > > BTW, how I tested this is by cleaning my build: > >(cd obj-dir && make local-clean) > > and then rebuilding, adding the following options to configure: > >--with-apr=$HOME/.local/apr-1.4.8 > --with-apr-util=$

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-09-24 Thread Daniel Shahaf
Julian Foad wrote on Wed, 23 Sep 2020 16:05 +0100: > Committed in r1881958. > > BTW, how I tested this is by cleaning my build: > >(cd obj-dir && make local-clean) > > and then rebuilding, adding the following options to configure: > >--with-apr=$HOME/.local/apr-1.4.8 > --with-apr-util

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-09-23 Thread Branko Čibej
On 23.09.2020 15:46, Julian Foad wrote: > Nathan Hartman wrote: >> Julian Foad wrote: >>> I have made a smaller version (attached), restoring support just >>> back to >>> APR 1.4 (not 1.3), putting all the apr_escape code in one file (128 >>> lines long), omitting EBCDIC support.  Does that feel be

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-09-23 Thread Julian Foad
Committed in r1881958. BTW, how I tested this is by cleaning my build: (cd obj-dir && make local-clean) and then rebuilding, adding the following options to configure: --with-apr=$HOME/.local/apr-1.4.8 --with-apr-util=$HOME/.local/apr-util-1.5.2 with local builds of apr and apr-util in

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-09-23 Thread Julian Foad
Nathan Hartman wrote: Julian Foad wrote: I have made a smaller version (attached), restoring support just back to APR 1.4 (not 1.3), putting all the apr_escape code in one file (128 lines long), omitting EBCDIC support.  Does that feel better? In principle I am okay with including a private im

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-09-17 Thread Nathan Hartman
On Thu, Sep 17, 2020 at 9:56 AM Julian Foad wrote: > > I have made a smaller version (attached), restoring support just back to > APR 1.4 (not 1.3), putting all the apr_escape code in one file (128 > lines long), omitting EBCDIC support. Does that feel better? In principle I am okay with inclu

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-09-17 Thread Julian Foad
Branko Čibej wrote: I'm not comfortable with copying whole swathes of APR into our code. I have made a smaller version (attached), restoring support just back to APR 1.4 (not 1.3), putting all the apr_escape code in one file (128 lines long), omitting EBCDIC support. Does that feel better?

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-09-17 Thread Andrew Marlow
sounds good to me. I've built recent versions of subversion on RHEL7 and it is a right pain in the neck, chasing those dependencies down to serf, especially since the last time I looked serf depended on python2 instead of python3. Your proposal gets my vote, FWIW. On Wed, 16 Sep 2020 at 22:14, Jul

Re: [PATCH] Support APR 1.4 for building on CentOS 7

2020-09-16 Thread Branko Čibej
On 16.09.2020 23:14, Julian Foad wrote: > Dear devs, > > I propose a patch restoring support for APR 1.4 so that svn 1.14 can > be built and packaged on CentOS 7. > > The WANdisco folks continue to package svn for a variety of target > systems.  Packaging for CentOS 7 which has APR 1.4.8, they ran

[PATCH] Support APR 1.4 for building on CentOS 7

2020-09-16 Thread Julian Foad
Dear devs, I propose a patch restoring support for APR 1.4 so that svn 1.14 can be built and packaged on CentOS 7. The WANdisco folks continue to package svn for a variety of target systems. Packaging for CentOS 7 which has APR 1.4.8, they ran into the problem that just before svn 1.14.0 we