On 23.09.2020 15:46, Julian Foad wrote: > Nathan Hartman wrote: >> Julian Foad wrote: >>> I have made a smaller version (attached), restoring support just >>> back to >>> APR 1.4 (not 1.3), putting all the apr_escape code in one file (128 >>> lines long), omitting EBCDIC support. Does that feel better? >> >> In principle I am okay with including a private implementation to >> give a better experience to our downstream users and packagers. >> >>> How's this version for everyone? >> >> The patch looks good to me. (I haven't applied or tested it yet but >> I'll do so if/when it's nominated for backport.) >> >> Of course, it will be very helpful to WanDisco if they could help us >> get a 1.14.1 out the door :-) > > I've had confirmation that this is sufficient to fix WANdisco's build > on CentOS 7. > > There seems to be some general consensus for this, so I'll commit it > and propose for backport, and we can take it to the review stage. > > Anyone else want to comment? Brane, you expressed concerns about the > earlier, bigger version of this. How does this version sit with you?
Looks good, thanks! -- Brane
