Re: [PATCH] Small fixes to the Perl bindings

2013-02-19 Thread Ben Reser
On Sun, Feb 17, 2013 at 2:53 PM, Roderich Schupp wrote: > I used swig 2.0.9, but the change happened from 2.0.4 to 2.0.5. > A quick "git bisect" puts the blame on > https://github.com/swig/swig/commit/30206f975c3c3fbd6e702499727375b4321b490e > "Fix constructors in named typedef class declarations"

Re: [PATCH] Small fixes to the Perl bindings

2013-02-17 Thread Roderich Schupp
On Fri, Feb 15, 2013 at 8:41 PM, Ben Reser wrote: > I flipped through the changelog for SWIG and I didn't see anything > that explains this difference in behavior. > I used swig 2.0.9, but the change happened from 2.0.4 to 2.0.5. A quick "git bisect" puts the blame on https://github.com/swig/sw

Re: [PATCH] Small fixes to the Perl bindings

2013-02-15 Thread Ben Reser
On Fri, Feb 15, 2013 at 11:41 AM, Ben Reser wrote: > I wouldn't bother to do the testing like this. You can create an > _p_svn_opt_revision_t without needing to get it from something like > svn_wc_parse_externals_description3(). e.g. > > my $rev = SVN::_Core::new_svn_opt_revision_t(); > $rev->ki

Re: [PATCH] Small fixes to the Perl bindings

2013-02-15 Thread Ben Reser
On Fri, Feb 15, 2013 at 12:58 AM, Roderich Schupp wrote: > Err, no. The accessor functions don't go through the typemap, only > the wrappers for "real" functions do that (add a printf() or warn() at the > start of svn_swig_pl_set_revision() to see when it's called). I guess this depends on the S

Re: [PATCH] Small fixes to the Perl bindings

2013-02-15 Thread Roderich Schupp
On Wed, Feb 13, 2013 at 5:28 PM, Ben Reser wrote: > ... Retrieving values out of a > svn_opt_revision_t object would have exercised the issue since you're > calling the generated accessor function > Err, no. The accessor functions don't go through the typemap, only the wrappers for "real" functi

Re: [PATCH] Small fixes to the Perl bindings

2013-02-13 Thread Ben Reser
On Wed, Feb 13, 2013 at 6:57 AM, Roderich Schupp wrote: > Ouch. Your diagnosis is correct, though I can't reproduce your symptoms :) > The previously failing tests in t/9wc.t do not cover the problematic > conversion. > For that, you would have to pass a Perl _svn_opt_opt_revision_t object > (e.g.

Re: [PATCH] Small fixes to the Perl bindings

2013-02-13 Thread Roderich Schupp
On Tue, Feb 12, 2013 at 6:06 PM, Ben Reser wrote: > FYI you may want to apply the changes in r1445267 to your local copy. > I found a bug in the conversion of the svn_opt_revision_t typemap to > use a function. > Ouch. Your diagnosis is correct, though I can't reproduce your symptoms :) The pre

Re: [PATCH] Small fixes to the Perl bindings

2013-02-12 Thread Ben Reser
On Fri, Feb 8, 2013 at 1:29 AM, roderich.sch...@gmail.com wrote: > On Friday, February 8, 2013 1:53:03 AM UTC+1, Ben Reser wrote: >> >> For future reference though if you're adding support for a function >> it'd be nice to add tests for it. > > > I'll keep that in mind. Thanks for applying, Ben.

Re: [PATCH] Small fixes to the Perl bindings

2013-02-08 Thread roderich.sch...@gmail.com
On Friday, February 8, 2013 1:53:03 AM UTC+1, Ben Reser wrote: > > For future reference though if you're adding support for a function > it'd be nice to add tests for it. > I'll keep that in mind. Thanks for applying, Ben. Cheers, Roderich

Re: [PATCH] Small fixes to the Perl bindings

2013-02-07 Thread Ben Reser
On Thu, Jan 31, 2013 at 4:43 AM, roderich.sch...@gmail.com wrote: > while trying to use svn_wc_parse_externals_description3 from Perl I > stumbled over a fex things. > Patches below are against trunk. First of all thanks for the patches. > perl-bindings-1.patch > > [[[ > Make svn_wc_parse_extern

[PATCH] Small fixes to the Perl bindings

2013-01-31 Thread roderich.sch...@gmail.com
Hi, while trying to use svn_wc_parse_externals_description3 from Perl I stumbled over a fex things. Patches below are against trunk. perl-bindings-1.patch [[[ Make svn_wc_parse_externals_description3 available from Perl bindings. * subversion/bindings/swig/include/svn_containers.swg: Add out