Re: [PATCH] Search for libtoolize, not libtool

2014-09-24 Thread Philip Martin
Julian Foad writes: > Hi Philip. Sounds good, but it would be good to add your reasoning > (above) into the log message and/or as comments in the code. Done in r1627325. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: [PATCH] Search for libtoolize, not libtool

2014-09-24 Thread Julian Foad
Philip Martin wrote: > James McCoy writes: >> -libtool=${LIBTOOL:-`./build/PrintPath glibtool libtool libtool15`} >> +libtoolize=${LIBTOOLIZE:-`./build/PrintPath glibtoolize libtoolize >> libtoolize15`} > > APR has similar code in buildconf but it uses the order: > > libtoolize=`build/PrintPath

Re: [PATCH] Search for libtoolize, not libtool

2014-09-24 Thread Philip Martin
James McCoy writes: > -libtool=${LIBTOOL:-`./build/PrintPath glibtool libtool libtool15`} > +libtoolize=${LIBTOOLIZE:-`./build/PrintPath glibtoolize libtoolize > libtoolize15`} APR has similar code in buildconf but it uses the order: libtoolize=`build/PrintPath glibtoolize1 glibtoolize libtool

Re: [PATCH] Search for libtoolize, not libtool

2014-09-24 Thread Stefan Sperling
On Wed, Sep 24, 2014 at 09:03:40AM +0200, Stefan Sperling wrote: > We don't require tarball users to run autogen.sh so there is no dependency > on libtoolize in the tarball build. With the proposed change we're going to > require users to have GNU libtool installed to build Subversion from tarballs

Re: [PATCH] Search for libtoolize, not libtool

2014-09-24 Thread Stefan Sperling
On Tue, Sep 23, 2014 at 10:45:19PM -0400, James McCoy wrote: > Hi, > > build/buildcheck.sh performs a search for a variant of libtool in order > to verify an acceptable version is available. However, the similar > code in autogen.sh looks for and uses a variant of libtoolize. > > Since libtooliz

[PATCH] Search for libtoolize, not libtool

2014-09-23 Thread James McCoy
Hi, build/buildcheck.sh performs a search for a variant of libtool in order to verify an acceptable version is available. However, the similar code in autogen.sh looks for and uses a variant of libtoolize. Since libtoolize is the tool actually performing useful work between the two, and buildche