Re: _("%s: %s\n") was: Re: [PATCH] Proper plural localisation of conflict summary

2013-04-17 Thread Mattias Engdegård
17 apr 2013 kl. 00.39 skrev Daniel Shahaf: Nice. I suppose that means we now have a bunch of places where _() should be added --- such as svn_cl__info_print_time(). I am not quite sure how to find all of them, other than by using a finished translation and then looking for English or mis-pu

_("%s: %s\n") was: Re: [PATCH] Proper plural localisation of conflict summary

2013-04-16 Thread Daniel Shahaf
Mattias Engdegård wrote on Tue, Apr 16, 2013 at 23:03:04 +0200: > 16 apr 2013 kl. 20.28 skrev C. Michael Pilato: > >>> So, what about applying, approving or rejecting the patch? >>> (The one of http://svn.haxx.se/dev/archive-2013-04/0339.shtml) >>> It's required for at least one translation and ver

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-16 Thread Mattias Engdegård
16 apr 2013 kl. 20.28 skrev C. Michael Pilato: So, what about applying, approving or rejecting the patch? (The one of http://svn.haxx.se/dev/archive-2013-04/0339.shtml) It's required for at least one translation and very likely for several more. It does not change the English output in any wa

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-16 Thread C. Michael Pilato
On 04/16/2013 01:59 PM, Mattias Engdegård wrote: > 14 apr 2013 kl. 19.35 skrev Ben Reser: > >> Agreed I really don't see any reason not to fix these. Yes we've been >> sloppy with these sorts of localization issues in the past, doesn't >> mean we should continue to do so. > > So, what about appl

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-16 Thread Mattias Engdegård
14 apr 2013 kl. 19.35 skrev Ben Reser: Agreed I really don't see any reason not to fix these. Yes we've been sloppy with these sorts of localization issues in the past, doesn't mean we should continue to do so. So, what about applying, approving or rejecting the patch? (The one of http://svn.

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-14 Thread Ben Reser
On Sun, Apr 14, 2013 at 10:22 AM, Branko Čibej wrote: > I would argue that we should listen to our translators in matters like > these. Agreed I really don't see any reason not to fix these. Yes we've been sloppy with these sorts of localization issues in the past, doesn't mean we should continu

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-14 Thread Branko Čibej
On 14.04.2013 12:43, Mattias Engdegård wrote: > 14 apr 2013 kl. 03.57 skrev Daniel Shahaf: > >> We don't usually translate strings that don't contain alphanumerics. If >> you want to translate those, no opinion here either way, but you'll >> probably find a fair number of strings around the codeba

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-14 Thread Mattias Engdegård
14 apr 2013 kl. 03.57 skrev Daniel Shahaf: We don't usually translate strings that don't contain alphanumerics. If you want to translate those, no opinion here either way, but you'll probably find a fair number of strings around the codebase to add _() around. As you wish. I just noted this

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-13 Thread Daniel Shahaf
Mattias Engdegård wrote on Sat, Apr 13, 2013 at 23:56:37 +0200: > 13 apr 2013 kl. 23.47 skrev Daniel Shahaf: > >> Mattias Engdegård wrote on Sat, Apr 13, 2013 at 23:27:41 +0200: >>> + SVN_ERR(svn_cmdline_printf(pool, _(" %s: %s (%s)\n"), >>> + prefix, remaining, resolv

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-13 Thread Mattias Engdegård
13 apr 2013 kl. 23.47 skrev Daniel Shahaf: Mattias Engdegård wrote on Sat, Apr 13, 2013 at 23:27:41 +0200: + SVN_ERR(svn_cmdline_printf(pool, _(" %s: %s (%s)\n"), + prefix, remaining, resolved)); Why is this marked for translation? To allow for variations in sp

Re: [PATCH] Proper plural localisation of conflict summary

2013-04-13 Thread Daniel Shahaf
Mattias Engdegård wrote on Sat, Apr 13, 2013 at 23:27:41 +0200: > + SVN_ERR(svn_cmdline_printf(pool, _(" %s: %s (%s)\n"), > + prefix, remaining, resolved)); Why is this marked for translation? Looks good otherwise (including the MIME-type - thanks!).

[PATCH] Proper plural localisation of conflict summary

2013-04-13 Thread Mattias Engdegård
This is a good example of how a string that does not distinguish between singular and plural in English still needs to be localised in a number-aware way: SVN_ERR(svn_cmdline_printf(scratch_pool, _(" Text conflicts: %d remaining (and %d already resolved) \n"), n_te