On 28 Jan 2021, Daniel Shahaf wrote:
You missed one nit: the word "indicates" is still indented just
as much as the parenthesis above it.
Fascinating -- that was deliberate, but as I look through the logs
(here and in other projects), I see that my indentation style has
changed over time too
Karl Fogel wrote on Wed, Jan 27, 2021 at 15:23:12 -0600:
> On 27 Jan 2021, Daniel Shahaf wrote:
> > You're welcome. I see only a few more nits; see below. (Some of them I
> > noticed in the first iteration too, but I didn't want to pick too many
> > nits then.) I'm happy that the patch is correc
On 27 Jan 2021, Daniel Shahaf wrote:
You're welcome. I see only a few more nits; see below. (Some of
them I noticed in the first iteration too, but I didn't want to
pick too many nits then.) I'm happy that the patch is correct
and committable, though it won't make the "Major features in this
Karl Fogel wrote on Tue, Jan 26, 2021 at 22:18:25 -0600:
> If it passes the test suite, and you don't see any obvious further to the
> patch, I'll commit. Thanks again for your help, Daniel!
You're welcome. I see only a few more nits; see below. (Some of them I
noticed in the first iteration to
>I'm running the tests right now. If it passes the test suite, and you
>don't see any obvious further to the patch, I'll commit. Thanks again
"obvious further improvements", I meant to say.
-K
Okay, revised patch for review.
I'm running the tests right now. If it passes the test suite, and you
don't see any obvious further to the patch, I'll commit. Thanks again
for your help, Daniel!
Best regards,
-Karl
[[[
Distinguish between regular properties and revprops in tmpfile name.
* sub
On 26 Jan 2021, Daniel Shahaf wrote:
>Karl Fogel wrote on Tue, Jan 26, 2021 at 16:11:31 -0600:
>> This change is useful because many editors display the file's basename during
>> editing (e.g., in a status line somewhere near the bottom of the screen). So
>> if you get interrupted while editing a
Karl Fogel wrote on Tue, Jan 26, 2021 at 16:11:31 -0600:
> This small patch makes it so that when you do 'svn propedit --revprop', the
> tmpfile's name is "svn-revprop-rN.tmp" (where N is the number of the revision
> whose revprop is being edited).
>
> For regular properties, nothing has changed:
This small patch makes it so that when you do 'svn propedit --revprop', the
tmpfile's name is "svn-revprop-rN.tmp" (where N is the number of the revision
whose revprop is being edited).
For regular properties, nothing has changed: the tmpfile name is still just
"svn-prop.tmp".
This change is u
9 matches
Mail list logo
