Karl Fogel wrote on Wed, Jan 27, 2021 at 15:23:12 -0600: > On 27 Jan 2021, Daniel Shahaf wrote: > > You're welcome. I see only a few more nits; see below. (Some of them I > > noticed in the first iteration too, but I didn't want to pick too many > > nits then.) I'm happy that the patch is correct and committable, though > > it won't make the "Major features in this minor release" shortlist at > > the top of CHANGES. > > Mmm, probably not, yeah :-). > > Okay, I've addressed all your points -- thanks for the second review! -- and > the revised version is attached. If you don't spot any more nits, I'll > commit. (But more nits are certainly welcome, of course.)
You missed one nit: the word "indicates" is still indented just as much as the parenthesis above it. Ship it ☺ > > The message I'm replying to and your message dated "Tue, 26 Jan 2021 > > 22:23:52 -0600" were threaded at the same level (sibling nodes in my > > MUA's tree display), even though the latter quoted the former. I > > haven't investigated. > > That's probably due to my having hit 'Reply' on one message and then > manually copying-and-pasting some quoted text from another message later in > the same thread. (Sometimes I do that when it's easier than re-starting my > reply.) Right, thanks. Cheers, Daniel
