On 07/18/2011 03:11 AM, noorul Islam. Kamal Malmiyoda wrote:
> Bert/Julian/Mike,
>
> Thank you for your review comments and suggestions.
>
> Please find attached the updated patch which contains the following
> modifications.
Patch committed in r1228253. Thanks, Noorul.
--
C. Michael Pilato
FTR I'll be happy to review this patch at some point for inclusion in
trunk. Not right now though.
Noorul Islam K M wrote on Mon, Jul 18, 2011 at 12:41:59 +0530:
> [[[
> Fix issue #3942. Add new sub command 'lock' for 'svnadmin'. The
> following syntax is implemented in this patch.
>
> svnadmin
"C. Michael Pilato" writes:
> On 07/15/2011 08:58 AM, Noorul Islam K M wrote:
>
>> As first step I implemented the following syntax.
>>
>> svnadmin lock REPOS PATH USERNAME COMMENT-FILE
>>
>> I will add the optional TOKEN argument later. I hope I am progressing in
>> the right direction.
>
> I'
C. Michael Pilato wrote on Fri, Jul 15, 2011 at 13:17:13 -0400:
> On 07/15/2011 12:16 PM, Daniel Shahaf wrote:
> > If svnsync presents the lock token that's present on the master, and
> > hopefully the slave checks locks against the master during commit, the
> > commit is going to work isn't it?
>
On Fri, Jul 15, 2011 at 1:17 PM, C. Michael Pilato wrote:
> On 07/15/2011 12:16 PM, Daniel Shahaf wrote:
>> If svnsync presents the lock token that's present on the master, and
>> hopefully the slave checks locks against the master during commit, the
>> commit is going to work isn't it?
>
> I cons
On 07/15/2011 12:16 PM, Daniel Shahaf wrote:
> If svnsync presents the lock token that's present on the master, and
> hopefully the slave checks locks against the master during commit, the
> commit is going to work isn't it?
I considered this, but the FS code checks not only the lock tokens, but a
> -Original Message-
> From: Mark Phippard [mailto:markp...@gmail.com]
> Sent: vrijdag 15 juli 2011 18:20
> To: Daniel Shahaf
> Cc: Bert Huijben; Noorul Islam K M; Subversion
> Subject: Re: [PATCH] Issue 3942 - Provide new subcommand on svnadmin to
> create a loc
> -Original Message-
> From: Daniel Shahaf [mailto:d...@daniel.shahaf.name]
> Sent: vrijdag 15 juli 2011 17:35
> To: Bert Huijben
> Cc: 'Noorul Islam K M'; 'Subversion'; jmountifi...@tigris.org
> Subject: Re: [PATCH] Issue 3942 - Provide new sub
On Fri, Jul 15, 2011 at 12:16 PM, Daniel Shahaf wrote:
> If svnsync presents the lock token that's present on the master, and
> hopefully the slave checks locks against the master during commit, the
> commit is going to work isn't it?
Apache proxies commits back to the master. When you are usin
Mark Phippard wrote on Fri, Jul 15, 2011 at 12:02:53 -0400:
> On Fri, Jul 15, 2011 at 11:59 AM, Daniel Shahaf
> wrote:
> > Mark Phippard wrote on Fri, Jul 15, 2011 at 11:55:07 -0400:
> >> > To keep the information on this thread I quote a bit of information that
> >> > was just added to this iss
On Fri, Jul 15, 2011 at 11:59 AM, Daniel Shahaf wrote:
> Mark Phippard wrote on Fri, Jul 15, 2011 at 11:55:07 -0400:
>> > To keep the information on this thread I quote a bit of information that
>> > was just added to this issue:
>> >
>> > --- Additional comments from jmountifi...@tigris.org
Mark Phippard wrote on Fri, Jul 15, 2011 at 11:55:07 -0400:
> > To keep the information on this thread I quote a bit of information that
> > was just added to this issue:
> >
> > --- Additional comments from jmountifi...@tigris.org Fri Jul 15
> > 07:01:25 -0700 2011 ---
> >
> > Replicatin
> To keep the information on this thread I quote a bit of information that was
> just added to this issue:
>
> --- Additional comments from jmountifi...@tigris.org Fri Jul 15 07:01:25
> -0700 2011 ---
>
> Replicating the locks to the slave server, even with the right lock token
> value,
Daniel Shahaf wrote on Fri, Jul 15, 2011 at 18:35:16 +0300:
> Where are you quoting that from? I don't see it on the issue.
>
> jmountifield: svnadmin is not a client; in 'load' it interacts directly
Never mind, I misread you, sorry.
On 15/07/11 16:35, Daniel Shahaf wrote:
Where are you quoting that from? I don't see it on the issue.
My comment was against issue 3457
(http://subversion.tigris.org/issues/show_bug.cgi?id=3457)
jmountifield: svnadmin is not a client; in 'load' it interacts directly
with the underlying
> From: C. Michael Pilato [mailto:cmpil...@collab.net]
> > Sent: vrijdag 15 juli 2011 17:04
> > To: Noorul Islam K M
> > Cc: Subversion
> > Subject: Re: [PATCH] Issue 3942 - Provide new subcommand on svnadmin to
> > create a lock
> >
> > On 07/15/2011 08:
> -Original Message-
> From: C. Michael Pilato [mailto:cmpil...@collab.net]
> Sent: vrijdag 15 juli 2011 17:04
> To: Noorul Islam K M
> Cc: Subversion
> Subject: Re: [PATCH] Issue 3942 - Provide new subcommand on svnadmin to
> create a lock
>
> On 07/15/2011
On 07/15/2011 08:58 AM, Noorul Islam K M wrote:
> As first step I implemented the following syntax.
>
> svnadmin lock REPOS PATH USERNAME COMMENT-FILE
>
> I will add the optional TOKEN argument later. I hope I am progressing in
> the right direction.
I've not reviewed this work, but you might al
Noorul Islam K M wrote:
> + SVN_ERR(svn_stringbuf_from_file2(&file_contents, comment_file_name, pool));
> + comment = file_contents->data;
> +
> + /* Enforce that the comment be xml-escapable. */
> + if (comment)
There doesn't seem to be any way that 'comment' could be null in your
current pat
> -Original Message-
> From: Noorul Islam K M [mailto:noo...@collab.net]
> Sent: vrijdag 15 juli 2011 14:58
> To: Subversion
> Subject: [PATCH] Issue 3942 - Provide new subcommand on svnadmin to
> create a lock
>
> Noorul Islam K M writes:
>
> > F
Noorul Islam K M writes:
> From: http://subversion.tigris.org/issues/show_bug.cgi?id=3942
> ===
> The svnadmin command currently allows you to list and remove locks. It
> would be useful if you could also create locks. Suggeste
21 matches
Mail list logo
