Julian Foad wrote:
> Branko Čibej wrote:
>
>>> Incorporated the above suggestion and committed in r887178.
>>>
>> Wait, you committed a script that does URL quoting on XML contents? Did
>> you look at the output?
>>
>
> I didn't look at any real output, only a hand-crafted test strin
On Fri, 2009-12-04 at 14:44 +, Julian Foad wrote:
> Sure. The idea is to make the occasional unexpected control character
> appear as something that is valid in an XML CDATA section and is
> human-readable. URL escaping rules seemed a fine choice. Have I missed
> something?
>
> > > Incorporate
On Fri, 2009-12-04 at 15:29 +0100, Branko Čibej wrote:
> Bhuvaneswaran A wrote:
> > On Fri, 2009-12-04 at 12:36 +, Julian Foad wrote:
> >
> >> Bhuvaneswaran A wrote:
> >>
> >>> Please find attached the revised patch. I incorporated following
> >>> feedback:
> >>> a) Fix the array slic
Branko Čibej wrote:
> Bhuvaneswaran A wrote:
> > On Fri, 2009-12-04 at 12:36 +, Julian Foad wrote:
> >
> >> Bhuvaneswaran A wrote:
> >>
> >>> Please find attached the revised patch. I incorporated following
> >>> feedback:
> >>> a) Fix the array slicing part
> >>> b) Escape using or
Bhuvaneswaran A wrote:
> On Fri, 2009-12-04 at 12:36 +, Julian Foad wrote:
>
>> Bhuvaneswaran A wrote:
>>
>>> Please find attached the revised patch. I incorporated following
>>> feedback:
>>> a) Fix the array slicing part
>>> b) Escape using ord() instead of removing those characte
Julian Foad wrote:
> I searched on the web and didn't find a really really simple way to
> escape a set of characters. I think something like
>
> for c in chars_to_remove:
> data = data.replace(c, '%%%0x' % ord(c))
>
> would do it.
>
Please read what I wrote earlier. Second, this is URL e
On Fri, 2009-12-04 at 13:41 +, Julian Foad wrote:
> Bhuvaneswaran A wrote:
> > Branko, Julian: Thank you for the review comments.
> >
> > Incorporated the above suggestion and committed in r887178. Now that the
> > script is stable, as discussed in this thread [1], shall I nominate this
> > sc
Bhuvaneswaran A wrote:
> Branko, Julian: Thank you for the review comments.
>
> Incorporated the above suggestion and committed in r887178. Now that the
> script is stable, as discussed in this thread [1], shall I nominate this
> script to 1.6.x branch?
> [1]
> http://subversion.tigris.org/ds/view
On Fri, 2009-12-04 at 12:36 +, Julian Foad wrote:
> Bhuvaneswaran A wrote:
> > Please find attached the revised patch. I incorporated following
> > feedback:
> > a) Fix the array slicing part
> > b) Escape using ord() instead of removing those characters
> > c) Handle "]]>" in CDATA secti
Bhuvaneswaran A wrote:
> Please find attached the revised patch. I incorporated following
> feedback:
> a) Fix the array slicing part
> b) Escape using ord() instead of removing those characters
> c) Handle "]]>" in CDATA section
> d) Define the ascii table globally (once) and re-use
>
> I
Please find attached the revised patch. I incorporated following
feedback:
a) Fix the array slicing part
b) Escape using ord() instead of removing those characters
c) Handle "]]>" in CDATA section
d) Define the ascii table globally (once) and re-use
I also verified this fix by generating t
Bhuvaneswaran A wrote:
> On Fri, 2009-12-04 at 10:22 +, Julian Foad wrote:
> > Branko Čibej wrote:
> > > Bhuvaneswaran A wrote:
> > > > The failure message for few tests contain special characters, ex:
> >
> > What do you mean by "special" characters? Unprintable characters?
> > Non-UTF8 chara
Bhuvaneswaran A wrote:
> On Fri, 2009-12-04 at 10:22 +, Julian Foad wrote:
>
>> Branko Čibej wrote:
>>
>> Or just escape the "special" characters.
>>
>
> Good point. I used to encode using utf-8, but it doesn't seem to
> detect/encode these characters, resulting in unchanged behavi
Julian Foad wrote:
> Branko Čibej wrote:
>
>> Bhuvaneswaran A wrote:
>>
>>> The failure message for few tests contain special characters, ex:
>>>
>
> What do you mean by "special" characters? Unprintable characters?
> Non-UTF8 characters? Invalid XML characters? Characters that are X
On Fri, 2009-12-04 at 10:22 +, Julian Foad wrote:
> Branko Čibej wrote:
> > Bhuvaneswaran A wrote:
> > > The failure message for few tests contain special characters, ex:
>
> What do you mean by "special" characters? Unprintable characters?
> Non-UTF8 characters? Invalid XML characters? Charac
On Fri, 2009-12-04 at 10:37 +0100, Branko Čibej wrote:
> Bhuvaneswaran A wrote:
> > The failure message for few tests contain special characters, ex:
> > prop_tests.py. As a result, it creates an invalid xml file and not being
> > displayed in Hudson.
> >
> > This commit fixes this issue, also trac
I (Julian Foad) wrote:
[...]
> But... this is only a test result logging application. If it works with
> what the Subversion test suite produces, then it works.
I mean: so if it works, go ahead and commit it - it doesn't need to be
"perfect".
- Julian
Branko Čibej wrote:
> Bhuvaneswaran A wrote:
> > The failure message for few tests contain special characters, ex:
What do you mean by "special" characters? Unprintable characters?
Non-UTF8 characters? Invalid XML characters? Characters that are XML
syntax characters such as "<"?
> > prop_tests.p
Bhuvaneswaran A wrote:
> The failure message for few tests contain special characters, ex:
> prop_tests.py. As a result, it creates an invalid xml file and not being
> displayed in Hudson.
>
> This commit fixes this issue, also tracked in issue 3541. With this fix,
> the test results are displayed
The failure message for few tests contain special characters, ex:
prop_tests.py. As a result, it creates an invalid xml file and not being
displayed in Hudson.
This commit fixes this issue, also tracked in issue 3541. With this fix,
the test results are displayed in Hudson, especially the results
20 matches
Mail list logo
