Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-09 Thread Daniel Näslund
On Wed, Nov 9, 2011 at 12:41 PM, Daniel Näslund wrote: > On Wed, Nov 9, 2011 at 10:46 AM, Philip Martin > wrote: >> Daniel Näslund writes: >> What is not clear to me is why skipped targets get added to targets_info >> in the first place.  How about moving the APR_ARRAY_PUSH inside the >> !target

Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-09 Thread Philip Martin
Stefan Sperling writes: > On Wed, Nov 09, 2011 at 12:18:20PM +, Philip Martin wrote: >> Daniel Näslund writes: >> >> > A side note; when I tested the patch I needed to use abspath's in the >> > patch file or else the target wouldn't get skipped. >> >> When raising the issue I had difficult

Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-09 Thread Stefan Sperling
On Wed, Nov 09, 2011 at 07:54:32PM +0200, Daniel Shahaf wrote: > Stefan Sperling wrote on Wed, Nov 09, 2011 at 18:41:34 +0100: > > Patch targets get skipped in any of these circumstances: > > > > - the target is the working copy root > > Can a patch represent a propchange on the wc root? Yes, t

Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-09 Thread Daniel Shahaf
Stefan Sperling wrote on Wed, Nov 09, 2011 at 18:41:34 +0100: > On Wed, Nov 09, 2011 at 12:18:20PM +, Philip Martin wrote: > > Daniel Näslund writes: > > > > > A side note; when I tested the patch I needed to use abspath's in the > > > patch file or else the target wouldn't get skipped. > >

Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-09 Thread Stefan Sperling
On Wed, Nov 09, 2011 at 12:18:20PM +, Philip Martin wrote: > Daniel Näslund writes: > > > A side note; when I tested the patch I needed to use abspath's in the > > patch file or else the target wouldn't get skipped. > > When raising the issue I had difficulty producing the test case because

Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-09 Thread Philip Martin
Daniel Näslund writes: > A side note; when I tested the patch I needed to use abspath's in the > patch file or else the target wouldn't get skipped. When raising the issue I had difficulty producing the test case because I couldn't work out quite what caused a path to get skipped. I guess Windo

Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-09 Thread Daniel Näslund
On Wed, Nov 9, 2011 at 10:46 AM, Philip Martin wrote: > Daniel Näslund writes: > >> Index: subversion/libsvn_client/patch.c >> === >> --- subversion/libsvn_client/patch.c  (revision 1199347) >> +++ subversion/libsvn_client/patch.c  (

Re: [PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-09 Thread Philip Martin
Daniel Näslund writes: > Index: subversion/libsvn_client/patch.c > === > --- subversion/libsvn_client/patch.c (revision 1199347) > +++ subversion/libsvn_client/patch.c (arbetskopia) > @@ -255,6 +255,7 @@ typedef struct patch_target

[PATCH] Fix issue #4049 - SEGV on patch that deletes and skips

2011-11-08 Thread Daniel Näslund
Hi, It's been a year since my last commit and I've forgotten about the internals of the patch code. Sending this patch for review so that I don't mess something up. [[[ Fix issue #4049 - SEGV on patch that deletes and skips. When we do the sanity check of the supplied patch file we set skipped=T