Stefan Sperling <s...@elego.de> writes: > On Wed, Nov 09, 2011 at 12:18:20PM +0000, Philip Martin wrote: >> Daniel Näslund <dan...@dannas.name> writes: >> >> > A side note; when I tested the patch I needed to use abspath's in the >> > patch file or else the target wouldn't get skipped. >> >> When raising the issue I had difficulty producing the test case because >> I couldn't work out quite what caused a path to get skipped. I guess >> Windows users might be generating patches with abspaths more than Unix >> users. > > Patch targets get skipped in any of these circumstances: > > - the target filename is the empty string (this is just a sanity check) > - the target is outside of the working copy being patched > - the target is the working copy root > - the target is unversioned, missing, ignored, or obstructed > - the target is a locally deleted directory (this should be revisited > now that wc-ng has been released)
I didn't really express myself clearly. Most of those don't set target->skipped in init_patch_target as called by apply_one_patch and so don't trigger the SEGV, they generally set target->skipped later in apply_one_patch. -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com
