Re: [PATCH] Fix failing ci caused in r40202-upgrade to new func

On Fri, 2009-12-18, Kannan wrote: > This patch upgrades ..add_component() to ..add_component2() which > depends on the previous uncommitted patch [1] to canonicalize the URLs. > > [[[ > Log: > Resolve some deprecation warnings. > > * subversion/libsvn_ra_neon/commit.c > (get_version_url, create

Re: [PATCH] Fix failing ci caused in r40202

On Fri, 2010-02-05, Kannan wrote: > Follow-up r901797. Canonicalization of BASE URL doesn't reflect for > elements having parent info, till now. > > * subversion/libsvn_ra_neon/props.c > (end_element): Canonicalize the BASE URL for elements having parent >info. > > Patch by: Kannan R > Sug

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > Yes. > > Thanks. > Attaching the updated patch herewith. Thank you for the comments, Julian. [[[ Log: Follow-up r901797. Canonicalization of BASE URL doesn't reflect for elements having parent info, till now. * subversion

Re: [PATCH] Fix failing ci caused in r40202

Kannan wrote: > Julian Foad wrote: > > But that's not right. Like I said before, the variable holds different > > kinds of data at different times. (If we this variable was intended to > > always hold a URL, we would want the variable's name to indicate so.) > > > > It is wrong to call svn_uri_can

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: > But that's not right. Like I said before, the variable holds different > kinds of data at different times. (If we this variable was intended to > always hold a URL, we would want the variable's name to indicate so.) > > It is wron

Re: [PATCH] Fix failing ci caused in r40202

Kannan wrote: > Assertion failure occurred due to a non-canonical base URL passed to > `svn_path_url_add_component2()'. Despite having canonicalized them > wherever they are generated, the reason for this was that in > `end_element()' of props.c, canonicalization was done where the url was > assign

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > I committed the patch (with that fix) in 901797. > > Thanks for the patch. > > Now I am running the test suite on your patch to use > svn_path_url_add_component2(), >

Re: [PATCH] Fix failing ci caused in r40202

Kannan wrote: > [[[ > Log: > Ensure the URLs in libsvn_ra_neon are always canonical. [...] > ]]] Thanks. I found one more problem when I tried to compile it: subversion/libsvn_ra_neon/options.c:110: error: implicit declaration of function ‘svn_uri_canonicalize’ I fixed this, by #including "svn_d

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > In the second place it is used, we know it holds a URL: > >> case ELEM_href: >> /* Special handling for that belongs to the tag. */ >> if (rsrc->href_parent == ELEM_response) >> return assign_rsrc_url(pc

Re: [PATCH] Fix failing ci caused in r40202

On Thu, 2010-01-07, Kannan wrote: > Tracing these back further, the value gets set in `end_element()'. This > fixes one more instance of non-canonical URL in `get_version_url()', > thus fixing all instances of non-canonical URLs AFAICS. Thank you for > the feedback, Julian. Attaching the updated pa

Re: [PATCH] Fix failing ci caused in r40202

Apart from Kannan pinging his own update; This submission update has received no new comments. Gavin "Beau" Baumanis On 07/01/2010, at 11:40 PM, Kannan wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Julian Foad wrote: > [..] >> I looked for assignments to the "activity_coll" fie

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kannan wrote: [..] > [[[ > Log: > Ensure the URLs are always canonical. > > [ in subversion/libsvn_ra_neon ] > > * util.c > (svn_ra_neon__request_get_location): Canonicalize the 'BASE URL' as >per the rule. > > * props.c > (end_element): Sam

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > I looked for assignments to the "activity_coll" field, and found it in > the function end_element(), where it copies it from the "cdata" field. I > think that is where the canonicalization should be done. My bad, misinterpret

Re: [PATCH] Fix failing ci caused in r40202

On Tue, 2009-12-22, Kannan wrote: > I (Kannan) wrote: > [..] > >>> (svn_ra_neon__exchange_capabilities): Same. > >> And this? > > > Trying to find them out. > > With regard to this change, AFAICS the `activity_collection' value is > set in `svn_ra_neon__request_dispatch' where its obtained in t

Re: [PATCH] Fix failing ci caused in r40202

Ping. This thread has received no new comments. Gavin. On 23/12/2009, at 01:59 , Kannan wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > I (Kannan) wrote: > [..] (svn_ra_neon__exchange_capabilities): Same. >>> And this? > >> Trying to find them out. > > With regard to this

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I (Kannan) wrote: [..] >>> (svn_ra_neon__exchange_capabilities): Same. >> And this? > Trying to find them out. With regard to this change, AFAICS the `activity_collection' value is set in `svn_ra_neon__request_dispatch' where its obtained in the bo

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > Great. > > Did you look to see if there are any other similar calls in Subversion > where we make the same mistake? Couldn't find any, as of now. [..] >> * props.c >> (svn_ra_neon__get_baseline_info, svn_ra_neon__get_one_p

Re: [PATCH] Fix failing ci caused in r40202

On Tue, 2009-12-22, Kannan wrote: > Julian Foad wrote: > [..] > >> No, it should create a canonical URL. The fix we need is inside > >> svn_ra_neon__request_get_location(), or at least we need to look inside > >> that function to see where the non-canonical URL is coming from, and > >> maybe trace

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] >> No, it should create a canonical URL. The fix we need is inside >> svn_ra_neon__request_get_location(), or at least we need to look inside >> that function to see where the non-canonical URL is coming from, and >> maybe trace

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > OK. The policy in Subversion is that the paths and URLs passed in and > out of all APIs are canonical unless otherwise stated. Therefore we > should make do_checkout() set its "locn" output parameter to a canonical > URL. > >

Re: [PATCH] Fix failing ci caused in r40202

Kannan wrote: > Julian Foad wrote: > > do_checkout(): > > ... > > *locn = svn_ra_neon__request_get_location(request, pool); > > > > checkout_resource(): > > do_checkout(cc, rsrc->vsn_url, allow_404, token, &code, &locn, pool); > > ne_uri_parse(locn, &parse); > > rsrc->wr_url = svn_uri_ca

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > Hi Kannan. > > With your patch, the code in "commit.c" now looks like this (ignoring > all the error handling): > > do_checkout(): > ... > *locn = svn_ra_neon__request_get_location(request, pool); > > checkout_resource(

Re: [PATCH] Fix failing ci caused in r40202

On Thu, 2009-12-17, Kannan wrote: > Julian Foad wrote: > [..] > > It would be great if you could trace the calls back to wherever the > > non-canonical paths are generated, and fix them at that point. > > Thank you Julian, for the comments. Attached herewith is the patch to > canonicalize the URLs

Re: [PATCH] Fix failing ci caused in r40202-upgrade to new func

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: > I (Julian Foad) wrote: >> Hi Kannan. >> >> I cannot process these patches at the moment, sorry. I hope somebody >> else can. > > ... but I did have a quick scan through and they look right. > > I should be able to commit these to

Re: [PATCH] Fix failing ci caused in r40202-upgrade to new func

I (Julian Foad) wrote: > Hi Kannan. > > I cannot process these patches at the moment, sorry. I hope somebody > else can. ... but I did have a quick scan through and they look right. I should be able to commit these tomorrow. Thanks for your patience. - Julian > On Fri, 2009-12-18, Kannan wro

Re: [PATCH] Fix failing ci caused in r40202-upgrade to new func

Hi Kannan. I cannot process these patches at the moment, sorry. I hope somebody else can. - Julian On Fri, 2009-12-18, Kannan wrote: > This patch upgrades ..add_component() to ..add_component2() which > depends on the previous uncommitted patch [1] to canonicalize the URLs. > > [[[ > Log: > Re

Re: [PATCH] Fix failing ci caused in r40202-upgrade to new func

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kannan wrote: [..] This patch upgrades ..add_component() to ..add_component2() which depends on the previous uncommitted patch [1] to canonicalize the URLs. [[[ Log: Resolve some deprecation warnings. * subversion/libsvn_ra_neon/commit.c (get_vers

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Julian Foad wrote: [..] > It would be great if you could trace the calls back to wherever the > non-canonical paths are generated, and fix them at that point. Thank you Julian, for the comments. Attached herewith is the patch to canonicalize the URLs.

Re: [PATCH] Fix failing ci caused in r40202

On Tue, 2009-12-08, Kannan wrote: > Make a proper fix to resolve some deprecation warnings using > `svn_path_url_add_component2()' by canonicalizing the base before > passing to the above method. Please split this patch into its two logical changes: 1. Ensure paths are canonical. 2. Upgrade

Re: [PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Kannan wrote: > > As per discussion in the thread [1], attaching the patch herewith. > > Log: > Make a proper fix to resolve some deprecation warnings using > `svn_path_url_add_component2()' by canonicalizing the base before > passing to the above me

[PATCH] Fix failing ci caused in r40202

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 As per discussion in the thread [1], attaching the patch herewith. Log: Make a proper fix to resolve some deprecation warnings using `svn_path_url_add_component2()' by canonicalizing the base before passing to the above method. [in subversion/libsvn