Re: [PATCH] BDB schema doc updates - libsvn_fs_base/notes/structure

C. Michael Pilato wrote: > Patch looks good. +1 to commit. Committed revision 881710. Thanks. - Julian > Julian Foad wrote: > > C. Michael Pilato wrote: > >> I think there might be some parts that are incorrect. For example: > >> > >> -(HEADER PROP-KEY DATA-KEY [EDIT-DATA-KEY]) > >> +

Re: [PATCH] BDB schema doc updates - libsvn_fs_base/notes/structure

Patch looks good. +1 to commit. Julian Foad wrote: > C. Michael Pilato wrote: >> Julian Foad wrote: >>> Update to attached - any review >>> comments before I commit? >> Gah. Attachment approach makes this hard to review... > > Oh, sorry, I thought everyone was OK with 'text/x-patch' attachmen

Re: [PATCH] BDB schema doc updates - libsvn_fs_base/notes/structure

C. Michael Pilato wrote: > Julian Foad wrote: > > Update to attached - any review > > comments before I commit? > > Gah. Attachment approach makes this hard to review... Oh, sorry, I thought everyone was OK with 'text/x-patch' attachments. Thanks for having a look despite that. Pasting in-line

Re: [PATCH] BDB schema doc updates - libsvn_fs_base/notes/structure

Julian Foad wrote: > Update to attached - any review > comments before I commit? Gah. Attachment approach makes this hard to review... I think there might be some parts that are incorrect. For example: -(HEADER PROP-KEY DATA-KEY [EDIT-DATA-KEY]) +(HEADER PROP-KEY DATA-KEY [DATA-KEY-UN

[PATCH] BDB schema doc updates - libsvn_fs_base/notes/structure

Update to attached - any review comments before I commit? I'm attempting to update the documentation of the BDB schema (as in v1.6, to begin with), and to draw it in a diagram. Current attempt at . I got the idea and style from