Julian Foad wrote: > Update to <libsvn_fs_base/notes/structure> attached - any review > comments before I commit?
Gah. Attachment approach makes this hard to review... I think there might be some parts that are incorrect. For example: - (HEADER PROP-KEY DATA-KEY [EDIT-DATA-KEY]) + (HEADER PROP-KEY DATA-KEY [DATA-KEY-UNIQID] [EDIT-DATA-KEY]) If you look at the faux BNF stuff at the end, I think you'll find that we didn't squeeze a new atom DATA-KEY-UNIQID into the skel -- we made DATA-KEY be either an atom (for compat with old repositories) or a 2-tuple `(DATA-KEY DATA-KEY-UNIQID)'. So, before committing, you should double-check all your changes against that BNF stuff. If there's any part of the structure document that is likely to be up-to-date, it's that part. -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
