Hi,
This patch updates the CHANGES file to have a note about the new option
'--include-externals' added to 'svn list'.
Attached the patch and log message.
Thanks & Regards,
Vijayaguru
* CHANGES: List the new '--include-externals' option for
'svn list' (issue #4225).
Patch by: Vijayaguru
Hi,
This patch updates the CHANGES file to have a note about the new option
'--drop-all-empty-revs' added to 'svndumpfilter include/exclude'.
Attached the patch and log message.
Thanks & Regards,
Vijayaguru
* CHANGES: List the new '--drop-all-empty-revs' option to
'svndumpfilter include/ex
On Wednesday 27 February 2013 10:44 PM, Julian Foad wrote:
+write_out_rev = (! rb->had_dropped_nodes) ? TRUE : FALSE;
No, I don't mean that. "? TRUE : FALSE" is completely redundant, and I want us
to avoid that sort of redundancy.
"had_nodes_dropped" is a boolean value -- that is, a ye
On Wednesday 27 February 2013 11:10 AM, Julian Foad wrote:
@@ -439,14 +442,23 @@
/* write out the revision */
/* Revision is written out in the following cases:
- 1. No --drop-empty-revs has been supplied.
- 2. --drop-empty-revs has been supplied,
- but revision has not all
On Tuesday 26 February 2013 07:47 PM, Philip Martin wrote:
vijay writes:
/* write out the revision */
/* Revision is written out in the following cases:
- 1. No --drop-empty-revs has been supplied.
- 2. --drop-empty-revs has been supplied,
- but revision has not all nodes
Hi,
Recently, I had a chance to look at a dump file with lot of empty
revisions. The dump file was taken by syncing a sub-directory of a
remote repository using svnsync. I decided to remove all the empty
revisions from the dump file. But 'svndumpfilter include/exclude
--drop-empty-revs' was o
On Thursday 20 December 2012 07:52 PM, vijay wrote:
I note that 'svnadmin create r; svnrdump dump file://$PWD/r/foo' does
not error --- maybe your patch fixes that too?
The attached patch fixes this issue. This patch is different from the
previous versions.
We have to error out i
On Wednesday 19 December 2012 07:27 PM, Daniel Shahaf wrote:
+@SkipUnless(svntest.main.is_ra_type_dav)
+def dump_url_not_in_head(sbox) :
Spurious whitespace.
+ "dump: URL deleted in HEAD should return error"
+ sbox.build(create_wc = False)
+
+ E_url = sbox.repo_url + '/A/B/E'
+ # Delete
On Monday 17 December 2012 09:34 PM, Philip Martin wrote:
vijay writes:
The function svn_ra_serf__replay_range() doesn't return any error
while running 'svnrdump dump -rN:M '[Issue #4100].
It behaves as if the dump completed successfully.
* subversion/libsvn_r
Hi,
I was looking at the issue #4100: "svnrdump dump -rN:M
' fails" [1].
[[[
$
URL=http://svn.apache.org/repos/asf/subversion/trunk/contrib/server-side/mod_setlocale
$ svnrdump dump $URL -r1232154 > /dev/null
* Dumped revision 1232154.
$ svnrdump dump $URL -r1232155 > /dev/null
* Dumped rev
On Saturday 15 December 2012 02:33 PM, cmpil...@apache.org wrote:
Author: cmpilato
Date: Sat Dec 15 09:03:23 2012
New Revision: 1422206
URL: http://svn.apache.org/viewvc?rev=1422206&view=rev
Log:
Fix issue #4104 ("'svnrdump dump -rN:M /subpath' strips subpath
in first rev only")
Issue #4101, r
Hi,
This patch uses an existing function(svn_ra_serf__context_run_wait)
instead of in-line code for processing the connections defined by the
serf context.
Attached the patch and log message.
Thanks & Regards,
Vijayaguru
Index: subversion/libsvn_ra_serf/replay.c
=
Thanks, Philip and Julian.
I will explain things clearly in future patches.
Thanks & Regards,
Vijayaguru
On Friday 07 December 2012 10:02 PM, Julian Foad wrote:
Philip Martin wrote:
Philip Martin writes:
The logging is really just a side-effect. We setup this structure in
several pla
Hi,
The REPORT request during replay is being logged in httpd access log
with the entire session url instead of the request path portion of the url.
E.g,
Now the REPORT request during 'svnsync sync' or 'svnrdump dump' is
logged in httpd access log as follows.
127.0.0.1 - jrandom [07/Dec/2
Hi,
This patch is a follow up to r1414304 (corresponding mail thread [1]).
It renames 'pool' to 'scratch_pool' in list callback functions in
svn/list-cmd.c.
[1] http://svn.haxx.se/dev/archive-2012-11/0352.shtml
Thanks & Regards,
Vijayaguru
Index: subversion/include/svn_client.h
On Tuesday 27 November 2012 11:52 PM, Julian Foad wrote:
vijay wrote:
This updated patch has all the changes.
I have removed some redundant portion of code in print_dirent() and
print_dirent_xml() in svn/list-cmd.c.
Thanks Vijay. That looks great. I've committed it in r1414304. Nic
Thanks Julian.
This updated patch has all the changes.
I have removed some redundant portion of code in print_dirent() and
print_dirent_xml() in svn/list-cmd.c.
Thanks & Regards,
Vijayaguru
On Tuesday 27 November 2012 03:19 AM, Julian Foad wrote:
vijay wrote:
On Tuesday 13 Nove
Hi,
This patch removes the dead code in subversion/svn/list-cmd.c.
'--verbose' option is not valid in XML listing mode. The code will error
out in svn_cl__list() itself when '--verbose' is combined with '--xml'.
Attached the patch and log message.
Thanks & Regards,
Vijayaguru
Index: subversi
On Tuesday 13 November 2012 03:02 AM, Stefan Sperling wrote:
Attached the updated patch and log message.
+ /* Notify that we're about to handle an external. */
+ SVN_ERR(list_func(baton, NULL, NULL, NULL, NULL,
+externals_parent_url,
+i
On Friday 16 November 2012 04:41 PM, Neels J Hofmeyr wrote:
Hi Vijay,
I gave that patch a spin (after all I was the one who brought
--include-externals upon us), and found stuff. Using current trunk + your
patch v3.
I was looking at your code 'commit --include-externals' before w
On Thursday 15 November 2012 08:10 PM, C. Michael Pilato wrote:
On 11/15/2012 03:47 AM, Bert Huijben wrote:
Can't you just add the new argument to every call to list_func() that
applies to an external?
There is no separate list_func() call to list external items. We are
just calling svn_clien
On Tuesday 13 November 2012 06:45 PM, Bert Huijben wrote:
-Original Message-
From: vijay [mailto:vi...@collab.net]
Sent: dinsdag 13 november 2012 14:06
To: Subversion Development
Subject: Re: [PATCH] Implement '--include-externals' option to 'svn list'
On Tuesday
On Tuesday 13 November 2012 03:02 AM, Stefan Sperling wrote:
Attached the updated patch and log message.
+ /* Notify that we're about to handle an external. */
+ SVN_ERR(list_func(baton, NULL, NULL, NULL, NULL,
+externals_parent_url,
+i
On Thursday 08 November 2012 04:10 PM, vijay wrote:
On Wednesday 07 November 2012 08:19 PM, Stefan Sperling wrote:
On Wed, Nov 07, 2012 at 07:54:33PM +0530, vijay wrote:
Thanks stefan for your detailed review.
I will keep in mind all your review comments. I will correct my
mistakes in future
On Wednesday 07 November 2012 08:57 PM, Stefan Fuhrmann wrote:
On Wed, Nov 7, 2012 at 3:02 PM, vijay mailto:vi...@collab.net>> wrote:
On Tuesday 06 November 2012 08:09 PM, Stefan Fuhrmann wrote:
On Mon, Nov 5, 2012 at 5:24 PM, vijay mailto:vi...@collab.net>
&
On Wednesday 07 November 2012 08:19 PM, Stefan Sperling wrote:
On Wed, Nov 07, 2012 at 07:54:33PM +0530, vijay wrote:
Thanks stefan for your detailed review.
I will keep in mind all your review comments. I will correct my
mistakes in future patches.
Attached the updated patch and log message
2 at 09:54:56PM +0530, vijay wrote:
Hi,
This patch implements '--include-externals' option to 'svn list'
[Issue #4225] [1].
All tests pass with 'make check' & 'make davautocheck'.
Attached the patch and log message.
Please review this patch and sha
On Tuesday 06 November 2012 08:09 PM, Stefan Fuhrmann wrote:
On Mon, Nov 5, 2012 at 5:24 PM, vijay mailto:vi...@collab.net>> wrote:
Hi,
This patch implements '--include-externals' option to 'svn list'
[Issue #4225] [1].
All tests pass with 'm
Hi,
This patch implements '--include-externals' option to 'svn list' [Issue
#4225] [1].
All tests pass with 'make check' & 'make davautocheck'.
Attached the patch and log message.
Please review this patch and share your thoughts.
Thanks in advance for your time.
Thanks & Regards,
Vijayagur
On Wednesday 24 October 2012 07:16 PM, C. Michael Pilato wrote:
On 10/24/2012 09:25 AM, vijay wrote:
On Wednesday 24 October 2012 02:33 AM, Ben Reser wrote:
Does it make more sense to make --include-externals behave something
more like --depth rather than a simple boolean?
E.G. it'd b
On Wednesday 24 October 2012 07:16 PM, C. Michael Pilato wrote:
On 10/24/2012 09:25 AM, vijay wrote:
On Wednesday 24 October 2012 02:33 AM, Ben Reser wrote:
Does it make more sense to make --include-externals behave something
more like --depth rather than a simple boolean?
E.G. it'd b
On Wednesday 24 October 2012 02:33 AM, Ben Reser wrote:
On Tue, Oct 23, 2012 at 9:58 AM, vijay wrote:
Hi,
I am working on patch to add '--include-externals' option to 'svn list'
[Issue #4225].
Let me try to answer few questions in the issue comment [1].
Please correct
On Tuesday 23 October 2012 11:42 PM, C. Michael Pilato wrote:
On 10/23/2012 01:46 PM, Bert Huijben wrote:
Before looking at the details some questions about the issue space:
How do you handle externals that are stored in svn:externals many directory
levels up? (Or even defined from above the cu
Hi,
I am working on patch to add '--include-externals' option to 'svn list'
[Issue #4225].
Let me try to answer few questions in the issue comment [1].
Please correct me if I am wrong.
1. What happens with externals inside of externals? Are they also
listed? Does
recursion stop at some point?
On Monday 22 October 2012 06:53 PM, Hyrum K Wright wrote:
On Mon, Oct 22, 2012 at 7:55 AM, Philip Martin
wrote:
hwri...@apache.org writes:
Author: hwright
Date: Sun Oct 21 01:18:26 2012
New Revision: 1400545
URL: http://svn.apache.org/viewvc?rev=1400545&view=rev
Log:
Refactor the pre-1.5 fal
On Wednesday 26 September 2012 03:19 PM, Stefan Sperling wrote:
On Wed, Sep 26, 2012 at 03:52:57AM +0530, vijay wrote:
From the issue[1] description,
When svndumpfilter exclude command accepts path prefixes starting with either
/
or just , I expect it to work the same way when we use with
From the issue[1] description,
When svndumpfilter exclude command accepts path prefixes starting with either
/
or just , I expect it to work the same way when we use with --targets
option.
For Eg :
Both of the following command works fine when we directly provide the
path prefix
$ cat samp
Hi,
The minimum required sqlite version has been bumped to 3.7.12 in r1347802.
However, get-deps.sh script still downloads sqlite-3.7.10. So the
'configure'
script fails as the minimum required version is 3.7.12.
Attached a patch to update this version.
Thanks & Regards,
Vijayaguru
Index: get
On 01/26/2012 06:44 PM, C. Michael Pilato wrote:
Vijay, I think you have misunderstood what these docstrings are claiming.
They are not saying, "When Subversion calls the FS-loading API, it tends to
pass FALSE for validate_props by default."
They are describing the qui
Hi,
This patch fixes a bug in a helper function
subversion/libsvn_repos/load-fs-vtable.c:change_rev_prop() to use
property validation functions if 'validate_props' is 'TRUE'.
As "svnadmin load" does the property validation by default, 'validate_props'
parameter is always set to 'TRUE'. Update
On Friday 14 October 2011 07:56 PM, Philip Martin wrote:
vijay writes:
$ svnmucc put -
svnmucc: invalid option:
../tools/client-side/svnmucc/svnmucc.c:875: (apr_err=70012)
svnmucc: E070012: getopt failure: Bad character specified on command line
Like other Unix utilities you need to use
From "svnmucc --help",
put SRC-FILE URL add or modify file URL with contents copied from
SRC-FILE (use "-" to read from
standard input)
If I use "-" to read from stdin, "svnmucc put" fails with the following
error.
$ svnmucc put -
svnmucc: invalid
On Friday 02 September 2011 03:42 PM, Daniel Shahaf wrote:
Observations after immense exploration by Vijay and me...
I am using OpenSSL0.9.8o and Neon0.27. The problem is that this
version of OpenSSL does not have the SNI support whereas this
version of neon has a (broken) default SNI support
On Monday 22 August 2011 09:37 AM, Prabhu Gnana Sundar wrote:
On Thursday 18 August 2011 06:46 PM, Daniel Shahaf wrote:
I tried your patch against
https://svn.eu.apache.org/repos/asf/subversion/README
(which uses a non-self-signed cert, but rather one for which the cert's
hostname differs from
Hi,
This is follow-up to r1141600. This patch updates a deprecated function
call in libsvn_repos/repos.c.
Attaching the patch and log.
Thanks & Regards,
Vijayaguru
Index: subversion/libsvn_repos/repos.c
===
--- subversion/libsvn_
On Thursday 30 June 2011 05:38 PM, Daniel Shahaf wrote:
Thanks for the pointer. Do we support httpd 2.3+ in 1.6.x?
This is from our INSTALL file in our source tree.
Subversion tries to compile against the latest released version
of Apache httpd 2.X.
I think we need to backport it to
On Thursday 30 June 2011 07:04 AM, Daniel Shahaf wrote:
The problem is that the prototype of ap_log_rerror() in
httpd-2.3.12-beta,
[[[
AP_DECLARE(void) ap_log_rerror(const char *file, int line, int module_index,
int level, apr_status_t status,
On Saturday 04 June 2011 05:27 AM, Peter Samuelson wrote:
Concept patch - not tested. Does this seem reasonable? I'd really
prefer to do all our prompting on the terminal. The fact that this
frees up stdin for things like 'svn patch' and 'svnrdump load' is only
one reason.
I tested your patch
On Friday 03 June 2011 09:01 PM, Stefan Sperling wrote:
Is there any open issue for this?
I don't think so. Please file one. Thanks!
Done. http://subversion.tigris.org/issues/show_bug.cgi?id=3913
Thanks & Regards,
vijayaguru
svnrdump should not be using stdin for input.
It should accept the
On Thursday 02 June 2011 08:36 PM, Daniel Shahaf wrote:
+#--
+def block_unlock_if_pre_unlock_hook_fails(sbox):
+ "block unlock operation if pre-unlock hook fails"
+
+ sbox.build()
+ wc_dir = sbox.wc_dir
+ repo_dir = sbox.rep
On Thursday 02 June 2011 05:05 PM, Philip Martin wrote:
vijay writes:
At the end of the testcase, I thought of checking the status of the
working copy with expected status as "writelocked=K". But I couldn't
do it as the test raises exception in between, i.e., during unlock
o
Hi,
Last week, I was working on this issue: "Whenever the pre-unlock hook
fails, Subversion server sends the error message "Unlock blocked by
pre-unlock hook (exit code 1)" to Apache. But Apache's mod_dav is
not handling the error and it is not sending any error messages to
client side, i
Typo?
s/expect/except
Thanks & Regards,
Vijayaguru
On Tuesday 24 May 2011 04:46 AM, s...@apache.org wrote:
Author: stsp
Date: Mon May 23 23:16:36 2011
New Revision: 1126808
URL: http://svn.apache.org/viewvc?rev=1126808&view=rev
Log:
* subversion/svn/main.c
(svn_cl__options): Remove all lon
Hi,
This is the follow-up to r1126441.
In r1126441, Ivan reduced the no. of RA requests in
subversion/svnsync/main.c: open_source_session() by using
svn_ra_rev_proplist(). This patch does the same during "svnsync info" also.
Attaching the patch and log message.
Thanks & Regards,
Vijayaguru
On Tuesday 05 April 2011 03:12 AM, Daniel Shahaf wrote:
kame...@apache.org wrote on Mon, Apr 04, 2011 at 12:55:38 -:
@@ -438,5 +434,29 @@ fi
say "PASS: master, slave are both at r4, as expected"
-exit 0
+# The following test case is for the regression issue triggered by r917523.
+# The r
On Thursday 24 March 2011 07:41 PM, Kamesh Jayachandran wrote:
On 03/24/2011 05:54 PM, vijay wrote:
Just now I came to know that it fails in neon only.
I configured neon as a default ra_layer in my runtime configuration
area.
When I use serf as ra_layer, the commit succeeds.
Yes that
Hi,
svnmucc's command line option "--config-option" was implemented in
r1080198. As the revision r1080198 misses "break" in a switch case, the
execution falls through to the statements in next case, which in turn
displays usage message.
Attaching the patch and log message.
Thanks & Regards,
On Sunday 27 March 2011 12:21 AM, Mark Phippard wrote:
I would love to see someone do some tests with the WC on local disk vs
network mount (1.6 and 1.7). I tried to do it using some virtual
machines I have access to at CollabNet. The problem is that the
connection of these boxes to the NetApp
Hi,
I have run these tests on ubuntu 10.10 with svn 1.6.12 and svn
1.7.0-dev(r1086476).
Repository access: file://
Attached the results.
Thanks & Regards,
Vijayaguru
On Friday 25 March 2011 11:03 PM, Mark Phippard wrote:
Hi,
I have been working on a framework for writing tests to record
On Thursday 24 March 2011 10:09 PM, Peter Samuelson wrote:
DAV svn
SVNParentPath /repositories
DAV svn
SVNParentPath /repositories-slave
SVNMasterURI "http://localhost/svn 1"
That seems like an incorrect configuration. The SVNMasterURI, like any
other URI, should not have an
atch Vijay.
In my FC14 your testcase passes both with and without patch.
I am investigating
Will get back.
With regards
Kamesh Jayachandran
On 03/24/2011 04:11 PM, vijay wrote:
Hi,
This patch adds a testcase for the regression triggered by r917523
and fixes it.
The revision r917523 do some
Hi,
This patch adds a testcase for the regression triggered by r917523 and
fixes it.
The revision r917523 do some url-encodings to the paths and uris in
subversion/mod_dav_svn/mirror.c.
$svn log -r917523
r917523 | kam
Attached the patch that uses macro based solution. APLOG_USE_MODULE is
used only in case of HTTPD 2.3.
Thanks & Regards,
Vijayaguru
On Wednesday 02 March 2011 12:20 AM, Stefan Sperling wrote:
On Tue, Mar 01, 2011 at 11:08:22PM +0530, Kamesh Jayachandran wrote:
On the whole I preferred the mac
Herewith attached the updated patch and log message.
Thanks & Regards,
Vijayaguru
On Tuesday 01 March 2011 06:30 PM, Stefan Sperling wrote:
On Tue, Mar 01, 2011 at 11:59:28AM +0530, vijay wrote:
[[[
Update log_access_verdict to make it work with httpd trunk as well as older
versions.
Hi,
I tried to compile subversion trunk with httpd trunk code. make fails
with the attached error.
Then I got that there is a macro APLOG_MARK which expands differently in
httpd-2.2.x and httpd-2.3-dev.
From httpd-2.2.x,
#define APLOG_MARK __FILE__,__LINE__
From httpd-2.3-dev,
#define AP
On Saturday 01 January 2011 03:10 AM, Gavin Beau Baumanis wrote:
Ping. This patch has received no comments.
Gavin,
Julian modified this patch and committed in r1050449.
Thanks & Regards,
Vijayaguru
On 18/12/2010, at 2:45 AM, vijay wrote:
Hi,
In r877617, Arfrever improved some mess
Hi,
Attaching the patch that prefixes an underscore with the error messages
to make it visible to translators.
I could see the error messages in mod_dav_svn are not prefixed by an
underscore, may be the subsequent layers will handle the errors and
translate it?
Thanks & Regards,
Vijayaguru
Hi,
We can use SCRATCH_POOL in the calls to
svn_uri_condense_targets/svn_dirent_condense_targets wherever it is
applicable. It will save few bits of memory.
The attached patch forces SCRATCH_POOL usage in few places.
Thanks & Regards,
Vijayaguru
[[[
Pass SCRATCH_POOL to svn_dirent_condense_
On Monday 27 December 2010 03:32 PM, Noorul Islam K M wrote:
vijay writes:
Hi,
This patch replaces few stale comments about svn_path_condense_targets
with svn_uri_condense_targets/svn_dirent_condense_targets in
libsvn_client/locking_commands.c:organize_lock_targets().
Thanks& Reg
Hi,
This patch replaces few stale comments about svn_path_condense_targets
with svn_uri_condense_targets/svn_dirent_condense_targets in
libsvn_client/locking_commands.c:organize_lock_targets().
Thanks & Regards,
Vijayaguru
Index: subversion/libsvn_client/locking_commands.c
==
On Friday 24 December 2010 03:46 PM, vijay wrote:
On Wednesday 22 December 2010 06:42 PM, Daniel Shahaf wrote:
Kamesh Jayachandran wrote on Wed, Dec 22, 2010 at 15:10:46 +0530:
On 12/22/2010 02:02 AM, vijay wrote:
Hi,
I have attached a patch that fixes few deprecation warnings while
Hi,
This patch fixes the bug reported in
http://svn.haxx.se/dev/archive-2010-12/0592.shtml . We need to copy
the value of PCOMMON from SCRATCH_POOL to RESULT_POOL since we are
exiting early when there is only one target uri to work on.
Attached the patch and log message.
Thanks & Regard
On Wednesday 22 December 2010 06:42 PM, Daniel Shahaf wrote:
Kamesh Jayachandran wrote on Wed, Dec 22, 2010 at 15:10:46 +0530:
On 12/22/2010 02:02 AM, vijay wrote:
Hi,
I have attached a patch that fixes few deprecation warnings while
compiling libsvn_client/log.c.
Attached log message also
On Wednesday 22 December 2010 11:32 AM, Noorul Islam K M wrote:
vijay writes:
Hi,
I have attached a patch that fixes few deprecation warnings while
compiling libsvn_client/log.c.
Attached log message also.
I could see this usage at one more place,
subversion/svn/commit-cmd.c. Do you think
Hi,
I have attached a patch that fixes few deprecation warnings while
compiling libsvn_client/log.c.
Attached log message also.
Thanks & Regards,
Vijayaguru
[[[
Reslove some deprecation warnings using uri/dirent functions in its respective
places.
* subversion/libsvn_client/log.c
(svn_clien
Hi,
In r877617, Arfrever improved some messages printed by svnversion
while invoking it on unversioned files and directories.
Updating the same in help doc also.
Herewith attached a patch that updates the help doc string of svnversion
program.
[[[
When svnversion is called on a directory/f
76 matches
Mail list logo
