On Tuesday 13 November 2012 06:45 PM, Bert Huijben wrote:
-----Original Message-----
From: vijay [mailto:vi...@collab.net]
Sent: dinsdag 13 november 2012 14:06
To: Subversion Development
Subject: Re: [PATCH] Implement '--include-externals' option to 'svn list'
On Tuesday 13 November 2012 03:02 AM, Stefan Sperling wrote:
Attached the updated patch and log message.
+ /* Notify that we're about to handle an external. */
+ SVN_ERR(list_func(baton, NULL, NULL, NULL, NULL,
+ externals_parent_url,
+ item->target_dir, iterpool));
The docstring of svn_client_list_func2_t doesn't say if it is valid
for path or dirent to be NULL.
However, you're passing NULL for these parameters before listing the
external. Do we really need these two extra list_func() calls before
and after listing the external? I was expecting them to go away.
If we are removing these list_func() calls, how can we pass the
arguments external_parent_url and external_target to the callback
function? Is there any way to pass those arguments via svn_client_list3()?
Can't you just add the new argument to every call to list_func() that
applies to an external?
There is no separate list_func() call to list external items. We are
just calling svn_client_list3() recursively for each external, which in
turn calls list_func() using get_dir_contents(). I am struggling a bit
hard to carry forward external information via svn_client_list3(). Can
we add two more arguments external_parent_url and external_target to
svn_client_list3()?
If you want to look at the patch, here[1] is the latest version. Any
suggestions are welcome.
[1] http://svn.haxx.se/dev/archive-2012-11/0313.shtml
Thanks & Regards,
Vijayaguru
That would allow removing the initial call, while the callee always has the
information it needs.
Bert
