dsahlberg-apache-org commented on code in PR #28:
URL: https://github.com/apache/subversion/pull/28#discussion_r2071841462
##
subversion/mod_dav_svn/mod_dav_svn.c:
##
@@ -781,6 +781,15 @@ const char *
dav_svn__get_root_dir(request_rec *r)
{
dir_conf_t *conf;
+ const char *
notroj commented on PR #28:
URL: https://github.com/apache/subversion/pull/28#issuecomment-2847561930
Getting there... the tests against httpd trunk were failing because of a
regression in httpd trunk. So that's a nice success :partying_face:
Fixed in
https://github.com/apache/httpd
MarsrockEarth commented on PR #28:
URL: https://github.com/apache/subversion/pull/28#issuecomment-2847563160
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
MarsrockEarth commented on PR #28:
URL: https://github.com/apache/subversion/pull/28#issuecomment-2724190636
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
dsahlberg-apache-org commented on PR #28:
URL: https://github.com/apache/subversion/pull/28#issuecomment-2724189280
@notroj Do you want to add the CI workflow before you commit this or can we
go ahead and commit and close the PR?
--
This is an automated message from the Apache Git Service
notroj commented on PR #28:
URL: https://github.com/apache/subversion/pull/28#issuecomment-2678738474
> Builds and tests complete successfully with HTTPD 2.4.58. Have not tested
with HTTPD trunk and I don't think we have a test case for LocationMatch anyway.
Yeah, I will add a CI work
notroj commented on code in PR #28:
URL: https://github.com/apache/subversion/pull/28#discussion_r1967810459
##
.github/workflows/autoconf.yml:
##
Review Comment:
Ah great, looks perfect.
--
This is an automated message from the Apache Git Service.
To respond to the mes
notroj commented on code in PR #28:
URL: https://github.com/apache/subversion/pull/28#discussion_r1967808026
##
subversion/mod_dav_svn/mod_dav_svn.c:
##
@@ -781,6 +781,15 @@ const char *
dav_svn__get_root_dir(request_rec *r)
{
dir_conf_t *conf;
+ const char *base;
+
Revie
MarsrockEarth commented on PR #28:
URL: https://github.com/apache/subversion/pull/28#issuecomment-2675476968
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
dsahlberg-apache-org commented on code in PR #28:
URL: https://github.com/apache/subversion/pull/28#discussion_r1966095166
##
.github/workflows/autoconf.yml:
##
Review Comment:
I already added something very similar in r1923964/r1923965, didn't notice
this was already incl
notroj commented on PR #28:
URL: https://github.com/apache/subversion/pull/28#issuecomment-2642877175
The arm64 test failure here is interesting, it is likely to be unrelated to
the code change. The arm64 support in GHA is new/experimental so it might be
something random but the tests have
notroj opened a new pull request, #28:
URL: https://github.com/apache/subversion/pull/28
```
mod_dav_svn: Use mod_dav's DAVBasePath setting to determine the
repository root path, allowing SVN to be configured via LocationMatch like:
DAV svn
SVNParentPath /srv/repo
asfgit closed pull request #27: Expand autoconf test matrix
URL: https://github.com/apache/subversion/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
rinrab commented on PR #27:
URL: https://github.com/apache/subversion/pull/27#issuecomment-2629111695
Great!
Actually, I had a few problems with dav tests even in my local environment,
so didn't implement in the workflow.
--
This is an automated message from the Apache Git Service.
dsahlberg-apache-org commented on PR #27:
URL: https://github.com/apache/subversion/pull/27#issuecomment-2629098533
LGTM as of 75995d9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
MarsrockEarth commented on PR #27:
URL: https://github.com/apache/subversion/pull/27#issuecomment-262870
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
notroj opened a new pull request, #27:
URL: https://github.com/apache/subversion/pull/27
Add more build dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
lonicerae commented on PR #26:
URL: https://github.com/apache/subversion/pull/26#issuecomment-2579127061
Thanks @hartmannathan ! Just subscribed.;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
asfgit closed pull request #25: Fix ra-test execution of svnserve in some build
environments.
URL: https://github.com/apache/subversion/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
hartmannathan commented on PR #26:
URL: https://github.com/apache/subversion/pull/26#issuecomment-2572198527
@lonicerae thanks for your input. You're always welcome to join the mailing
lists (see
[https://subversion.apache.org/mailing-lists.html](https://subversion.apache.org/mailing-lists.
lonicerae commented on PR #26:
URL: https://github.com/apache/subversion/pull/26#issuecomment-2572115946
@hartmannathan @dsahlberg-apache-org @stspdotname You're so kind! Thank you
very much! I should register an account to join the discussion on the mailing
list. Let me share your valuabl
lonicerae closed pull request #26: Display the original name of component.
URL: https://github.com/apache/subversion/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
hartmannathan commented on PR #26:
URL: https://github.com/apache/subversion/pull/26#issuecomment-2569759416
In case you haven't seen it... There is a discussion about this PR on the
mailing list (see thread at:
[https://lists.apache.org/thread/8y5dbfxkzc1m1g9x5wpmb0kfp6yfdjgb](https://list
lonicerae commented on PR #26:
URL: https://github.com/apache/subversion/pull/26#issuecomment-2565444995
Hey @dsahlberg-apache-org ! Thank you so much for reviewing this PR! What
you said is exactly what I was concerned about. Such a change would indeed
render scripts that rely on command o
dsahlberg-apache-org commented on PR #26:
URL: https://github.com/apache/subversion/pull/26#issuecomment-2564432858
Changing the call to svn_path_url_add_component2() to svn_path_join() would
remove the url encoding without (otherwise) changing the output format.
svn_path_join is depr
MarsrockEarth commented on PR #26:
URL: https://github.com/apache/subversion/pull/26#issuecomment-2563566629
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
lonicerae opened a new pull request, #26:
URL: https://github.com/apache/subversion/pull/26
* In the old days, the '--summerize' option could show the component's
original's name in the svn URI because it's not escaped. After the commit
3dbf4fb0 the component's name would be escaped. So i
MarsrockEarth commented on PR #25:
URL: https://github.com/apache/subversion/pull/25#issuecomment-2540937694
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
notroj opened a new pull request, #25:
URL: https://github.com/apache/subversion/pull/25
```
Fix ra-test execution of svnserve in some build environments.
* subversion/tests/libsvn_ra/ra-test.c
(open_tunnel): Execute the wrapper with APR_PROGRAM_ENV rather than
APR_PROGRAM
dsahlberg-apache-org commented on PR #22:
URL: https://github.com/apache/subversion/pull/22#issuecomment-1694350936
@maddes-b Thanks for your patch, committed in r1911931. Sorry for the long
delay in getting this sorted!
--
This is an automated message from the Apache Git Service.
To resp
MarsrockEarth commented on PR #22:
URL: https://github.com/apache/subversion/pull/22#issuecomment-1694350852
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
asfgit closed pull request #22: [PATCH] enhance check-mime-type.pl: also check
property-modified files
URL: https://github.com/apache/subversion/pull/22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dsahlberg-apache-org closed pull request #24: fix incorrect words
URL: https://github.com/apache/subversion/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
dsahlberg-apache-org commented on PR #24:
URL: https://github.com/apache/subversion/pull/24#issuecomment-1673091263
Thanks for the patch!
Committed r1911590.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
MarsrockEarth commented on PR #24:
URL: https://github.com/apache/subversion/pull/24#issuecomment-1672596829
您的来信已收到
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
wangqi123a opened a new pull request, #24:
URL: https://github.com/apache/subversion/pull/24
fix incorrect words
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
36 matches
Mail list logo
