Re: svn commit: r1908545 - /subversion/trunk/build.conf

2023-06-11 Thread Bert Huijben
different forms of maintenance nobody notices. The old issue was test only, and I don't think just breaking all WC test on Windows just for build sanityvreasond is a proper fix. This will need a proper fix to allow release testing on Windows again. Bert Sent from Outlook for Android<https:

RE: svn commit: r1905663 - in /subversion/branches/pristines-on-demand-on-mwf/subversion: include/ include/private/ libsvn_client/ libsvn_wc/

2022-12-02 Thread Bert Huijben
because we just check a single boolean in the deprecated api. � � I’m not even sure if this is really worth revving the apis without altering the arguments… We introduced new error codes on existing apis before, like when we switched to WC-NG. � Bert � From: Daniel

RE: SlikSVN/SharpSvn link on website

2022-11-30 Thread Bert Huijben
Thanks! � I moved most of the projects I worked on, from open.collab.net to below https://github.com/ampscm/ (Help / pull requests welcome! ;-) � Bert � From: Daniel Sahlberg Sent: Tuesday, November 29, 2022 10:30 PM To: Mark Phippard Cc: Subversion Development ; rhuij

Re: svn commit: r1903814 - /subversion/branches/issue-4908/subversion/libsvn_wc/deprecated.c

2022-09-21 Thread Bert Huijben
WC-NG, where we didn't have true recursive operations... so we had to lock on many levels separately) Bert On Fri, Sep 9, 2022 at 10:46 PM Nathan Hartman wrote: > On Fri, Sep 9, 2022 at 6:31 AM Bert Huijben wrote: > > > > Why the branch? > > Looks like a quite obvio

Re: svn commit: r1903814 - /subversion/branches/issue-4908/subversion/libsvn_wc/deprecated.c

2022-09-09 Thread Bert Huijben
platforms. Bert On Thu, Sep 1, 2022 at 4:10 PM wrote: > Author: hartmannathan > Date: Thu Sep 1 14:10:23 2022 > New Revision: 1903814 > > URL: http://svn.apache.org/viewvc?rev=1903814&view=rev > Log: > On the 'issue-4908' branch, add the proposed fix >

RE: svn commit: r1902364 - /subversion/trunk/build.conf

2022-07-04 Thread Bert Huijben
want to be able to find bugs in this space. � Bert � From: Daniel Sahlberg Sent: Monday, July 4, 2022 4:29 PM To: Subversion Development Cc: comm...@subversion.apache.org Subject: Re: svn commit: r1902364 - /subversion/trunk/build.conf � Den mån 4 juli 2022 kl 16:07 skrev

RE: svn commit: r1902364 - /subversion/trunk/build.conf

2022-07-04 Thread Bert Huijben
es to specific libraries, like that libs line right above this. This line links the fake serf target, which does have the dependencies for serf... And that one would need fixing if the user has a problem. -Original Message- From: Bert Huijben Sent: Monday, July 4, 2022 4:07 PM To

RE: svn commit: r1902364 - /subversion/trunk/build.conf

2022-07-04 Thread Bert Huijben
ed the fs libraries for building the serf ra layer. Bert

RE: Buildbot Migration

2022-04-22 Thread Bert Huijben
dy else? (I see that the Subversion config is renamed to .disabled and I assume quite a few builds don't apply any more) Otherwise I will look into this, next weekend. Thanks, Bert! -Original Message- From: Gavin McDonald Sent: Thursday, April 21, 2022 10:18 PM To:

RE: Buildbot Migration

2022-04-14 Thread Bert Huijben
tting this SlikSvn sponsored bot back up. Thanks, Bert -Original Message- From: Nathan Hartman Sent: Sunday, April 10, 2022 5:33 PM To: Subversion Developers Subject: Re: Buildbot Migration On Tue, Jan 18, 2022 at 10:52 AM Nathan Hartman wrote: > > On Tue, Jan 18, 20

RE: Windows build

2022-03-18 Thread Bert Huijben
url, after moving away from open.collab.net. (dependency scripts are all in the imports subdirectory) I just upgraded the scripts there to build on Visual Studio 2022 (see r1899028 for the changes on the Subversion side) as that is now the default build environment on GitHub's 'windows-latest' actions. Bert

RE: Fwd: Can't create temporary file from template ... No such file or directory

2021-12-09 Thread Bert Huijben
We have helper functions for this scenario (svn_uri__*()) that also perform the required escaping rules (required for url, but not for relpath) Bert -Original Message- From: Stefan Sperling Sent: Monday, December 6, 2021 9:31 AM To: Nathan Hartman Cc: Subversion Developers

Re: Buildbot Migration

2021-11-10 Thread Bert Huijben
Hi Gavin, I will see what I can do for the win32 Subversion bots. I recently upgraded them to a new VM, but it took some effort to get the old buildbot scripts up and running again. On Tue, Nov 9, 2021 at 12:07 PM Gavin McDonald wrote: > Hi All. > > Getting back to this : https://issues.apache

Re: Missing pilcrows (was: Re: SVN-4874: Avoid foreign repository merge if repository UUIDs) match

2021-08-04 Thread Bert Huijben
7;fix' this, as that would immediately break other working copies) I really hope this comment is now long outdated and we can just enable this Bert On Mon, Apr 26, 2021 at 8:39 PM Daniel Shahaf wrote: > Thanks a lot for fixing these! And kudos for giving the case-by-case > details ☺ >

Re: svn commit: r1891416 - /subversion/site/staging/faq.html

2021-07-12 Thread Bert Huijben
Too bad both Neon and Serf support NTLM and SSPI for quite some time, so the reason is a bit outdated... But I would still recommend enabling that line, as there are quite some users that want to mix accounts and SSPI only allows you access with the one configured for NTLM/SSPI. On Fri, Jul 9, 202

Re: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw

2021-06-23 Thread Bert Huijben
we also see when setting up new bots. Bert Get Outlook for Android<https://aka.ms/AAb9ysg> From: Daniel Shahaf Sent: Thursday, May 27, 2021 7:50:13 PM To: Bert Huijben Cc: dev@subversion.apache.org Subject: Re: svn commit: r1890223 - /subversion

Re: svn commit: r1890674 - /subversion/branches/1.14.x/STATUS

2021-06-23 Thread Bert Huijben
He ran the Subversion + the SharpSvn tests on it without unexpected failures, so I will start delivering binaries for this new platform using these patches. Bert Get Outlook for Android<https://aka.ms/AAb9ysg> From: Nathan Hartman Sent: Thursday, June 10

RE: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw

2021-05-27 Thread bert
dependencies, and ARM64 is new as well so most dependencies need patches (except for those building via CMake) Bert Van: Nathan Hartman Verzonden: woensdag 26 mei 2021 15:00 Aan: dev@subversion.apache.org Onderwerp: Re: svn commit: r1890223 - /subversion/trunk/subversion

RE: svn commit: r1879198 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2020-06-25 Thread bert
It looks like you get failures on this when you compile recent SQLite versions with OMIT_DEPRECATED. (I just bumped several dependencies on the Windows buildbot in an attempt to fix the python breakage) This should probably be backported... Bert -Oorspronkelijk bericht- Van

RE: SVN 1.14 release: please fix your buildbot

2020-05-06 Thread bert
This buildbot runs python 2.X (and has for years) and now the tests are broken. I don't remember seeing changes to the actual Conflict handing code in Subversion itself, so... I still think this is related to the changes to the test framework causing regressions on 2.7. This buildbot does the test

RE: SVN 1.14 release: please fix your buildbot

2020-05-06 Thread bert
The Windows buildbots currently produce actual errors, most likely caused by recent changes to the python test framework. (It is expecting to see \r, but now sees \n in several text conflicts) Bert -Oorspronkelijk bericht- Van: Stefan Sperling Verzonden: donderdag 2 april 2020 16:54

RE: Building SVN (dependencies) on Windows

2020-05-06 Thread bert
’m not sure at which url. Bert Van: Graham Bloice Verzonden: donderdag 23 april 2020 18:17 Aan: dev@subversion.apache.org Onderwerp: Re: Building SVN (dependencies) on Windows Apologies for butting in, but as a long time maintainer of the (mainly Windows) build proce

RE: Svnmucc sensitive to order of mkdir

2020-05-06 Thread bert
flags might be the hardest part here, as svnmucc doesn’t have such options on subcommands yet as far as I know. Bert Van: 钱海远(Nathan) Verzonden: dinsdag 28 april 2020 14:45 Aan: dev@subversion.apache.org Onderwerp: Svnmucc sensitive to order of mkdir Dear all, I

Re: svn commit: r1874093 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

2020-02-17 Thread Bert Huijben
Bsvn/logs/faillog ) Using ';' on a path works on Windows, but is certainly not recommended. It is the path separator used in environment variables like %PATH%. Bert On Mon, Feb 17, 2020 at 3:13 AM wrote: > Author: jamessan > Date: Mon Feb 17 02:13:34 2020 > New Revision: 187

Re: Change to Subversion PMC rule for approving backports

2019-09-18 Thread Bert Huijben
+1 Thanks Julian! On Tue, Sep 17, 2019 at 5:11 PM Branko Čibej wrote: > On 17.09.2019 16:53, Julian Foad wrote: > > Bert Huijben wrote: > >>>>> +1 on reducing the number of required votes to just 2 +1s. > > > > We have consensus in this thread for reduci

Re: [PATCH] test-deps += svnmover

2019-09-05 Thread Bert Huijben
Why can't this be fixed via the build.conf file? I think it can just be added to the [__ALL_TESTS__] group instead of hardcoding it in python. svnauthz is probably an exception as it is related to a symlink. Bert On Mon, Sep 2, 2019 at 4:24 PM Julian Foad wrote: > Daniel Shahaf wrote

Re: Change to Subversion PMC rule for approving backports

2019-09-05 Thread Bert Huijben
, feel free to ping me if you need an additional review for something. I don't follow the dev@ list on a daily basis any more :( +1 on reducing the number of required votes to just 2 +1s. Bert On Thu, Aug 29, 2019 at 5:36 PM Julian Foad wrote: > To all devs: > > Proposal f

Re: Windows build error introduced in revision 1850611

2019-01-16 Thread Bert Huijben
Hi, I happened to find this issue myself today, short before your message was moderated through. I applied a fix to build.conf in r1851462, which should fix the problem. (It is currently being tested by our buildbot). Thanks, Bert On Wed, Jan 16, 2019 at 5:04 PM Alexander Miloslavskiy

Re: Blame callback: remove start/end parameters

2019-01-15 Thread Bert Huijben
. Perhaps if we document that the output arguments are set before the first invocation of the callback, but that would be an API-first. Bert On Tue, Jan 15, 2019 at 1:30 AM Johan Corveleyn wrote: > On Mon, Jan 14, 2019 at 4:13 PM Julian Foad wrote: > > > > Julian Foad w

Re: svn commit: r1850781 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/blame.c libsvn_client/deprecated.c

2019-01-09 Thread Bert Huijben
ow? (I read a comment that this is just stripped now) Bert On Tue, Jan 8, 2019 at 8:41 PM Stefan Kueng wrote: > > > On 08.01.2019 20:30, Michael Pilato wrote: > >> On 08.01.2019 19:45, stevek...@apache.org wrote: > >>> Author: steveking > >>> Date: Tue

Re: Subversion Exception!

2018-12-28 Thread Bert Huijben
we would introduce a minor memory leak. Further +1 Bert On Thu, Dec 13, 2018 at 4:05 PM Julian Foad wrote: > Johan Corveleyn wrote: > > Just thinking out loud here, but could we perhaps log the > > non-canonical value as part of the assertion output? > > [..

Re: svn commit: r1845066 - /subversion/trunk/notes/dump-load-format.txt

2018-10-29 Thread Bert Huijben
s own UUID api. On Windows XP and later, the UuidCreate() function implementing this function for us doesn't encode the MAC. On older (now unsupported) windows versions it did encode it. I'm not sure if this kind of implementation detail belongs in the documentation. Bert On Sun, Oct

Re: [PATCH] Proof of concept of the better-pristines (LZ4 + storing small pristines as BLOBs) (Was: Re: svn commit: r1843076)

2018-10-29 Thread Bert Huijben
On Windows' NTFS implementation very small files (probably something like < 256 bytes, but this is not documented/strictly stable) are stored in the directory table and so don't use 'a whole cluster'. Nice work on all the research! Bert On Tue, Oct 23, 2018 at 6:12

Re: Subversion Exception on commit wirth pathfile

2018-10-18 Thread Bert Huijben
Could you try this same operation with the disk names capitalized? If this resolves the issue, please let us and the TortoiseSVN developers know, as in that case there is an issue in (their) path canonicalization api. Bert On Thu, Oct 18, 2018 at 12:13 PM Johan Corveleyn wrote: > On

Re: svn commit: r1843888 - in /subversion/trunk/subversion: libsvn_client/copy.c tests/cmdline/copy_tests.py

2018-10-17 Thread Bert Huijben
I'm guessing this is an easy fix/patch for backporting to the supported releases. Anybody willing to check+nominate? Bert On Mon, Oct 15, 2018 at 10:55 AM wrote: > Author: brane > Date: Mon Oct 15 08:55:55 2018 > New Revision: 1843888 > > URL: http://svn.apache.org/vie

Re: conflicts-test very slow over svnserve (Windows)

2018-10-02 Thread Bert Huijben
added -6) More recent Windows versions have a workaround/speedup for this problem. They will swap the DNS results after a few failed attempts. Bert On Tue, Oct 2, 2018 at 4:30 PM Branko Čibej wrote: > On 02.10.2018 02:38, Johan Corveleyn wrote: > > I haven't looked deeply into it yet

Re: conflicts-test very slow over svnserve (Windows)

2018-10-02 Thread Bert Huijben
This could be related to log requests that are not somehow limited (by last rev and/or number of results). ra_serf and ar_local allow cancelling halfway through, while ra_svn doesn't. (No time to investigate this myself righ now) Bert On Tue, Oct 2, 2018 at 2:38 AM Johan Corveleyn wrote:

Re: svn commit: r1839703 - /subversion/trunk/subversion/tests/cmdline/svnadmin_tests.py

2018-09-02 Thread Bert Huijben
3.x, which most likely breaks on all legacy Subversion versions as I don't think anybody on Windows tests with Python 3.x yet. Bert On Thu, Aug 30, 2018 at 11:44 PM, Daniel Shahaf wrote: > rhuij...@apache.org wrote on Thu, 30 Aug 2018 21:18 +: > > Author: rhuijben > >

Re: [PATCH] Re: "svn diff" doesn't work correctly if a file is replaced with a symlink locally

2018-07-19 Thread Bert Huijben
For git style patches there is some magic that also allows creating symlinks via the file mode. I think we have some test cases on that behavior. you might be able to use this for building a regression test for this case. Bert On Thu, Jul 19, 2018 at 8:51 PM, Daniel Shahaf wrote: > Dmi

RE: svn commit: r1834612 - in /subversion/branches/1.10.x-issue4758/subversion: libsvn_client/shelve.c tests/cmdline/shelve_tests.py

2018-06-28 Thread Bert Huijben
is the first thing I would think of). I think you should duplicate the hash and explicitly remove a few keys. Bert

RE: shelf-tests failure on macOS

2018-06-14 Thread Bert Huijben
On the testsuite we explicitly disable the sleeps via the environment variable designed for this (except for a few specific tests). We compensate for this problem in quite a few places by making sure that we also change the number of characters in the file. Bert > -Original Mess

RE: Documentation to build SVN 1.10

2018-04-21 Thread Bert Huijben
le on > Linux, but on Windows gen-make.py is used and that does not like the > parameters --with-lz4=internal or --with-utf8proc=internal. As far as I know on Windows these libraries are always used as internal, so you don't have to add arguments for those. Bert

Re: New build requirements for 1.10?

2018-03-15 Thread Bert Huijben
use external LZ4 and utf8proc on Windows yet. Bert On Tue, Mar 13, 2018 at 3:20 PM, Branko Čibej wrote: > On 13.03.2018 14:27, Mark Phippard wrote: > > Starting to put together updated binaries for 1.10 release. Can > > someone summarize any new build requirements, particularly for W

RE: Windows Compile Help

2018-01-29 Thread Bert Huijben
issue, as the optimizations are non-supported and out of date anyway. Bert From: Troy Curtis Jr [mailto:troycurti...@gmail.com] Sent: zondag 28 januari 2018 16:23 To: Nathan Hartman Cc: Subversion Development Subject: Re: Windows Compile Help On Sun, Jan 28, 2018 at 12

RE: svn_dirent_t.size API inconsistency

2017-12-21 Thread Bert Huijben
change the API doc to match > > the implementation, check the code for consistency > > and add an entry to our errata list. +1 on the change. Given that we already have all existing callers do the right thing (so no behavior change), I'm not sure if adding something to our

RE: [PATCH] Use the `WITHOUT ROWID` SQLite optimization for rep-cache.db

2017-12-08 Thread Bert Huijben
guessing it won't help us much on other tables. When we bump the required SQLite version for the client we might want to update the scheme of wc.db to use a sparse index for the move info table. This index contains mostly NULL values, which SQLite can easily stop maintaining, improving wr

[PATCH] Hackathon project: Dumping viewspec

2017-11-24 Thread Bert Huijben
in a patch file attached to this message to allow discussing this feature before putting it on trunk. Bert viewspec-dump.patch Description: Binary data

RE: svn commit: r1815799 - in /subversion/trunk/subversion: libsvn_ra_serf/commit.c tests/libsvn_ra/ra-test.c

2017-11-21 Thread Bert Huijben
ivers explicitly open an existing directory when they want to edit a file... Bert

RE: [RFC] svn commit --parents option needed

2017-11-18 Thread Bert Huijben
alpha > > moved to alpha2 > A +alpha2 > > moved from alpha > $ svn ci alpha2 > $ svn ci --cl my-file -m "edit and move alpha" > Deleting alpha > Adding alpha2 > Transmitting file data .done > Committing transaction... > Committed revision 3. How would this be affected by property changes on parent directories? Should these be committed or not when using --parents. Especially around changes to svn:mergeinfo this could be pretty interesting as it would make it much easier to commit only some parts of a merge without warning. Bert

RE: svn commit: r1811786 - /subversion/trunk/subversion/bindings/swig/include/svn_types.swg

2017-10-23 Thread Bert Huijben
, > pass an empty string to rb_str_new2(). This problem is so common we even have a special svn_md5_digest_to_cstring_display() function for this case that explicitly avoids returning NULL. You might want to switch to that version to document the requested behavior. (Found via the branch update from brane) Bert

RE: Merkle trees in svn [was: Quick question about the sha1-checksum for directories in svn.]

2017-10-05 Thread Bert Huijben
/A/D, /A/mu, and /A's property > > hash, and for descendants of the first two, but that's it. > > That would leak permission settings. A user would know that she only sees a > partial directory merely by checking for the presence of the directory > checksum. We already explicitly leak that there are server excluded subtrees in/for our delta editor / reporter design, so this would not be a security regression. Bert > > -- Brane

RE: Workflow for editing the subversion website

2017-10-04 Thread Bert Huijben
ration, but it literally overwrites > any > changes that may have been made directly to publish/. (I'm glossing over a > detail but that's the gist) I think we should just use svn merge, to avoid these problems? No CMS here. Bert > > Cheers, > > Daniel

Repository load failing on 1.9.x

2017-09-11 Thread Bert Huijben
you still interested in working on a fix for this scenario? Bert

RE: svn commit: r1803143 - in /subversion/trunk/subversion: include/ libsvn_delta/ libsvn_ra_serf/ mod_dav_svn/

2017-08-30 Thread Bert Huijben
ient against a 1.9+ server will always have a checksum, but this is not the case when mixing older clients and servers. Original serf versions (form before we declared this stable) typically never provided the checksum. And in some cases bulk requests didn't have all the checksums either. I remember fixing a few cases around WC-NG to make sure all ra layers reported the same errors in some exceptional cases. Bert

RE: svn commit: r1806552 - /subversion/branches/shelve/subversion/svn/svn.c

2017-08-29 Thread Bert Huijben
shelved changes. Include the first line of any log message\n" > + " and some details about the contents of the change, unless '-q' > is\n" > " given.\n" > "\n" > - " Patch files are named .svn/shelves/NAME.patch\n"), > + " The kinds of change you can shelve are those supported by 'svn > diff'\n" > + " and 'svn patch'. The following are currently NOT supported:\n" > + " mergeinfo changes, copies, moves, mkdir, rmdir,\n" > + " 'binary' content, uncommittable states\n" svn patch supports binary content. The limitation here is probably that currently only 'svn diff --git' produces the patches in the proper form, while other invocations skip binary files. Bert

RE: svn commit: r1806548 - in /subversion/trunk/subversion: svn/svn.c svnbench/svnbench.c tests/cmdline/basic_tests.py

2017-08-29 Thread Bert Huijben
command line 'ls'. Since the actual matching > already confirms to that, we only need a different option pre-processing. Perhaps we could use --glob, to allow other syntax patterns later? Not sure... perhaps --glob is too technical. Bert

RE: [PATCH] Add XFail test for relocating working copy with removed externals

2017-08-29 Thread Bert Huijben
the test list. > ]]] +1 Feel free to commit this. I'll try to commit this later this week if you don't get to this. You can just use your committer name in the Patch by line, to match things up in the contribulyzer. (Or just commit it if you feel like it;-)) Bert

RE: svn commit: r1806017 - /subversion/trunk/subversion/libsvn_ra_serf/merge.c

2017-08-25 Thread Bert Huijben
se is not required when working over HTTPv2 protocol. > When working over HTTPv1, it's only required when the new working copy > properties need to be stored as part of a commit (indicated by a non-null > svn_ra_push_wc_prop_func_t callback). Nice catch! Does this affect performance enough that we should backport this fix? Bert

RE: Data corruption bug in WC, apparently due to race condition?

2017-07-28 Thread Bert Huijben
ole commit is locked. We should do better, but we don't promise that this editing while committing is 100% stable. During the working copy lock we should have exclusive access to the locked parts of the working copy... Bert

RE: svn commit: r1803158 - in /subversion/trunk/subversion/libsvn_subr: compress.c compress_lz4.c compress_zlib.c encode.c

2017-07-27 Thread Bert Huijben
(with props) > subversion/trunk/subversion/libsvn_subr/encode.c (with props) > Removed: > subversion/trunk/subversion/libsvn_subr/compress.c Would have been nice if all these files were based of a copy of compress.c, to allow following history in a bit easier way. Bert

RE: svn commit: r1801970 - in /subversion/branches/shelve-checkpoint/subversion: libsvn_client/shelve.c svn/shelve-cmd.c

2017-07-18 Thread Bert Huijben
ath = svn_path_join_many(scratch_pool, > + local_abspath, ".svn/shelves", > name, > + SVN_VA_NULL); > + > + system(apr_psprintf(scratch_pool, "diffstat %s 2> /dev/null&quo

RE: svn commit: r1801946 - in /subversion/trunk/subversion/libsvn_subr/lz4: LICENSE lz4.c lz4.h

2017-07-17 Thread Bert Huijben
am doesn't have svn:auto-props, so the files I > have added there don't have svn:eol-style. And so, no properties were > set after I copied them. The autoprops are on ^/subversion/trunk and are (or should be) *inherited*. Which client did you use for adding? Bert > > > Regards, > Evgeny Kotkov

RE: [RFC] Shelving and Checkpointing

2017-07-12 Thread Bert Huijben
ing else? > > It is 'svn patch' -- so it raises conflicts. Svn patch creates reject files. It doesn't create conflicts (yet). Bert

RE: [PATCH] Tweak the SHA-1 FAQ entry

2017-07-07 Thread Bert Huijben
.6 or installation of the > aforementioned pre-commit script. > > Storing content with SHA-1 collisions it not a supported use case. If you Except for s/ it / is / on this line, +1... Looks very good! Thanks, Bert > have content with colliding SHA-1 hash values, we suggest

RE: svn commit: r1801108 - in /subversion/trunk/subversion/bindings/javahl/native: Array.cpp CreateJ.cpp Iterator.cpp OperationContext.cpp RemoteSession.cpp RevisionRangeList.cpp

2017-07-07 Thread Bert Huijben
ntext::closeTunnel): Add exception check. > > * subversion/bindings/javahl/native/RemoteSession.cpp > (build_string_array, long_iterable_to_revnum_array, >location_hash_to_map): Add exception check. > > * subversion/bindings/javahl/native/RevisionRangeList.cpp > (RevisionRangeList::RevisionRangeList): Add exception check. Should we backport these to 1.9.x? Bert

RE: 1.8.18 release available for testing/signing

2017-07-05 Thread Bert Huijben
26 serf 1.3.9 sqlite 3.19.3 zlib 1.2.11 Ran the [fsfs] x [local | svn | serf] tests + [bdb] x [local] + JavaHL, verified files with tag, etc. Bert

RE: 1.9.6 up for signing/testing

2017-07-05 Thread Bert Huijben
ows 8.1 VM (x86 build on x64 system) apr 1.6.2 apr-util 1.6.0 apr_memcache 1.6.0 bdb 4.4.20 expat 2.2.0 httpd 2.4.25 mod_dav 2.4.25 openssl 1.0.2l sasl 2.1.26 serf 1.3.9 sqlite 3.19.3 zlib 1.2.11 Ran the [fsfs | bdb] x [local | svn | serf] tests + JavaHL, verified files with tag, etc. Bert

RE: stricter text conflicts in 1.10

2017-05-16 Thread Bert Huijben
Feel free to revert my patch until we find a way to limit the consequences. I expect that we also need to fix a few testcases in separate revisions. Bert Sent from Mail for Windows 10 From: Johan Corveleyn Sent: dinsdag 16 mei 2017 12:17 To: Subversion Development Cc: Stefan Fuhrmann; Bert

RE: svn commit: r1794632 - /subversion/trunk/notes/sha1-advisory.txt

2017-05-10 Thread Bert Huijben
expect "corruption" will turn on people's alarm bells more than your > suggested wording which is very exact but also sounds less dramatic. Those alarm bells are the reason why I wouldn't call it corruption, as that part will probably be highlighted in the media, while there is nothing corrupt on disk. Bert

RE: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS

2017-05-09 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: dinsdag 9 mei 2017 11:26 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS > > On Tue, May 09, 2017 at 09:13:

RE: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS

2017-05-09 Thread Bert Huijben
an environment variable as we did before. There is also a long list of applications where just executing a program by name (without path or anything) is called a security problem. Bert Sent from Mail for Windows 10 From: james...@apache.org Sent: maandag 8 mei 2017 19:56 To: comm

RE: 'svnadmin load-revprops' as first-level command?

2017-04-26 Thread Bert Huijben
Perhaps the revprop load operation was designed to support some kind of 'refresh' of the revprops after an earlier dump/sync. In that case it might make sense to have a specific operation, as that would really change the operation to something completely e

RE: Progress on SHA-1 fixes in patch releases?

2017-03-30 Thread Bert Huijben
there. If no progress is reported on the discussed points I would like to see that change to notice differences (at least temporarily) reverted. Bert Sent from Mail for Windows 10 From: Stefan Sperling Sent: donderdag 30 maart 2017 13:23 To: Paul Hammant Cc: Subversion Development Subject: Re

RE: svn commit: r1786446 - /subversion/trunk/subversion/libsvn_fs_fs/transaction.c

2017-03-20 Thread Bert Huijben
*old_rep = NULL; > } > + > + /* Restore FILE's read / write position. */ > + SVN_ERR(svn_io_file_seek(file, APR_SET, &old_position, scratch_pool)); I'm not sure if that is a safe fix... Need more context for that. You could just have used svn_error_compose_create() and combine both errors. Bert

RE: buildbot failure in on svn-warnings

2017-03-20 Thread Bert Huijben
are installed? (Is there some issue where I can add this information?) Bert From: Greg Stein [mailto:gst...@gmail.com] Sent: woensdag 30 november 2016 03:41 To: dev@subversion.apache.org Subject: Re: buildbot failure in on svn-warnings With the move off of hemera, we'

RE: translations (let's use Transifex or Pootle)

2017-03-16 Thread Bert Huijben
ng the update system two ways, but for now it appears to work... After fixing a few plural form problems in our existing po files all languages except Swedish are now stored as they should be. For some reason Transifex doesn't want me to update Swedish 'sv' resources, but do

RE: translations (buildbot to update translatable strings)

2017-03-13 Thread Bert Huijben
committing around releases. Not sure if we should really start auto commits on our tree... Don't see a good use for these auto commits on trunk, as that code is seldom used in production... And I would like to be careful with our release branches, on not creating too many unneeded commits that could be collapsed... Bert

RE: Files with identical SHA1 breaks the repo

2017-02-24 Thread bert
collision files. That there is a collision now doesn’t change that we always assumed there would be collisions, and designed the current behavior with that in mind. Bert Sent from Mail for Windows 10 From: Stefan Sperling Sent: vrijdag 24 februari 2017 21:47 To: Mark Phippard Cc: Øyvind A

RE: Files with identical SHA1 breaks the repo

2017-02-24 Thread bert
collision found using an insane amount of CPU/GPU power. Of course we should fix things to not break, but that is a different story. Bert Sent from Mail for Windows 10 From: Stefan Sperling Sent: vrijdag 24 februari 2017 17:10 To: Andreas Stieger Cc: Subversion Development Subject: Re: Files

RE: Bug in "svnrdump" ?

2017-02-22 Thread bert
That code is in the backing code for svn_ra_replay(), where it also applies to authz, not on the client. @Julian Foad Can we use svnsync in this scenario, or does that break in a similar way? Bert Sent from Mail for Windows 10 From: Julian Foad Sent: woensdag 22 februari 2017 15:11 To

RE: svn commit: r1783953 - /subversion/site/publish/docs/release-notes/1.10.html

2017-02-22 Thread Bert Huijben
em". Usually we use the term 'node' to describe 'some thing in the working copy' instead of item. Bert

RE: 1.10.0-alpha1 is up for signing

2017-02-21 Thread bert
that were setup to be compatible with those old setups don’t see this problem. Note that I don’t think the unix makefiles build everything either… so they may have similar problems somewhere. But +1 on rerolling anyway. Bert Sent from Mail for Windows 10 From: Stefan Sperling Sent: dinsdag 21

Re: Check SHA vs Content (was: RE: svn commit: r1759233 - /subversion/trunk/subversion/libsvn_wc/questions.c)

2017-02-20 Thread Bert Huijben
below Bert On Thu, Sep 8, 2016 at 5:42 PM, Ivan Zhakov wrote: > On 5 September 2016 at 19:23, Ivan Zhakov wrote: > > On 5 September 2016 at 14:46, Bert Huijben wrote: > >>> -Original Message- > >>> From: i...@apache.org [mailto:i...@apache.org] >

RE: svn commit: r1779617 - /subversion/trunk/subversion/libsvn_ra_svn/client.c

2017-01-20 Thread Bert Huijben
gt; Adapt all path parameter accordingly before passing them to the server. This patch introduces a few calls to dirent functions, that should really be to relpath functions. The buildbot complains with assertions on Windows, as we explicitly test for a few of these cases. Bert >

RE: svn commit: r1776846 - /subversion/trunk/build.conf

2017-01-03 Thread Bert Huijben
h test this applies to: there are other ways to fix tests than making functions exported. Some of our tests explicitly link statically to our libraries to have complete access to usually private functions. I think this is now configured in build.conf, but there used to be some magic name requirement to trigger this behavior. Bert

RE: 1.8.17 up for signing/testing

2016-11-27 Thread Bert Huijben
9 sqlite 3.15.1 zlib 1.2.8 cmake 3.6.2 scons 2.5.0 junit 4.10 All tests passed (after some initial problems starting this VM) Signatures committed Bert Huijben

RE: 1.9.5 up for signing/testing

2016-11-27 Thread Bert Huijben
3.15.1 zlib 1.2.8 All tests passed (after some initial problems starting this VM) Signatures committed Bert Huijben > -Original Message- > From: Evgeny Kotkov [mailto:evgeny.kot...@visualsvn.com] > Sent: maandag 21 november 2016 16:31 > To: Subversion Developmen

RE: svn commit: r1770633 - in /subversion/trunk/subversion: libsvn_wc/wc_db_update_move.c tests/libsvn_client/conflicts-test.c

2016-11-21 Thread Bert Huijben
ode_none || (dst_kind != svn_node_none && src_kind != dst_kind)) { SVN_ERR(tc_editor_delete(nmb, dst_relpath, dst_kind, src_kind, It looks like you are now comparing the source with the highest op-depth info of the source... Bert

RE: Implementing svn_ra_list for ra_serf

2016-11-15 Thread Bert Huijben
rs. If the PROPFIND request doesn't make the current server cache all results in ram, we could do optional server side filtering via the new header + always client side filtering here, to allow the new code to work against old servers... Bert

RE: svn commit: r1769532 - in /subversion/trunk/subversion: include/private/svn_log.h libsvn_fs_x/fs.h libsvn_subr/log.c

2016-11-14 Thread Bert Huijben
? svn_types.h has: /** A combination of all the dirent fields */ #define SVN_DIRENT_ALL ~((apr_uint32_t ) 0) And svn_client.h's svn_client_list4() (since svn_client_list()) uses apr_uint32_t too. Bert

RE: [PATCH] Perl bindings corrupt "{DATE}" revision variable

2016-11-03 Thread Bert Huijben
should just copy the string instead of changing memory that we receive as constant. We might also have a different api function that behaves in a cleaner way. (The current code is better than it used to be, so my +0 stands anyway) Bert From: Roderich Schupp

RE: [PATCH] fix "svnadmin create" fail on x86

2016-11-02 Thread Bert Huijben
or is always the same type, following a set of rules set by the C standard. Besides that the result of the '==' operator on static strings is not defined and commonly different between release and debug builds. And if there is a bug in formatting apr_off_t with that macro it should really be fixed in APR... These macros are designed to abstract away platform specifics, we can't just fix all similar cases in our code. Bert

RE: [PATCH v2] Reject checkouts to existing directory

2016-10-27 Thread bert
evision 20. $ ]] Resuming will now require a –force, which also triggers different behavior in other parts of checkout. Which would require me to update dozens of buildscripts that worked just fine since 1.0, if released. Bert Sent from Mail for Windows 10 From: Stefan Sperling Sent: do

RE: [PATCH] gpg-agent: search gpg-agent socket in $GNUPGHOME

2016-10-27 Thread Bert Huijben
test input is very welcome. Do you know if we need both patches? Bert > > [[[ > gpg_agent: search in $GNUPGHOME for gpg-agent socket > > The socket used to connect to the gpg-agent resides in the GnuPG > home directory, which is by default located at "$HOME/

RE: svn commit: r1764447 - in /subversion/trunk/subversion: libsvn_client/conflicts.c tests/libsvn_client/conflicts-test.c

2016-10-24 Thread Bert Huijben
it tests in our testsuite that verify the current behavior. It is very well possible that this is just the same code moved to a different location. If this is that specific case the problem should be fixed, but it won't be an obvious fix... more a case of careful review of all the cases that trigger this code and then updating expected results. Bert

RE: svn commit: r1765286 - in /subversion/trunk/subversion: include/svn_xml.h libsvn_subr/xml.c tests/libsvn_subr/xml-test.c

2016-10-17 Thread Bert Huijben
d really spend time optimizing that specific usecase (reading pre 1.4 working copies) Bert

RE: [PATCH] Fix for temporarily accepting ssl certificate not working injavahl

2016-10-14 Thread bert
I applied your patch on trunk and nominated it for the next 1.9 release. I created a similar patch for 1.8 as the code has the same bug there. I think the problem became visible after checking the accepted failures was improved in our ra-serf library. Bert Sent from my Windows 10 phone From

RE: svn commit: r1764536 - /subversion/branches/1.9.x/STATUS

2016-10-13 Thread Bert Huijben
it changes a quite generic function by introducing new race conditions in certain error cases. Not something I would like to see in our code forever Bert

RE: [PATCH] Reject checkouts to existing directory

2016-10-12 Thread Bert Huijben
restartable when it fails after some part of the checkout (just like update)... with this patch applied that would also stop being supported. Bert

RE: New SHA1 property for nodes returned 'svn ls --xml' invocations.

2016-10-12 Thread Bert Huijben
ha1s - I'll try to make a small experiment later, > and report back. Small experiment to obtain the SHA-1 of the COMMITTERS file at https://svn.apache.org/repos/asf/subversion/trunk/COMMITTERS ~ (bert@vip) % cadaver https://svn.apache.org/repos/asf/subversion/trunk dav:/repos/asf/subvers

  1   2   3   4   5   6   7   8   9   10   >