All the now deprecated functions now fail unconditionally when the setting is
enabled. Isn’t it possible to do this more graceful whenever a file is
encountered which misses it’s prisite version?
�
As far as I know it is expected that some of the files do have pristines, while
others don’t… That would allow things like diffs on old clients that didn’t
switch apis yet.
�
�
And in many cases these clients might just pass a wc-ctx that was created with
the client api, so they might even have support for obtaining the pristines via
callbacks without even knowing… but now they fail because we just check a
single boolean in the deprecated api.
�
�
I’m not even sure if this is really worth revving the apis without altering the
arguments… We introduced new error codes on existing apis before, like when we
switched to WC-NG.
�
Bert
�
From: Daniel Sahlberg <daniel.l.sahlb...@gmail.com>
Sent: Thursday, December 1, 2022 1:14 PM
To: dev@subversion.apache.org
Cc: comm...@subversion.apache.org
Subject: Re: svn commit: r1905663 - in
/subversion/branches/pristines-on-demand-on-mwf/subversion: include/
include/private/ libsvn_client/ libsvn_wc/
�
Den tors 1 dec. 2022 kl 11:42 skrev <kot...@apache.org
<mailto:kot...@apache.org> >:
Author: kotkov
Date: Thu Dec � 1 10:42:41 2022
New Revision: 1905663
�
[...] �
�
Modified:
subversion/branches/pristines-on-demand-on-mwf/subversion/include/svn_error_codes.h
URL:
http://svn.apache.org/viewvc/subversion/branches/pristines-on-demand-on-mwf/subversion/include/svn_error_codes.h?rev=1905663
<http://svn.apache.org/viewvc/subversion/branches/pristines-on-demand-on-mwf/subversion/include/svn_error_codes.h?rev=1905663&r1=1905662&r2=1905663&view=diff>
&r1=1905662&r2=1905663&view=diff
==============================================================================
---
subversion/branches/pristines-on-demand-on-mwf/subversion/include/svn_error_codes.h
(original)
+++
subversion/branches/pristines-on-demand-on-mwf/subversion/include/svn_error_codes.h
Thu Dec � 1 10:42:41 2022
@@ -581,6 +581,12 @@ SVN_ERROR_START
� � � � � � � SVN_ERR_WC_CATEGORY_START + 42,
� � � � � � � "Incompatible working copy settings")
+ � /** @since New in 1.15 */
+ � SVN_ERRDEF(SVN_ERR_WC_DEPRECATED_API_STORE_PRISTINE,
+ � � � � � � �SVN_ERR_WC_CATEGORY_START + 43,
+ � � � � � � �"This client was not updated to support working copies "
+ � � � � � � �"without local pristines")
+
� �/* fs errors */
�
Is it really "This client"? It looks more to be based on the WC setting.
�
Kind regards,
/Daniel
�
