RE: svn commit: r1363336 - /subversion/trunk/notes/authz_policy.txt

2012-07-19 Thread Kamesh Jayachandran
small typo. -he or see +he or she With regards Kamesh jayachandrancmpil...@apache.org wrote:Author: cmpilato Date: Thu Jul 19 13:54:38 2012 New Revision: 1363336 URL: http://svn.apache.org/viewvc?rev=1363336&view=rev Log: * notes/authz_policy.txt   (REVISION PROPERTIES): It's been years, but

RE: [BUG] Revprop edits are checked for read access.

2012-07-19 Thread Kamesh Jayachandran
>Only if your pre-revprop-change hook allows it. pre-revprop-change is not the place to do path based authz and default hook script allows editing log message. With regards Kamesh Jayachandran

RE: [BUG] Revprop edits are checked for read access.

2012-07-19 Thread Kamesh Jayachandran
This is a bug. This allows editing of log message as long as user has some write access somewhere in the repository not necessarily on the change paths. With regards Kamesh Jayachandran -Original Message- From: C. Michael Pilato [mailto:cmpil...@collab.net] Sent: Thu 7/19/2012 6:21 PM

RE: [PATCH] python script for issue #3961, fixing the bogus mergeinfo

2011-10-03 Thread Kamesh Jayachandran
Thanks Prabhu. I fixed your bogus mergeinfo summary output which was always giving the full mergeinfo. I committed this script in r1178435. With regards Kamesh Jayachandran -Original Message- From: Prabhu Gnana Sundar [mailto:prabh...@collab.net] Sent: Mon 9/19/2011 10:28 PM To

RE: [PATCH] python script for issue #3961, fixing the bogus mergeinfo

2011-09-12 Thread Kamesh Jayachandran
print " The path %s is not found " % path 8. Function parse_args is not used. 9. Function receiver can have more meaningful name. 10. You need to organize your functions in such a way that it appears in some logical order. For example I started my review from 'main()

RE: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-09-06 Thread Kamesh Jayachandran
Thanks Prabhu. Committed this patch in r1165631. With regards Kamesh Jayachandran -Original Message- From: Prabhu Gnana Sundar Ponnarasu Sent: Tue 9/6/2011 12:33 PM To: Kamesh Jayachandran Cc: Vijayaguru Guruchave; dev@subversion.apache.org Subject: Re: [PATCH] get-location-segments.py

RE: [PATCH] get-location-segments.py would work on self-signed ssl servers too

2011-09-05 Thread Kamesh Jayachandran
press 'p' it should preserve and prompt again. It actually preserves this acceptance inside ~/.subversion but somehow it keeps throwing this warning screen. With regards Kamesh Jayachandran -Original Message- From: Prabhu Gnana Sundar [mailto:prabh...@collab.net] Sent: Fri 9/2/20

RE: (Possible) bug in the way we track the mergeinfo property

2011-07-14 Thread Kamesh Jayachandran
record the mergeinfo as per the outcome of location segments report. With regards Kamesh Jayachandran -Original Message- From: Paul Burba [mailto:ptbu...@gmail.com] Sent: Thu 7/14/2011 9:18 PM To: Prabhu Gnana Sundar Ponnarasu Cc: dev@subversion.apache.org Subject: Re: (Possible) bug in

Re: r916286

2011-05-23 Thread Kamesh Jayachandran
On 05/23/2011 09:09 PM, Paul Burba wrote: On Mon, May 23, 2011 at 10:13 AM, Kamesh Jayachandran wrote: On 05/18/2011 02:04 AM, Paul Burba wrote: Author: kameshj Date: Thu Feb 25 13:40:22 2010 New Revision: 916286 URL: http://svn.apache.org/viewvc?rev=916286&view=rev Log: With the b

Re: r916286

2011-05-23 Thread Kamesh Jayachandran
On 05/23/2011 09:09 PM, Paul Burba wrote: On Mon, May 23, 2011 at 10:13 AM, Kamesh Jayachandran wrote: On 05/18/2011 02:04 AM, Paul Burba wrote: Author: kameshj Date: Thu Feb 25 13:40:22 2010 New Revision: 916286 URL: http://svn.apache.org/viewvc?rev=916286&view=rev Log: With the b

Re: r916286

2011-05-23 Thread Kamesh Jayachandran
ch against r916285, I will build it/test it and let you know what is wrong? With regards Kamesh Jayachandran Any insight is appreciated. Paul On the server(proxy) it is an assertion error on the following code block from subversion/mod_dav_svn/mirror.c:proxy_request_fixup assert((uri

Re: [PATCH] - Remove unneeded code from svnadmin

2011-05-23 Thread Kamesh Jayachandran
our two patches together as they are related at r1126459. With regards Kamesh Jayachandran

Re: [PATCH] remove --config-option argument from svnadmin

2011-05-23 Thread Kamesh Jayachandran
"config". Thanks and regards Prabhu Thanks Prabhu, I committed your two patches together as they are related at r1126459. With regards Kamesh Jayachandran

Re: [PATCH] - Remove unneeded code from svnadmin

2011-05-23 Thread Kamesh Jayachandran
"svnadmin: ", "--config-option")); This PATCH ignores --config-option. Bert via r1080198 you seemed to have introduced --config-option to svnadmin. I am not aware of a case where --config-option would be needed for svnadmin. Can you clarify? With regards Kamesh Jayachand

Re: [PATCH] - Remove unneeded code from svnadmin

2011-05-21 Thread Kamesh Jayachandran
well remove the config parameter and pass NULL instead. Prabhu posted similar patch 4 months back http://svn.haxx.se/dev/archive-2011-01/0157.shtml My +1 for this change. With regards Kamesh Jayachandran

RE: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Kamesh Jayachandran
editor drive > close_edit() >Naturally, in such situations, you don't want to open your file batons in >pools that will be destroyed when their parent directory baton's pool is >also destroyed. You need instead for file baton's to have lifetimes that's >about as long as the whole editor drive. Thanks Mike for explaining this. Then such a long living pool would cause similar leak!!! With regards Kamesh Jayachandran

RE: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Kamesh Jayachandran
>Yeah, Kamesh is just incorrect on this. The editor interface has always >allowed multiple simultaneous open files to support what it calls "postfix >text-deltas". I could not understand that. I will try to understand that and fix my code. With regards Kamesh Jayachandran

Re: svn commit: r1102690 - in /subversion/trunk/subversion: libsvn_ra_serf/replay.c tests/cmdline/svnsync_tests.py

2011-05-13 Thread Kamesh Jayachandran
e can not open two files at once on the same editor drive, so no issue. With regards Kamesh Jayachandran

RE: [PATCH] Fix for issue3870 - File descriptor leaks during svnsync

2011-05-13 Thread Kamesh Jayachandran
Committed it in 1102690. -Original Message- From: Kamesh Jayachandran [mailto:kam...@collab.net] Sent: Thu 5/12/2011 10:38 PM To: dev@subversion.apache.org Subject: [PATCH] Fix for issue3870 - File descriptor leaks during svnsync Hi All, Attached patch fixes the File descriptor leaks

[PATCH] Fix for issue3870 - File descriptor leaks during svnsync

2011-05-12 Thread Kamesh Jayachandran
I am just posting here just in case somebody has some opinions. If there are no objections I will commit tomorrow my time. With regards Kamesh Jayachandran Fix for issue3870 "File descriptor leaks during svnsync". Before this fix, all of destination delta editor's interfaces a

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-21 Thread Kamesh Jayachandran
Thanks, Committed this patch in r1095662. With regards Kamesh Jayachandran On 04/18/2011 04:05 PM, Arwin Arni wrote: Hi All, This patch adds a test case to subversion/tests/cmdline/dav-mirror-autocheck.sh to showcase the following bug. In a master/slave repositories setup where writes are

Re: [PATCH] Add a test in dav-mirror-autocheck.sh to showcase a out-of-date slave related bug

2011-04-19 Thread Kamesh Jayachandran
knew to proxy all of the requests back to the master rather than handle any of them off the local replica. FWIW at [1] I originally sent a patch which would provide a RA API to set a request header 'SVN-ACTION' indicating high level svn operation. [1] http://svn.haxx.se/dev/archive-2010-01/0101.shtml With regards Kamesh Jayachandran

Re: [PATCH] Remove redundant url-encoding added in r917523

2011-04-04 Thread Kamesh Jayachandran
Thanks Vijay for the detailed summary and the fix. I committed it at r1088602. With regards Kamesh Jayachandran On 04/04/2011 12:00 PM, vijay wrote: On Thursday 24 March 2011 07:41 PM, Kamesh Jayachandran wrote: On 03/24/2011 05:54 PM, vijay wrote: Just now I came to know that it fails in

Re: [PATCH] Remove redundant url-encoding added in r917523

2011-03-24 Thread Kamesh Jayachandran
exhibits the same failure for both neon and serf. Meanwhile analysing why it succeeds in serf would teach something interesting. With regards Kamesh Jayachandran Thanks & Regards, vijayaguru On Thursday 24 March 2011 05:12 PM, Kamesh Jayachandran wrote: Thanks for the Patch Vijay. In my

Re: [PATCH] Remove redundant url-encoding added in r917523

2011-03-24 Thread Kamesh Jayachandran
Thanks for the Patch Vijay. In my FC14 your testcase passes both with and without patch. I am investigating Will get back. With regards Kamesh Jayachandran On 03/24/2011 04:11 PM, vijay wrote: Hi, This patch adds a testcase for the regression triggered by r917523 and fixes it. The

Re: svn commit: r1081390 - /subversion/trunk/subversion/tests/cmdline/merge_tests.py

2011-03-15 Thread Kamesh Jayachandran
+def dry_run_merge_conflicting_binary(sbox): + "dry run shouldn't make conflict resoln files" ^ typo? Thanks Stefan. Fixed in r1081703. With regards Kamesh Jayachandran

RE: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-14 Thread Kamesh Jayachandran
>> Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530: >> > Unless there are no objection I will commit this patch post I >> > receive a r1075802 regression fix(and testcase) from either Daniel >> > Becroft or Arwin. >> >> Hold on, are y

RE: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-14 Thread Kamesh Jayachandran
Kamesh Jayachandran wrote on Fri, Mar 11, 2011 at 18:12:21 +0530: >> Unless there are no objection I will commit this patch post I >> receive a r1075802 regression fix(and testcase) from either Daniel >> Becroft or Arwin. >Hold on, are you suggesting to commit the two thou

Re: [PATCH] Add a test to cover the regression introduced in r1075802

2011-03-14 Thread Kamesh Jayachandran
iccups.. Regards, Arwin Arni I'm sorry I overlooked the docstring length again.. Here's the corrected patch. Regards, Arwin Arni Thanks Arwin. Committed your patch in r1081390. With regards Kamesh Jayachandran

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-11 Thread Kamesh Jayachandran
r1075802 regression fix(and testcase) from either Daniel Becroft or Arwin. With regards Kamesh Jayachandran On 03/02/2011 09:00 PM, Arwin Arni wrote: Hi All, Thanks for all the feedback. As Stefan said, yes, this patch was an immense learning experience for me and I wouldn't trade i

Re: svn commit: r1080198 - in /subversion/trunk: subversion/svnadmin/main.c tools/client-side/svnmucc/svnmucc.c

2011-03-10 Thread Kamesh Jayachandran
t support --config-option. Not sure why we need --config-option for svnadmin? With regards Kamesh Jayachandran

Re: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-02 Thread Kamesh Jayachandran
Thanks Vijay. Committed your in r1076234. With regards Kamesh Jayachandran On 03/02/2011 03:18 PM, vijay wrote: Attached the patch that uses macro based solution. APLOG_USE_MODULE is used only in case of HTTPD 2.3. Thanks & Regards, Vijayaguru On Wednesday 02 March 2011 12:20 AM, St

Re: [PATCH] Add --dry-run flag to "svn update" client command

2011-03-02 Thread Kamesh Jayachandran
for a newcomer. As a newcomer I would post a working patch than start a discussion(of course only if the idea is straightforward) which is often open-ended and confuses/discourages the new-comer if he is *not* that serious about the feature he proposes. With regards Kamesh Jayachandran

RE: [PATCH] Compiling subversion trunk with httpd trunk code fails

2011-03-01 Thread Kamesh Jayachandran
(...) >#endif >} >so that the callers don't have to change. >On the whole I preferred the macro solution. Me to prefer the orignal macro based solution. With regards Kamesh Jayachandran

Re: [PATCH] Fix failing expected error in blame_tests.py

2011-02-17 Thread Kamesh Jayachandran
rgets " + \ "because some targets don't exist\n" Do we need full error message in the expected error? With regards Kamesh Jayachandran expected_err_re = re.compile(expected_err) Stefen, Please find attached modified patch. Log [[[ Fix failing expect

RE: svn commit: r1068411 - /subversion/trunk/subversion/tests/cmdline/authz_tests.py

2011-02-11 Thread Kamesh Jayachandran
l.startswith("http"): +expected_error_for_cat = ".*[Ff]orbidden.*" + else: +expected_error_for_cat = ".*svn: E170001: Authorization failed.*" + Do you mean to reinstate errorcodes(E175013, E175013, E175009) check ? With regards Kamesh Jayachandran

RE: svn commit: r1068411 - /subversion/trunk/subversion/tests/cmdline/authz_tests.py

2011-02-11 Thread Kamesh Jayachandran
of the specific message we're generating >today; it's bound to change later. >(eg, the XML parsing thing would ideally go away at some point) >Just 'Access.*${mu_url}.*forbidden' is enough IMO. Thanks We fixed this in r1068802 Still we have "E170001:" for svnserve would remove it as soon as I reach before my working copy. With regards Kamesh Jayachandran

Re: [PATCH] Fix for Issue #3781 (Case Sensitive Authz)

2011-02-11 Thread Kamesh Jayachandran
On 02/11/2011 07:49 PM, Arwin Arni wrote: On Friday 11 February 2011 07:06 PM, Kamesh Jayachandran wrote: Thanks Arwin. Committed at r1069791. With regards Kamesh Jayachandran Here is the follow-up patch that fixes the deprecated calls of svn_config_read. Regards, Arwin Arni Thanks

Re: [PATCH] Fix for Issue #3781 (Case Sensitive Authz)

2011-02-11 Thread Kamesh Jayachandran
e documentation. This is the last correction. I promise. Thanks Arwin. Committed at r1069791. With regards Kamesh Jayachandran Regards, Arwin Arni

RE: [PATCH] New XFail test for issue 3781

2011-02-09 Thread Kamesh Jayachandran
Thanks Prabhu committed your patch in r1068802. With regards Kamesh Jayachandran -Original Message- From: Prabhu Gnana Sundar Ponnarasu Sent: Wed 2/9/2011 2:30 PM To: Bert Huijben Cc: Kamesh Jayachandran; dev@subversion.apache.org Subject: Re: [PATCH] New XFail test for issue 3781 Hi

RE: [PATCH] New XFail test for issue 3781

2011-02-08 Thread Kamesh Jayachandran
) + ":/A/mu": "jrandom =", +mixed_case_repo_dir + ":/A/mu": "jrandom = rw"} + write_authz_file(sbox, {}, sec_mixed_case) You can reduce this to simpler one as most of the time same 'cat' and 'commit' is tested with

RE: [PATCH] New XFail test for issue 3781

2011-02-08 Thread Kamesh Jayachandran
Prabhu, Please send the patch against the current HEAD. With regards Kamesh Jayachandran -Original Message- From: Prabhu Gnana Sundar Ponnarasu Sent: Tue 2/8/2011 1:11 PM To: Kamesh Jayachandran Cc: dev@subversion.apache.org Subject: [PATCH] New XFail test for issue 3781 Hi Kamesh

RE: [PATCH] New XFail test for the issue 3781

2011-02-07 Thread Kamesh Jayachandran
uot;jrandom = rw"} and try 'read' on /A/mu which should fail with case sensitivity fix but succeed in HEAD. Name your testcase with what it intends to test. i.e case_insensitive_authz makes me get confused. May be you can name it case_sensitive_authz Thanks With regards Ka

Re: svn commit: r1064168 - in /subversion/trunk/subversion/include/private: svn_eol_private.h svn_fs_util.h svn_mergeinfo_private.h svn_opt_private.h svn_sqlite.h svn_wc_private.h

2011-01-27 Thread Kamesh Jayachandran
eol marker found in [@a buf, @a endp) as a > - * NUL-terminated string, or NULL if no eol marker is found. > NUL is not a typo I guess, NUL means '\0', While NULL is (void *) 0x. With regards Kamesh Jayachandran

RE: svn commit: r1064093-/subversion/trunk/subversion/libsvn_repos/authz.c

2011-01-27 Thread Kamesh Jayachandran
>-Original Message- >From: Daniel Shahaf [mailto:d...@daniel.shahaf.name] >Sent: Fri 1/28/2011 12:16 AM >To: Kamesh Jayachandran; Arwin Arni Nandagopal >Cc: dev@subversion.apache.org >Subject: Re: svn commit: >r1064093-/subversion/trunk/subversion/libsvn_re

RE: svn commit: r1064093 -/subversion/trunk/subversion/libsvn_repos/authz.c

2011-01-27 Thread Kamesh Jayachandran
ev svn_config_read to accept bool case_sensitive_section_parser. Then we can change the behaviour to always case-sensitive approach as against today's case-insensitive approach. With regards Kamesh Jayachandran

Re: [PATCH] Fix for Issue #3781 repo prefix rules in authz section is checked case sensitively for commit

2011-01-27 Thread Kamesh Jayachandran
etely accustomed to the indentation conventions.. Here's a patch with the indentation fixed.. Thanks Arwin. Committed the patch in r1064093. With regards Kamesh Jayachandran Regards, Arwin Arni

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Kamesh Jayachandran
os_create(&repos, opt_state->repository_path, NULL, NULL, - config, fs_config, pool)); + NULL, fs_config, pool)); If you do not need 'config' as well you need *not* populate it. With regards Kamesh Jayachandran

Re: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2011-01-05 Thread Kamesh Jayachandran
With regards Kamesh Jayachandran [PS] Unless I am mistaken svn_fspath__* can be used in libsvn_repos too instead of svn_path_* wherever applicable and hence a chance to become public. I don't quite understand what you mean here. I meant subversion/libsvn_repos/commit.c:delete_entry()

Re: [PATCH] make diff against copy-source by default

2011-01-05 Thread Kamesh Jayachandran
Prabhu, I am fine with this patch. I would wait till next Monday(10th Jan) to get community's opinion on this before committing this. With regards Kamesh Jayachandran On 12/30/2010 08:37 PM, Prabhu Gnana Sundar wrote: Hi all, This patch is a follow up to the patch that I gave last

Re: [PATCH] tweaked svnrdump to handle junk values with "--version"

2011-01-03 Thread Kamesh Jayachandran
Hi Prabhu, I committed this patch in r1054583. Thanks With regards Kamesh Jayachandran On 01/01/2011 03:07 AM, Gavin Beau Baumanis wrote: Ping. This patch submission has received no comments. On 17/12/2010, at 5:46 PM, Prabhu Gnana Sundar wrote: Hi, In my previous patch, I just tweaked

RE: svn commit: r1054229 - /subversion/trunk/subversion/libsvn_subr/opt.c

2011-01-01 Thread Kamesh Jayachandran
>- SVN_ERR(svn_cmdline_fputs(_("Copyright (C) 2010 The Apache Software >Foundation.\n" >+ SVN_ERR(svn_cmdline_fputs(_("Copyright (C) 2011 The Apache Software >Foundation.\n" Won't this be 2010-2011? With regards Kamesh Jayachandran

RE: svn commit: r1054168 - /subversion/trunk/subversion/libsvn_ra_serf/win32_auth_sspi.c

2010-12-31 Thread Kamesh Jayachandran
>URL: http://svn.apache.org/viewvc?rev=1054168&view=rev >Log: >* subversion/libsvn_ra_serf/win32_auth_sspi.c > (sspi_maxtokensize): Add a paren missing from r1054115. Thanks for fixing. Sorry for *not* taking note of it. With regards Kamesh Jayachandran

Re: svn upgrade segfaults

2010-12-31 Thread Kamesh Jayachandran
Committed the fix in r1054133. With regards Kamesh Jayachandran On 12/30/2010 09:35 PM, Kamesh Jayachandran wrote: Hi All, I did the following. cd /tmp cd svn-1.6 co file:///repo/abc touch abc/test svn-1.6 add abc/test #Make sure below commit fails either by a pre-commit hook or File system

Re: [PATCH] Make error messages visible to translator

2010-12-31 Thread Kamesh Jayachandran
Vijay, I removed the server side(related portions from libsvn_subr) of this change from this patch and committed the rest in r1054115. With regards Kamesh Jayachandran On 12/29/2010 12:28 PM, vijay wrote: Hi, Attaching the patch that prefixes an underscore with the error messages to make

Re: svn upgrade segfaults

2010-12-31 Thread Kamesh Jayachandran
Thanks Arwin. Committed your patch at r1054090. With regards Kamesh Jayachandran On 12/31/2010 04:31 PM, Arwin Arni wrote: Hi Kamesh, Here is the new patch and log message and the .tar.bz2 file. Regards, Arwin Arni Arwin, Sorry, I guess my description can be reduced to even simple form. I

Re: svn upgrade segfaults

2010-12-31 Thread Kamesh Jayachandran
/test svn-1.7 upgrade With regards Kamesh Jayachandran On 12/31/2010 02:58 PM, Arwin Arni wrote: On Thursday 30 December 2010 09:35 PM, Kamesh Jayachandran wrote: Hi All, I did the following. cd /tmp cd svn-1.6 co file:///repo/abc touch abc/test svn-1.6 add abc/test #Make sure below commit

svn upgrade segfaults

2010-12-30 Thread Kamesh Jayachandran
runk build corresponds to 1053813:1053833 With regards Kamesh Jayachandran

Re: [PATCH] Remove unused parameters in libsvn_wc/update_editor.c:accumulate_last_change()

2010-12-30 Thread Kamesh Jayachandran
fixed the function calls. I have attached the patch and the log message. Please review and respond. Regards, Arwin Arni Thanks Arwin. Committed in r1053833. If we had "-Wextra" to our gcc invocation we could have caught it by the compiler!. With regards Kamesh Jayachandran

RE: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Kamesh Jayachandran
. * doc string of such functions(semi-public a.k.a intra library functions/private(should we even have such one in headers?)) should promptly say so in the headers. * start with __svn like we see in some of the libc headers. The vague __ starting would signal about the scope/ABI nature of the AP

RE: Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-29 Thread Kamesh Jayachandran
re why r1053469 need to be reverted. IIUC it still keeps the svn_error__locate by changing it to NOOP. Which I think is enough to keep ABI. With regards Kamesh Jayachandran

Re: [PATCH] fixes some path related deprecation warnings

2010-12-28 Thread Kamesh Jayachandran
ill begin. */ const char *base_path; With regards Kamesh Jayachandran

Any idea why public function like "svn_fspath__dirname" have double "__" in its name?

2010-12-28 Thread Kamesh Jayachandran
s_ancestor svn_fspath__get_longest_ancestor svn_error__locate svn_error__malfunction IIUC "__" convention is used for semi-public functions where we may not keep BC promise. Do I miss something? With regards Kamesh Jayachandran

RE: svn commit: r1052817 - /subversion/trunk/subversion/tests/libsvn_subr/error-test.c

2010-12-25 Thread Kamesh Jayachandran
vn_error_purge_tracing(svn_error_t *err); Are you sure? With regards Kamesh Jayachandran

RE: [PATCH] Fix some deprecation warnings

2010-12-24 Thread Kamesh Jayachandran
Thanks Vijay. Committed in r1052547. With regards Kamesh Jayachandran -Original Message- From: Vijayaguru Guruchave Sent: Fri 12/24/2010 9:42 PM To: dev@subversion.apache.org Cc: Daniel Shahaf; Kamesh Jayachandran Subject: Re: [PATCH] Fix some deprecation warnings On Friday 24

Re: svn commit: r1051745 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2010-12-23 Thread Kamesh Jayachandran
On 12/22/2010 07:21 PM, Hyrum K. Wright wrote: On Wed, Dec 22, 2010 at 1:15 AM, Kamesh Jayachandran wrote: On 12/22/2010 09:38 AM, bl...@apache.org wrote: Author: blair Date: Wed Dec 22 04:08:14 2010 New Revision: 1051745 URL: http://svn.apache.org/viewvc?rev=1051745&view=rev Log: Up

Re: [PATCH] Fix some deprecation warnings

2010-12-22 Thread Kamesh Jayachandran
ol destruction down? + SVN_ERR(svn_uri_condense_targets(&url_or_path,&condensed_targets, + target_urls, TRUE, pool, pool)); With regards Kamesh Jayachandran

Re: svn commit: r1051745 - /subversion/trunk/subversion/tests/libsvn_fs/fs-test.c

2010-12-21 Thread Kamesh Jayachandran
{ + return svn_error_create +(SVN_ERR_FS_GENERAL, NULL, + "commit failed but no error was returned"); Same as above. Thanks With regards Kamesh Jayachandran

Re: [Question] Svn log show code diff

2010-12-19 Thread Kamesh Jayachandran
Hi Zhang, This feature is already available via "--diff : produce diff output" option log command in upcoming svn 1.7. With regards Kamesh Jayachandran On 12/20/2010 08:47 AM, Zhang, Wei-Jovi (NSN - CN/Hangzhou) wrote: Hi, I have a question about svn l

Re: [PATCH] clears a deprecation warning during "make"

2010-12-16 Thread Kamesh Jayachandran
s". :) Thanks and Regards Prabhu Thanks Prabhu. Committed in r1049924. With regards Kamesh Jayachandran

Re: [PATCH] Remove redundant member - libsvn_wc/update_editor.c:file_baton.added_with_history

2010-12-16 Thread Kamesh Jayachandran
. Please review and respond. Regards, Arwin Arni Thanks Arwin. Committed it in r1049819. With regards Kamesh Jayachandran

Re: subscribe me

2010-12-12 Thread Kamesh Jayachandran
On 12/13/2010 12:15 PM, britto wrote: i need to follow the discussion going on the community..please give me acess Britto, Send a mail to dev-subscr...@subversion.apache.org You would receive automated response. Just reply to it and you are in. With regards Kamesh Jayachandran

RE: [PATCH] enhance diff to make it behave uniformly

2010-12-08 Thread Kamesh Jayachandran
>I hear "he will" and "he would". I am one feet away from him geographically and reviewed his work closely and hence got resonated to answer moment I saw Julian emails. Sorry if it meant anything else. With regards Kamesh Jayachandran

ambient_depth_filter_editor is not ignoring 'SVN_ERR_WC_PATH_NOT_FOUND' errors.

2010-12-08 Thread Kamesh Jayachandran
right now. I am yet to run full testsuite, I ran only diff_tests with this patch and Prabhu's patch it passes. Any thoughts? With regards Kamesh Jayachandran Index: subversion/libsvn_wc/ambient_depth_filter_editor.c === ---

Re: [PATCH] enhance diff to make it behave uniformly

2010-12-08 Thread Kamesh Jayachandran
On 12/08/2010 09:21 PM, Julian Foad wrote: On Sat, 2010-12-04, Kamesh Jayachandran wrote: I understand your patch fixes the following two cases. 1. svn di -cN explicitly_reinstated_file_with_mod_at_rN Hi Kamesh and Prabhu. What you're describing here sounds good - it sounds like a simple

RE: [PATCH] enhance diff to make it behave uniformly

2010-12-03 Thread Kamesh Jayachandran
line1 +line2 >Please could you include a test for these cases in your patch? Then it >will be absolutely clear. Prabhu already has one. Right now he is working on removing the profileration of UI param diff-copy-from from all the layer in favour of generic send_copyfrom_args. With regards Kamesh Jayachandran

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Kamesh Jayachandran
On 12/03/2010 09:04 PM, Mark Phippard wrote: On Fri, Dec 3, 2010 at 10:28 AM, Kamesh Jayachandran wrote: Forgive my ignorance Paul. IIUC in 1.5.x we can only have neon or serf not both. Did you do 2 builds to test this? I think you are confusing it with 1.4.x. We added support in 1.5.x for

Re: 1.5.9 up for testing/signing

2010-12-03 Thread Kamesh Jayachandran
svn | http (neon) | http (serf) ] JavaHL Bindings Forgive my ignorance Paul. IIUC in 1.5.x we can only have neon or serf not both. Did you do 2 builds to test this? With regards Kamesh Jayachandran RESULTS: All tests pass. +1 to release. PLATFORM: - MS Windows 7 Home Premiu

Re: svn commit: r1041068 - in /subversion/trunk/subversion: libsvn_client/diff.c tests/cmdline/depth_tests.py tests/cmdline/diff_tests.py

2010-12-03 Thread Kamesh Jayachandran
On 12/01/2010 11:57 PM, Kamesh Jayachandran wrote: Hi Kamesh, I don't think this change in diff output is desirable. In 1.6.x, you get lines like: Property changes on: . in a diff. You made it print: Property changes on: instead. Is there a way to fix the assertion problem without cha

RE: svn commit: r1041068 - in /subversion/trunk/subversion: libsvn_client/diff.c tests/cmdline/depth_tests.py tests/cmdline/diff_tests.py

2010-12-01 Thread Kamesh Jayachandran
put? Right now away from my build area. Will get back. I need to check its usability with git too. With regards Kamesh Jayachandran

Re: [PATCH] Assertion error with trunk binaries diff

2010-12-01 Thread Kamesh Jayachandran
On 11/30/2010 09:32 PM, Kamesh Jayachandran wrote: Hi All, ~/tunk-build/bin/svn di -c1035797 https://svn.apache.org/repos/asf/subversion/branches/1.6.x --git throws the following assertion error. svn: ../subversion/libsvn_subr/dirent_uri.c:1199: svn_relpath_join: Assertion

Re: [PATCH] enhance diff to make it behave uniformly

2010-12-01 Thread Kamesh Jayachandran
new param diff-copy-from in all the layers and assume it to be TRUE unless "--show-copies-as-adds" is given. Thanks With regards Kamesh Jayachandran On 11/30/2010 03:26 PM, Prabhu Gnana Sundar wrote: Hi, In my previous patch [1] I suggested the addition of the '--diff-copy-from

[PATCH] Assertion error with trunk binaries diff

2010-11-30 Thread Kamesh Jayachandran
es it. Did *not* run the testsuite would commit it later. With regards Kamesh Jayachandran Index: subversion/libsvn_client/diff.c === --- subversion/libsvn_client/diff.c (revision 1040586) +++ subversion/libsvn_client/d

RE: Will send_copyfrom_args be reverted for 'ra' layers too just like in issue #3711

2010-11-24 Thread Kamesh Jayachandran
done in a same commit as copy'. Without this switch it would show all the lines as 'added' with this switch it would show only 'the modified lines'. While debugging some issue I could see 'svnlook diff --diff-copy-from' doing exactly the same and asked Prabh

Re: Fix for issue 3609 - ls command

2010-11-09 Thread Kamesh Jayachandran
(ls_url_special_characters, test_list): New test Patch by: Noorul Islam K M ]]] Thanks Noorul. I tweaked for a cosmetic consistency and committed in r1033045. With regards Kamesh Jayachandran

Re: [PATCH] Fix for issue 3609 - cat command

2010-11-09 Thread Kamesh Jayachandran
(cat_url_special_characters, test_list): New test Patch by: Noorul Islam K M ]]] Thanks and Regards Noorul Thanks for the patch, Committed in r1033028. With regards Kamesh Jayachandran

Re: [PATCH] To improve the documentation of svn_path.h

2010-11-08 Thread Kamesh Jayachandran
uri|dirent|relpath}_split do not seem like its deprecating function. So removed that portion from your patch. Committed the patch at r1032610. With regards Kamesh Jayachandran svn_path_url_add_component)

Re: [PATCH] mailer.py : Use python difflib.unified_diff instead of *nix diff command

2010-11-08 Thread Kamesh Jayachandran
command. Patch by: Noorul Islam K M Suggested by: Kamesh Jayachandran ]]] Thanks for the patch Noorul. I could not *see* the difference in the output. I tried with few file mod commit mails both via external diff and difflib. I committed this patch with small refactoring at r1032568. With rega

Re: [PATCH] Avoid allocating memory to extract basename using svn_relpath_basename

2010-10-04 Thread Kamesh Jayachandran
) Pass NULL pointer to svn_relpath_basename wherever the returned basename need not be persistent. Patch by: Vijayaguru G Suggested by: Kameshj ]]] Thanks committed in r1004306. With regards Kamesh Jayachandran Thanks& Regards, Vijayaguru

Re: svn commit: r981665 - in /subversion/branches/performance/subversion: include/private/svn_file_handle_cache.h include/private/svn_temp_serializer.h libsvn_subr/svn_file_handle_cache.c libsvn_subr/

2010-08-03 Thread Kamesh Jayachandran
formance/subversion/libsvn_subr/svn_file_handle_cache.c (original) +++ subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c Mon Aug 2 19:36:59 2010 @@ -1,5 +1,5 @@ /* - * svn_file_handle_cache.c: open file handle caching for Subversion + * svn__file_handle_cache.c: open file handle caching for Subversion * I guess it is a find and replace error. I mean file name still remains same. Thanks With regards Kamesh Jayachandran

Re: svn commit: r979282 - in /subversion/trunk/subversion/svnrdump: dump_editor.c dump_editor.h load_editor.c load_editor.h svnrdump.c

2010-07-26 Thread Kamesh Jayachandran
mp__get_load_editor'. With regards Kamesh Jayachandran

Re: svn commit: r979094 - /subversion/trunk/subversion/svnrdump/svnrdump.c

2010-07-26 Thread Kamesh Jayachandran
On 07/26/2010 05:25 PM, Ramkumar Ramachandra wrote: Hi Kamesh, Kamesh Jayachandran writes: This breaks the 2 tests in svnrdump_tests. Though the following inline patch may fix it you may have different plans Thanks! Yes, I'm aware that it breaks tests. Unfortunately, I hav

Re: svn commit: r979094 - /subversion/trunk/subversion/svnrdump/svnrdump.c

2010-07-26 Thread Kamesh Jayachandran
True, create_wc = False) - r, out, err = svntest.main.run_svnrdump(sbox.repo_url) + r, out, err = svntest.main.run_svnrdump("dump", sbox.repo_url) if (r != 0): raise svntest.Failure('Result code not 0') With regards Kamesh Jayachandran On 07/26/2010 12:51 AM, artag...@apache.org

Re: [PATCH] new feature, lazy sync via export --skipfilesmatchingsize

2010-07-26 Thread Kamesh Jayachandran
Hi Ann, Patch has not reached the list. Did you forget attach it? With regards Kamesh Jayachandran On 07/26/2010 08:34 AM, svnusert...@href.com wrote: [[[ Contributed Feature: enable lazy sync via new export flag, --skipfilesmatchingsize * subversion/libsvn_client/export.c

Re: Info needed in 1.6.x STATUS file

2010-06-16 Thread Kamesh Jayachandran
is not happening rather commit happens in slave itself. Commit happens in the slave? That's certainly and obviously wrong. But I don't understand what you mean by "the configured slave url has the *encodable* characters". Hope I made it clear now in the STATUS file in my recent commit. With regards Kamesh Jayachandran

RE: Expansion of authz policy name leak (was: svn commit: r933194 - /subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c)

2010-04-12 Thread Kamesh Jayachandran
s using a workaround of which was leaking the same info. With regards Kamesh Jayachandran

Re: svn commit: r933194 - /subversion/trunk/subversion/mod_authz_svn/mod_authz_svn.c

2010-04-12 Thread Kamesh Jayachandran
The feature that you ask for is possible only if 'mod_dav_svn'(which implements SVNListParentPath) consults mod_authz_svn(or some authorizer) for every item listed which is not the case today. With regards Kamesh Jayachandran

Re: [PATCH] Fix for issue 2753 "SVNListParentPath feature doesn't work when svn authz is used."

2010-04-09 Thread Kamesh Jayachandran
On 04/08/2010 09:23 PM, Philip Martin wrote: Kamesh Jayachandran writes: [issue2753] Fix issue 2753. Let me see if I understand: The issue is that when SVNListParentPath and AuthzSVNAccessFile are configured then GET requests for the parent path get passed through the authz stuff

RE: [PATCH] Fix for issue 2753 "SVNListParentPath feature doesn't work when svn authz is used."

2010-04-08 Thread Kamesh Jayachandran
>I think this check would make more sense in access_checker rather than >req_check_access. Let me see and do if needed. >The code needs a comment to say why no access control is neccessary in >this case. Will update the comment. With regards Kamesh Jayachandran

[PATCH] Fix for issue 2753 "SVNListParentPath feature doesn't work when svn authz is used."

2010-04-08 Thread Kamesh Jayachandran
the testsuite, It did not break any new tests. [[[ [issue2753] Fix issue 2753. Relax requests aimed at the repo Parent path from authz control. * subversion/mod_authz_svn/mod_authz_svn.c (req_check_access): When canonicalized 'uri' and 'root_path'

  1   2   >