Re: Ruby SWIG bindings fail to build with upcoming GCC-15 release

2025-04-05 Thread James McCoy
On Thu, Apr 03, 2025 at 11:10:29AM +0900, Jun Omae wrote: Hi, On 2025/04/03 10:27, James McCoy wrote: As noted in the [porting docs], GCC-15 uses c23 (well, gnu23) by default. This causes -Wincompatible-pointer-types errors to occur when building the Ruby SWIG bindings due to the rb_ensure

Ruby SWIG bindings fail to build with upcoming GCC-15 release

2025-04-02 Thread James McCoy
As noted in the [porting docs], GCC-15 uses c23 (well, gnu23) by default. This causes -Wincompatible-pointer-types errors to occur when building the Ruby SWIG bindings due to the rb_ensure, rb_iterate, and rb_rescue2 callbacks. [porting docs]: https://gcc.gnu.org/gcc-15/porting_to.html This can

Python's removal of asyncore/asynchat in 3.12 affects svnpubsub/client.py

2023-07-02 Thread James McCoy
Hi all, Python 3.6 deprecated the asyncore and asynchat modules in favor of the asyncio module. Per [PEP 594], that means that the modules will be removed in Python 3.12, thus breaking svnpubsub/client.py. Is there someone familiar enough with these Python modules to work on updating svnpubsub?

Re: JavaHL problem with NativeException

2022-07-16 Thread James McCoy
On Sat, Jul 16, 2022 at 10:49:50PM +0200, Daniel Sahlberg wrote: > dev@: I would prefer to commit this in two separate commits, first the test > cases and second the fix. But I could not find any way to "XFail" the test > case. You can use junit's Ignore annotation. [[[ import org.junit.Ignore; .

Re: Subversion's test fails on aarch64, ppc64 and ppc64le

2022-03-05 Thread James McCoy
On Thu, Mar 03, 2022 at 10:13:57AM -0500, Nathan Hartman wrote: > Looks like this patch fixes the failure for Debian and Fedora. If it > solves it for openSUSE also, we should consider committing and > nominating it for backport... Committed in r1898633. Thanks again for the patch, Alexandr. Che

Re: Subversion's test fails on aarch64, ppc64 and ppc64le

2022-03-02 Thread James McCoy
On Wed, Mar 02, 2022 at 03:47:23PM +, Danilo Spinella wrote: > Hi, > > I am the openSUSE maintainer of subversion package. With the latest > version, the automated build of subversion 1.14.1 for Tumbleweed is > failing due to the following test failure: > > 1) > testCrash_RequestChannel_nati

Re: Fwd: Can't create temporary file from template ... No such file or directory

2021-12-05 Thread James McCoy
On Sun, Dec 05, 2021 at 12:41:30PM -0500, Nathan Hartman wrote: > It's not dumping core on mine. I would like to debug this properly but > am running into various nonsense. For example, I haven't figured out > how to run it under gdb since svn is being called through the libtool > script; "libtool

Re: JavaHL test failure and warning in 1.14.1

2021-11-30 Thread James McCoy
On Wed, Nov 24, 2021 at 03:10:21PM +0300, Alexandr Miloslavskiy wrote: > On 24.11.2021 15:07, James McCoy wrote: > > The comment says IOException, but this is InterruptedException. Is that > > intentional? > > > Catching InterruptedException is simply to be able to

Re: JavaHL test failure and warning in 1.14.1

2021-11-24 Thread James McCoy
On Wed, Nov 24, 2021 at 02:13:20AM +0300, Alexandr Miloslavskiy wrote: > Indeed there was a race condition where TunnelAgent could begin writing at > the same time when pipe is being closed. This resulted in an unexpected > IOException, which was detected by the test. > Please find the patch attac

Re: JavaHL test failure and warning in 1.14.1

2021-11-22 Thread James McCoy
On Tue, Nov 23, 2021 at 12:54:49AM +0300, Alexandr Miloslavskiy wrote: > On 22.11.2021 3:35, James McCoy wrote: > > Yes, I just hit it as composing this email, although I hadn't in an > > earlier 100x loop of the JavaHL suite. > > Could you please give more infor

Re: JavaHL test failure and warning in 1.14.1

2021-11-21 Thread James McCoy
On Wed, Jul 28, 2021 at 11:55:56PM +0300, Alexandr Miloslavskiy wrote: > I have tested on Ubuntu 20.04 (on x86-64 arch): > > * Ran entire JavaHL test package 130 times > (using a loop in shell script). > Not a single error; tests succeed every single time. > > * Ran just the reported test 100

Re: svn commit: r1894491 - /subversion/trunk/INSTALL

2021-10-22 Thread James McCoy
On Fri, Oct 22, 2021 at 06:43:24PM -, dsahlb...@apache.org wrote: > Modified: subversion/trunk/INSTALL > URL: > http://svn.apache.org/viewvc/subversion/trunk/INSTALL?rev=1894491&r1=1894490&r2=1894491&view=diff > == > -

Re: Commit reviews' author statistics: bus factor issue?

2021-04-26 Thread James McCoy
On Sun, Apr 25, 2021 at 10:44:32AM -0400, Nathan Hartman wrote: > On Fri, Apr 23, 2021 at 9:40 AM Daniel Shahaf wrote: > > At the end of the N weeks, we can look at the experience and data we'll > > have then, and decide how to continue: whether to revert to CTR, switch > > to RTC, keep the new sy

Re: JavaHL test failure and warning in 1.14.1

2021-02-16 Thread James McCoy
On Mon, Feb 15, 2021 at 08:25:26AM +0100, Johan Corveleyn wrote: > On Fri, Feb 12, 2021 at 6:36 PM James McCoy wrote: > > > > One of the new JavaHL tests > > (testCrash_RequestChannel_nativeRead_AfterException) is failing on > > Debian's armhf, mips64el, mipsel, a

Re: JavaHL test failure and warning in 1.14.1

2021-02-15 Thread James McCoy
On Mon, Feb 15, 2021 at 08:25:26AM +0100, Johan Corveleyn wrote: > On Fri, Feb 12, 2021 at 6:36 PM James McCoy wrote: > > > > One of the new JavaHL tests > > (testCrash_RequestChannel_nativeRead_AfterException) is failing on > > Debian's armhf, mips64

JavaHL test failure and warning in 1.14.1

2021-02-12 Thread James McCoy
One of the new JavaHL tests (testCrash_RequestChannel_nativeRead_AfterException) is failing on Debian's armhf, mips64el, mipsel, and powerpc builders: https://buildd.debian.org/status/logs.php?pkg=subversion&ver=1.14.1-1&suite=sid There was 1 failure: 1) testCrash_RequestChannel_nativeRe

Re: [PATCH] Fix tests failing on Debian due to lack of 'python' command.

2021-01-26 Thread James McCoy
On Tue, Jan 26, 2021 at 01:47:23AM -0600, Karl Fogel wrote: > On recent versions of Debian GNU/Linux, the 'python' command doesn't > normally exist. Instead, there are separate 'python3' and 'python2' > commands. > > As a result, four tests fail in the Subversion test suite as of > r1885910, all

Re: svn commit: r1880914 - /subversion/branches/1.14.x/STATUS

2020-08-17 Thread James McCoy
On Mon, Aug 17, 2020 at 08:13:25AM +, Daniel Shahaf wrote: > james...@apache.org wrote on Mon, 17 Aug 2020 03:00 -: > > +++ subversion/branches/1.14.x/STATUS Mon Aug 17 03:00:37 2020 > > @@ -32,24 +32,25 @@ Candidate changes: > > * r1880886 > > Fix crash in JavaHL JNI wrapper caused b

Re: JNI segfault while running Java tests

2020-08-11 Thread James McCoy
On Sun, Aug 09, 2020 at 11:10:42PM +0200, Daniel Sahlberg wrote: > I have investigated further and I think I have found the issue. A patch is > attached, basically changing  >     const String::Contents key(String(m_env, jkey)); > to  >     const String str(m_env, jkey); >     const String::Content

Re: [PATCH] Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC

2020-08-10 Thread James McCoy
On Fri, Aug 07, 2020 at 08:47:07PM +0200, Alexandr Miloslavskiy wrote: > Please find test snippet and patch attached. > > [[[ > Fix JavaHL crash in TunnelAgent.CloseTunnelCallback after GC > > When jobject reference is kept across different JNI calls, a new global > reference must be requested wi

Re: JNI segfault while running Java tests

2020-08-08 Thread James McCoy
On Sat, Aug 08, 2020 at 10:35:14AM -0400, James McCoy wrote: > The Debian builds for 1.14.0 recently started crashing while running the > Java tests. This is pretty far out of my expertise, so hopefully > someone can help out. > > I've attached the hs_err file. > > T

JNI segfault while running Java tests

2020-08-08 Thread James McCoy
The Debian builds for 1.14.0 recently started crashing while running the Java tests. This is pretty far out of my expertise, so hopefully someone can help out. I've attached the hs_err file. The tests used to pass with OpenJDK 11.0.7+10 and we recently got an update to 11.0.8+10. I'm trying to

Re: Subversion 1.14.0 up for testing/signing

2020-05-26 Thread James McCoy
On Wed, May 20, 2020 at 02:34:41PM +0200, Stefan Sperling wrote: > The 1.14.0 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > and add your signatures there. > > Thanks! > > This release is essentially

Re: Email moderators

2020-05-12 Thread James McCoy
On Mon, May 11, 2020 at 03:03:57PM +, Daniel Shahaf wrote: > Julian Foad wrote on Tue, 05 May 2020 15:55 +0100: > > James McCoy wrote: > > > According to https://www.apache.org/dev/committers.html#mailmod, either > > > an INFRA ticket or mail to apmail@ can change

Re: Email moderators

2020-05-05 Thread James McCoy
On Tue, May 05, 2020 at 01:18:15PM +0100, Julian Foad wrote: > I'd like to step down from being a moderator of dev@ and private@, please. > Can someone make that be so, or tell me how to proceed? According to https://www.apache.org/dev/committers.html#mailmod, either an INFRA ticket or mail to apm

Re: Problems on configure about SWIG Python bindings (Re: Subversion 1.14.0-rc2 up for testing/signing)

2020-04-17 Thread James McCoy
On Wed, Apr 15, 2020 at 01:56:28PM +, Michael Pilato wrote: > Minor nit with the patch:  I'm not sure that the phrase "Farther version > check" parses clearly.  Maybe say, instead: > >              # Look more closely at the SWIG and Python versions to >              # determine SWIG_PY_OPTS.

ctypes-python and Python3 (Re: Subversion 1.14.0-rc2 up for testing/signing)

2020-04-12 Thread James McCoy
On Sat, Apr 11, 2020 at 10:28:16AM +0100, Julian Foad wrote: > Stefan Sperling wrote: > > The 1.14.0-rc2 release artifacts are now available for testing/signing. > > +1 for release (Unix). > > Tested on Ubuntu 18.04: > (serf, ra-svn, ra-local) x (fsfs, bdb) > javahl > swig-py, swig-pl, swig

Re: Subversion 1.14.0-rc2 up for testing/signing

2020-04-09 Thread James McCoy
On Wed, Apr 08, 2020 at 12:18:01PM +0200, Stefan Sperling wrote: > Everyone, thanks for all the contributions you have made for -rc2! > > The 1.14.0-rc2 release artifacts are now available for testing/signing. > Please get the tarballs from > https://dist.apache.org/repos/dist/dev/subversion > a

Re: [PATCH] (Re?)allow the creation of release tarballs that support py2 bindings

2020-04-09 Thread James McCoy
On Thu, Apr 09, 2020 at 06:09:30PM +, Michael Pilato wrote: > For your consideration, a patch to allow the creation of release tarballs that > support py2 bindings (instead of py3 ones). +1 Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB

Re: The manual step in the minor branch creation workflow [1]

2020-04-07 Thread James McCoy
On Thu, Mar 26, 2020, 20:28 Daniel Shahaf wrote: > Setting up the merges bot is currently a manual step, as HACKING correctly > describes. Without that step, svn-role nightly merges won't happen for the > 1.14.x branch. This is done now. (That step _could_ be automated — for example, by addin

Re: SVN 1.14 release: please fix your buildbot

2020-04-02 Thread James McCoy
On Thu, Apr 02, 2020 at 08:47:21PM -0400, James McCoy wrote: > On Thu, Apr 02, 2020 at 04:53:47PM +0200, Stefan Sperling wrote: > > On Mon, Mar 16, 2020 at 09:27:28AM +0100, Stefan Sperling wrote: > > > Hi Bert and Brane, > > > > > > Your windows-ra and

Re: SVN 1.14 release: please fix your buildbot

2020-04-02 Thread James McCoy
On Thu, Apr 02, 2020 at 04:53:47PM +0200, Stefan Sperling wrote: > On Mon, Mar 16, 2020 at 09:27:28AM +0100, Stefan Sperling wrote: > > Hi Bert and Brane, > > > > Your windows-ra and macosx-apr1.3-nothread buildbots are currently failing. > > > > If possible please fix them, or retire them if the

Re: branching 1.14.x

2020-03-15 Thread James McCoy
On Sat, Mar 14, 2020 at 10:32:04AM -0400, James McCoy wrote: > On Sat, Mar 14, 2020 at 03:26:48PM +0100, Stefan Sperling wrote: > > On Sat, Mar 14, 2020 at 10:12:41AM -0400, Mark Phippard wrote: > > > My only advice would be to reach a point where we accept no one is going >

Re: branching 1.14.x

2020-03-14 Thread James McCoy
On Sat, Mar 14, 2020 at 03:26:48PM +0100, Stefan Sperling wrote: > On Sat, Mar 14, 2020 at 10:12:41AM -0400, Mark Phippard wrote: > > My only advice would be to reach a point where we accept no one is going to > > step up and fix this on Windows and then decide accordingly. If we can fix > > it >

Re: svn commit: r1874093 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

2020-03-05 Thread James McCoy
On Mon, Feb 17, 2020 at 10:27:11AM +0100, Bert Huijben wrote: > I think this needs a specific implementation for Windows. The rules on Windows > are different and not really tied to some shell. > Applications receive the full commandline as string and then need to parse > them > themselves. Usuall

Re: svn commit: r1874057 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

2020-02-16 Thread James McCoy
On Sun, Feb 16, 2020 at 10:06:49AM -0500, James McCoy wrote: > On Sun, Feb 16, 2020 at 09:59:53AM +, Daniel Shahaf wrote: > > James McCoy wrote on Sat, 15 Feb 2020 13:10 -0500: > > > Well, that makes this more involved... I guess the simplest option is to > > > do

Re: svn commit: r1874057 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

2020-02-16 Thread James McCoy
On Sun, Feb 16, 2020 at 09:59:53AM +, Daniel Shahaf wrote: > James McCoy wrote on Sat, 15 Feb 2020 13:10 -0500: > > Well, that makes this more involved... I guess the simplest option is to > > do our own scan of the string and pre-escape any whitespace before > > hav

Re: svn commit: r1874057 - in /subversion/trunk/subversion: libsvn_subr/cmdline.c tests/cmdline/update_tests.py

2020-02-15 Thread James McCoy
On Sat, Feb 15, 2020 at 05:26:25PM +, Daniel Shahaf wrote: > james...@apache.org wrote on Sat, 15 Feb 2020 16:24 -: > > Escape filenames when invoking $SVN_EDITOR > > > > Per https://subversion.apache.org/faq.html#svn-editor, $SVN_EDITOR is > > invoked > > through the shell instead of dir

Re: Escape filename for conflict merge

2020-02-13 Thread James McCoy
On Thu, Feb 13, 2020 at 07:40:41PM +, Daniel Shahaf wrote: > So in this case, to rename pi to "p i" you'll probably want start the > test by doing that rename as an 'svn mv' (svntest.main.run_svn()), > commit it as r2, run update (sbox.simple_update()), and then in the > remainder of the test f

Re: Escape filename for conflict merge

2020-02-08 Thread James McCoy
On Thu, Dec 26, 2019 at 11:17:20PM -0500, James McCoy wrote: > On Wed, Dec 11, 2019 at 03:12:56PM +, Julian Foad wrote: > > Stefan Sperling wrote: > > > My first question would be: Could anyone could test this on Windows? > > > (Assuming you've been testing on

Re: OpenBSD buildbot

2019-12-31 Thread James McCoy
On Tue, Dec 31, 2019 at 05:04:00PM +0100, Stefan Sperling wrote: > On Tue, Dec 31, 2019 at 04:27:06PM +0100, Branko Čibej wrote: > > On 31.12.2019 16:05, Stefan Sperling wrote: > > > On Tue, Dec 31, 2019 at 10:33:45AM +0100, Branko Čibej wrote: > > >> The OpenBSD buildbot seems to have a 50% chance

Re: Escape filename for conflict merge

2019-12-26 Thread James McCoy
On Wed, Dec 11, 2019 at 03:12:56PM +, Julian Foad wrote: > Stefan Sperling wrote: > > My first question would be: Could anyone could test this on Windows? > > (Assuming you've been testing on Debian, as usual.) Yes, any testing from folks with Windows systems would be welcome. This recipe is

Escape filename for conflict merge

2019-12-10 Thread James McCoy
When a text conflict occurs during a merge, the user is given the option to resolve the conflict and we spawn their editor for them. In svn_cmdline__edit_file_externally, we explicitly use the shell to invoke the editor, so that $SVN_EDITOR can be a command with arguments rather than just a binary

Re: svn commit: r1869134 - /subversion/trunk/tools/dist/release.py

2019-10-29 Thread James McCoy
On Tue, Oct 29, 2019 at 11:21:04PM -, danie...@apache.org wrote: > Author: danielsh > Date: Tue Oct 29 23:21:04 2019 > New Revision: 1869134 > > URL: http://svn.apache.org/viewvc?rev=1869134&view=rev > Log: > * tools/dist/release.py > (write_news): Validate the argument to the --news-release

Re: Supported SWIG version on swig-py3

2019-10-29 Thread James McCoy
On Tue, Oct 29, 2019 at 11:40:35AM +0100, Stefan Sperling wrote: > On Tue, Oct 29, 2019 at 11:37:17AM +0100, Branko Čibej wrote: > > Our .tar.bz2 and .tar.gz packages contain source files generated by > > Swig. A packager /can/ decide to regenerate them; I don't know why they > > would want to, but

Re: 1.13.x and swig-py3

2019-10-22 Thread James McCoy
On Mon, Oct 21, 2019 at 01:35:45PM +0200, Branko Čibej wrote: > On 21.10.2019 13:16, Julian Foad wrote: > > Johan Corveleyn wrote: > >> Nathan Hartman wrote: > >>     Branko Čibej  wrote: > >> > By the principle of least surprise, I think it > >> > would be better to merge to trunk, creat

Re: The run up to Subversion 1.13.0

2019-08-30 Thread James McCoy
On Fri, Aug 30, 2019 at 05:12:21PM +0100, Julian Foad wrote: > 2. As 1.13 is only weeks away, there is little point in making any further > 1.12.x patch releases from now on, so I will not plan to do so. > > Any other thoughts on anything we ought to include, or to do? Finishing(?) and merging th

Re: [PATCH] Re: SVN-4783 KWallet assumes KDE5 when Qt5 present

2019-01-28 Thread James McCoy
On Mon, Nov 19, 2018 at 02:19:12PM -0600, Satya Mishra wrote: > Hi, > > As requested in the bug report, here’s a patch that doesn’t hard-code the > path to kf5-config, but instead assumes it’s in the path. > > > The test for kwallet assumes KDE5 when Qt5 present, but that is not > > necessarily

Re: Common header(s) for C and C++ API

2018-12-31 Thread James McCoy
On Mon, Dec 31, 2018 at 12:07:23AM +0100, Branko Čibej wrote: > Summary: I propose to create one or possibly several new public header > files that will be used by both the C and C++ public APIs. > > > I would like to completely hide the dependency on APR from the public > parts of the C++ API. I

Re: svn commit: r1849737 - in /subversion/trunk/subversion/bindings/cxx: include/svnxx.hpp include/svnxx/exception.hpp src/aprwrap/pool.hpp src/exception.cpp src/private/exception-private.hpp tests/te

2018-12-26 Thread James McCoy
On Thu, Dec 27, 2018 at 12:18:11AM +0100, Branko Čibej wrote: > On 26.12.2018 23:44, Daniel Shahaf wrote: > > Branko Čibej wrote on Wed, 26 Dec 2018 23:37 +0100: > >> On 26.12.2018 23:21, Daniel Shahaf wrote: > >>> Branko Čibej wrote on Wed, 26 Dec 2018 22:41 +0100: > On 26.12.2018 19:50, Dani

Re: [PATCH] svn/conflict-callbacks.c indentation fix

2018-11-02 Thread James McCoy
On Fri, Nov 02, 2018 at 11:08:10AM +0100, Stefan Sperling wrote: > On Fri, Nov 02, 2018 at 10:49:23AM +0100, Branko Čibej wrote: > > On 02.11.2018 10:44, Stefan Sperling wrote: > > > I confirm that your patch is correct. I mis-indented these blocks. > > > > Time to start using a real editor, I gue

Re: SVN-4530 describes a really nasty bug in our command-line parsing

2018-10-27 Thread James McCoy
On Sat, Oct 27, 2018 at 11:19:10PM +0200, Branko Čibej wrote: > First, read this: https://issues.apache.org/jira/browse/SVN-4530 > > Then watch this (hold my beer): > > $ svnadmin create repo > $ svn co file://$(pwd)/repo wc > Checked out revision 0. > $ svn mkdir wc/foo > A wc/foo > $ to

Re: svn commit: r1831895 - in /subversion/trunk: build/ac-macros/java.m4 build/generator/gen_win.py configure.ac subversion/bindings/javahl/README

2018-09-26 Thread James McCoy
On Tue, Sep 25, 2018 at 10:04:18AM +0200, Johan Corveleyn wrote: > On Sat, May 19, 2018 at 4:48 PM wrote: > > > > Author: jamessan > > Date: Sat May 19 14:48:35 2018 > > New Revision: 1831895 > > > > URL: http://svn.apache.org/viewvc?rev=1831895&view=rev > > Log: > > Bump minimum JDK version requi

Re: Feature freeze for 1.11

2018-09-08 Thread James McCoy
e working on or planning any other enhancements, features, or > > anything that needs to be 'frozen'? I could still use some help getting the Java 10 support finalized on Windows, if someone has cycles for that. Cheers, -- James GPG Key: 1024D/61326D40 2003-09-02 James McCoy

Re: JDK 10 removal of javah

2018-07-09 Thread James McCoy
On Thu, May 17, 2018 at 10:27:18PM -0400, James McCoy wrote: > The biggest wrinkle is that "javac -h" _only_ generates a header file if > there are native annotations, whereas "javah" would always generate a > header file. This found some places where we didn

Minimum version of JDK for Subversion 1.10 (was Re: JDK 10 removal of javah)

2018-05-18 Thread James McCoy
On Fri, May 18, 2018 at 09:46:41AM +0200, Stefan Sperling wrote: > Elsewhere in this discussion thread it was suggested to raise the > minimum JDK version requirement to Java 1.8. > Your statement "please keep backward compatibility with older JDKs" > could mean anything between "please leave every

Re: JDK 10 removal of javah

2018-05-17 Thread James McCoy
On Fri, May 04, 2018 at 08:12:29AM -0400, James McCoy wrote: > On Sat, Dec 23, 2017 at 06:44:13PM +0100, Branko Čibej wrote: > > On 23.12.2017 16:30, Andreas Stieger wrote: > > > Hello, > > > > > > I was made aware by our Java package maintainer of the fact tha

Re: JDK 10 removal of javah

2018-05-04 Thread James McCoy
On Sat, Dec 23, 2017 at 06:44:13PM +0100, Branko Čibej wrote: > On 23.12.2017 16:30, Andreas Stieger wrote: > > Hello, > > > > I was made aware by our Java package maintainer of the fact that JDK 10 > > is removing the javah tool, after the deprecation from JDK 8. Our javahl > > stuff no longer bui

Re: Strange libtool errors when try to build pyhton and ruby bindings (1.10.0)

2018-04-16 Thread James McCoy
On Mon, Apr 16, 2018 at 03:30:24PM +0200, Branko Čibej wrote: > On 16.04.2018 14:29, James McCoy wrote: > > On Mon, Apr 16, 2018 at 10:42:31AM +0200, Branko Čibej wrote: > >> [Moved from users@] > >> > >> On 16.04.2018 10:36, Branko Čibej wrote: > >>

Re: Strange libtool errors when try to build pyhton and ruby bindings (1.10.0)

2018-04-16 Thread James McCoy
On Mon, Apr 16, 2018 at 10:42:31AM +0200, Branko Čibej wrote: > [Moved from users@] > > On 16.04.2018 10:36, Branko Čibej wrote: > > The problem is that Swig has become a build-time dependency now. We > > don't configure the Swig bindings unless Swig is installed, even if the > > binding sources a

Re: Warnings from the bindings

2018-03-30 Thread James McCoy
On Fri, Mar 30, 2018 at 09:29:47AM +0200, Branko Čibej wrote: > On 30.03.2018 00:27, Philip Martin wrote: > > Philip Martin writes: > > > >> +1 to release > > The swig-pl tests produce warnings for: > > > > Warning: unable to close filehandle $out_fh properly: Bad file descriptor > > at > > /h

Re: svn commit: r1825787 - /subversion/trunk/subversion/tests/libsvn_subr/utf-test.c

2018-03-03 Thread James McCoy
On Sat, Mar 03, 2018 at 10:21:37PM +0100, Branko Čibej wrote: > On 03.03.2018 22:03, james...@apache.org wrote: > > Author: jamessan > > Date: Sat Mar 3 21:03:09 2018 > > New Revision: 1825787 > > > > URL: http://svn.apache.org/viewvc?rev=1825787&view=rev > > Log: > > * subversion/tests/libsvn_sub

libsvn_subr/utf-test failure due to unaligned memory access

2018-03-03 Thread James McCoy
This test has been failing for some time on Debian's alpha buildd[0]. One of the alpha porters looked into it and gave a thorough diagnosis[1] of the issue which basically boils down to: using a char* as apr_uint16_t*/apr_int32_t* is going to result in unaligned access. In a (much belated) reply[2

Re: Potential regression: high server-side memory consumption during import

2018-03-03 Thread James McCoy
On Sat, Mar 03, 2018 at 06:54:06PM +0100, Branko Čibej wrote: > P.S.: Running tests now with the patched 1.10.x, will vote on the > backport as soon as that's done. If it's approved, I believe we have to > move our expected release date from 28th March to 4th April? According to the flowchart post

Re: Building Subversion on Debian stretch with serf support

2018-02-28 Thread James McCoy
On Wed, Feb 28, 2018 at 11:15:07AM +, Philip Martin wrote: > Paul Hammant writes: > > > Or is there an option to hand `apt-get` that really lassos in the serf > > binary for the same of making Subversion with client support for http(s) > > checkouts. > > Typically Debian installs libraries t

Re: shelve is (surprisingly) sensitive to working directory

2018-01-03 Thread James McCoy
On Tue, Jan 02, 2018 at 12:06:47PM +, Julian Foad wrote: > James McCoy wrote: > Fixed in http://svn.apache.org/r1819804 > > Please could you check it. Much better, thanks. > The working directory still needs to be within the WC for all the shelving > commands. That seems

shelve is (surprisingly) sensitive to working directory

2017-12-29 Thread James McCoy
While messing around with things recently, I decided to try out shelve to save some of my pending changes. This didn't work as well as I expected, since I wasn't in the root of my working copy. Simplified transcript below demonstrates the issue: [[[ jamessan@freya:~/src/apache.org/subversion/tru

Re: library dependency information in status output (here: lz4)

2017-12-19 Thread James McCoy
On Tue, Dec 19, 2017 at 04:46:18PM +0100, Andreas Stieger wrote: > > checking for lz4 library via pkg-config... yes > > > > and build says: > > > > subversion/libsvn_subr/compress_lz4.c:30:5: warning: "SVN_INTERNAL_LZ4" > > That is actually a side-effect of r1818662. Earlier versions of lz4 > d

Re: library dependency information in status output (here: lz4)

2017-12-19 Thread James McCoy
On Tue, Dec 19, 2017 at 04:46:18PM +0100, Andreas Stieger wrote: > > checking for lz4 library via pkg-config... yes > > > > and build says: > > > > subversion/libsvn_subr/compress_lz4.c:30:5: warning: "SVN_INTERNAL_LZ4" > > That is actually a side-effect of r1818662. Earlier versions of lz4 > d

Re: library dependency information in status output (here: lz4)

2017-12-19 Thread James McCoy
On Tue, Dec 19, 2017 at 01:53:48PM +0100, Andreas Stieger wrote: > should we continue to add all linked dependencies (here: lz4) to the verbose > version output, as the attached patch would do? I don't see why not. +1 from me. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6

Re: Reviewing 1.10 APIs & compatibility

2017-12-05 Thread James McCoy
On Dec 5, 2017 10:27, "Julian Foad" wrote: One task in the 1.10 release process is reviewing API changes. One way, that I use myself, is to take a library at a time and compare the 1.9 and 1.10 public headers, looking for procedural errors (e.g. how new and deprecated APIs are marked up, undocum

Re: svn commit: r1811786 - /subversion/trunk/subversion/bindings/swig/include/svn_types.swg

2017-10-24 Thread James McCoy
On Mon, Oct 23, 2017 at 12:28:01PM +0200, Bert Huijben wrote: > > -Original Message- > > From: james...@apache.org [mailto:james...@apache.org] > > Sent: woensdag 11 oktober 2017 05:08 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1811786 - > > /subversion/trunk/subversion

Re: Python 3 Bindings Query

2017-10-16 Thread James McCoy
On Mon, Oct 16, 2017 at 08:36:51PM +, Daniel Shahaf wrote: > Troy Curtis Jr wrote on Mon, 16 Oct 2017 01:00 +: > > through Fedora's Python 3 porting status list [1] I saw the familiar > > Subversion project showed as not yet supporting Python 3. So I was > > wondering if you are interested

Re: How to manage PR's (was: [GitHub] subversion pull request #6: VC should be 14.1 and not 15.0)

2017-10-10 Thread James McCoy
On Wed, Oct 11, 2017 at 12:51:34AM +, Daniel Shahaf wrote: > Stefan Sperling wrote on Tue, 10 Oct 2017 23:44 +0200: > > Couldn't some automated process mail PRs from github as (--git) diffs to > > dev@? > > Moreover, if the submitter's commits have a valid email address on them > (and the dom

Re: svn commit: r1803143 - in /subversion/trunk/subversion: include/ libsvn_delta/ libsvn_ra_serf/ mod_dav_svn/

2017-09-02 Thread James McCoy
On Sat, Sep 02, 2017 at 08:18:00AM +, Daniel Shahaf wrote: > [replying to multiple] > > James McCoy wrote on Fri, Sep 01, 2017 at 08:15:05 -0400: > > On Fri, Sep 01, 2017 at 03:07:16AM +, Daniel Shahaf wrote: > > > I'm not sure I'm getting through he

Re: svn commit: r1803143 - in /subversion/trunk/subversion: include/ libsvn_delta/ libsvn_ra_serf/ mod_dav_svn/

2017-09-01 Thread James McCoy
On Fri, Sep 01, 2017 at 03:07:16AM +, Daniel Shahaf wrote: > Evgeny Kotkov wrote on Thu, 31 Aug 2017 19:05 +0300: > > Daniel Shahaf writes: > > > Is adding this function an ABI-compatible change? The docstring of > > > svn_delta_editor_t does say """ > > > > > > * @note Don't try to allocate

Re: errorcode.inc in tarballs

2017-08-10 Thread James McCoy
On Aug 10, 2017 15:29, "Philip Martin" wrote: Branko Čibej writes: > Would be better to generate this header at build time ... but to do that > in a cross-platform manner, we'd have to write a C program to do that. Even that is hard, I know of no easy way for C code to convert an error number

Re: svn commit: r1803722 - /subversion/branches/1.9.x/STATUS

2017-08-02 Thread James McCoy
On Wed, Aug 02, 2017 at 02:07:20PM +, Daniel Shahaf wrote: > james...@apache.org wrote on Wed, Aug 02, 2017 at 01:35:31 -: > > * r1802032 > > Install 'fsfs-stats' as a wrapper to 'svnfsfs', to which it was renamed > > in > > r1618848. > > Justification: > > Backwards co

Re: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS

2017-05-13 Thread James McCoy
On Wed, May 10, 2017 at 08:34:59AM -0400, James McCoy wrote: > On Tue, May 09, 2017 at 09:36:18AM -0400, Mark Phippard wrote: > > I would expect a feature like this to at least require some kind of opt-in > > mechanism.  In this case, it should require some setting in config t

Re: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS

2017-05-10 Thread James McCoy
On Tue, May 09, 2017 at 09:36:18AM -0400, Mark Phippard wrote: > On Tue, May 9, 2017 at 8:02 AM, James McCoy wrote: > > > Subversion is a library and we should be very careful about this. I > think > this code is by default left out on Windows, but there are tons of

Re: svn commit: r1794433 - /subversion/branches/1.9.x/STATUS

2017-05-09 Thread James McCoy
On Tue, May 09, 2017 at 01:00:00PM +0200, Bert Huijben wrote: > > -Original Message- > > From: Stefan Sperling [mailto:s...@elego.de] > > Sent: dinsdag 9 mei 2017 11:26 > > To: Bert Huijben > > Cc: dev@subversion.apache.org > > Subject: Re: svn commit: r1794433 - /subversion/branches/1.9.x

Re: [PATCH] gpg-agent storage - add support for /run based sockets V4

2017-05-06 Thread James McCoy
On Fri, May 05, 2017 at 11:29:09PM -0400, James McCoy wrote: > On Fri, May 05, 2017 at 09:41:03AM +0200, Lukas Jirkovsky wrote: > > On 4 May 2017 at 23:54, Lukas Jirkovsky wrote: > > > Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent > > &

Re: [PATCH] gpg-agent storage - add support for /run based sockets V4

2017-05-05 Thread James McCoy
On Fri, May 05, 2017 at 09:41:03AM +0200, Lukas Jirkovsky wrote: > On 4 May 2017 at 23:54, Lukas Jirkovsky wrote: > > Updated patch. It parses "gpgconf --list-dir" output to find gpg-agent > > socket. > > I just noticed I accidentally generated the patch from inside the > "subversion" subdirecto

Re: [PATCH] gpg-agent storage - add support for /run based sockets V2

2017-05-03 Thread James McCoy
On Wed, May 03, 2017 at 11:03:42PM +0200, Lukas Jirkovsky wrote: > On 3 May 2017 at 22:35, Stefan Sperling wrote: > > On Wed, May 03, 2017 at 10:05:01PM +0200, Lukas Jirkovsky wrote: > >> New version. Instead of reimplementing the gpg-agent logic, "gpgconf > >> --list-dir agent-socket" is used. If

Re: [PATCH] gpg-agent storage - add support for /run based sockets

2017-04-30 Thread James McCoy
On Fri, Apr 28, 2017 at 05:46:21PM +0200, Lukas Jirkovsky wrote: > Add support for sockets in /run used by recent gpg-agent Thanks for the patch! Aside from a few comments on the code, I wonder if it would be better to use "gpgconf --list-dir agent-socket" instead of reimplementing the various bi

Re: svn commit: r1764447 - in /subversion/trunk/subversion: libsvn_client/conflicts.c tests/libsvn_client/conflicts-test.c

2016-10-23 Thread James McCoy
On Wed, Oct 12, 2016 at 12:34:19PM -, s...@apache.org wrote: > Author: stsp > Date: Wed Oct 12 12:34:18 2016 > New Revision: 1764447 > > URL: http://svn.apache.org/viewvc?rev=1764447&view=rev > Log: > Don't flag an unnecessary tree conflict while resolving 'add vs add'. > > * subversion/libsv

Re: [PATCH] Fix modification of nil value in Ruby test suite

2016-10-22 Thread James McCoy
On Tue, Nov 17, 2015 at 08:51:31AM -0500, James McCoy wrote: > On Nov 17, 2015 8:40 AM, "Philip Martin" wrote: > > > > James McCoy writes: > > > > > --- a/subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c > > > +++ b/subversion/

Re: [PATCH] Conflict option labels

2016-10-12 Thread James McCoy
On Wed, Oct 12, 2016 at 04:44:10PM +0200, Ivan Zhakov wrote: > On 12 October 2016 at 15:38, Patrick Steinhardt > wrote: > > Hi, > > > > please find attached a patch pulling out the short descriptions > > of conflict resolution options from the client and puts them into > > libsvn_client. > > > > [

Re: ABI changes analysis

2016-06-26 Thread James McCoy
On Sun, Jun 26, 2016 at 09:26:27PM +0200, Stefan wrote: > I'm just wondering why the backward compatibility for 1.9.0 (and 1.8.0) > doesn't state 100% here [1]. > > Checking out the details on 1.9.0 [2] and there the details on > libsvn_subr [3] suggests 3 functions were removed: > - svn__apr_hash

Re: svn commit: r1743550 - in /subversion/trunk: build/ contrib/server-side/ tools/client-side/ tools/dev/benchmarks/RepoPerf/ tools/dev/benchmarks/suite1/ tools/dist/

2016-05-12 Thread James McCoy
print_function”. Just because something looks the same visually doesn't mean it's the same syntax. Actually importing the same syntax avoids simple mistakes like this. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: svn commit: r1741742 - in /subversion/trunk: contrib/client-side/svn-merge-vendor.py contrib/server-side/fsfsverify.py tools/server-side/svn-backup-dumps.py

2016-04-30 Thread James McCoy
s.stderr.write("Please specify exactly one rev file.\n") For example, this would change to: [[[ from __future__ import print_function print('Please specify exactly one rev file.', file=sys.stderr) ]]] This also maintains the behavior of an automatic newline. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: [PATCH/RFC] use-sasl=true in --without-sasl builds: make that a fatal error?

2016-04-29 Thread James McCoy
ble to me. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: 1.9.4 up for signing/testing

2016-04-27 Thread James McCoy
tu's) packaging. I've been meaning to talk to some Ruby folks to answer Philip's questions. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: [PATCH] Trivial relnotes typo fix

2016-03-13 Thread James McCoy
On Mon, Mar 14, 2016 at 01:08:28AM +, Daniel Shahaf wrote: > Is someone able to commit this for me, please? Done in r1734874. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: svn commit: r1731656 - /subversion/trunk/subversion/svnserve/serve.c

2016-02-22 Thread James McCoy
On Feb 22, 2016 10:10 AM, wrote: > > Author: stefan2 > Date: Mon Feb 22 15:06:40 2016 > New Revision: 1731656 > > URL: http://svn.apache.org/viewvc?rev=1731656&view=rev > Log: > Switch svnserve to using the streamy log API. > --- subversion/trunk/subversion/svnserve/serve.c (original) > +++ subve

Re: SVN::Client::log() first argument Re: svn commit: r1729519 - /subversion/trunk/tools/client-side/svn-graph.pl

2016-02-15 Thread James McCoy
On Mon, Feb 15, 2016 at 11:54:39AM +0100, Bert Huijben wrote: > > -Original Message- > > From: James McCoy [mailto:vega.ja...@gmail.com] On Behalf Of James > > McCoy > > Sent: zondag 14 februari 2016 19:20 > > To: Daniel Shahaf > > Cc: dev@subver

Re: SVN::Client::log() first argument Re: svn commit: r1729519 - /subversion/trunk/tools/client-side/svn-graph.pl

2016-02-14 Thread James McCoy
be a single $target (as defined above) or a reference to an array of them. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: svn commit: r1727824 - /subversion/trunk/subversion/libsvn_fs/fs-loader.c

2016-01-31 Thread James McCoy
one either when Enumate -> Emulate Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: svn commit: r1723003 - /subversion/branches/1.9.x/STATUS

2016-01-05 Thread James McCoy
another addition and/or a backport branch. Yeah, I noticed the backport-conflicts failure. danielsh made some changes in trunk to fail if --with-swig is given but swig isn't found, which haven't been backported. I'll revisit that tonight. Cheers, -- James GPG Key: 4096R/331BA3DB 2011-12-05 James McCoy

Re: Swig 3.x support (was Re: svn commit: r1690591 - /subversion/trunk/subversion/bindings/swig/include/proxy.swg)

2015-12-22 Thread James McCoy
On Tue, Dec 22, 2015 at 02:45:03PM +0100, Branko Čibej wrote: > On 22.12.2015 04:26, James McCoy wrote: > > On Sun, Nov 01, 2015 at 01:17:56AM -0500, James McCoy wrote: > >> On Mon, Jul 13, 2015 at 11:00:17AM +0100, Joe Orton wrote: > >>> On Mon, Jul 13, 2015 at

  1   2   >