On Wed, Nov 24, 2010 at 3:43 AM, Gavin Beau Baumanis
wrote:
> Hi Daniel (T),
>
> Since in your earlier post you mentioned that you didn't mind a friendly
> reminder...
>
> I thought I would return this thread to the top of the list - Just i case
> you had missed Daniel (Shahaf) 's comments.
>
>
> The only difference between translate_newline() and translate_newline_alt()
> is the lines of code from here to the end of the function. I think you
> could keep translate_newline() as is, and just move these checks elsewhere
> (to a new function or to the caller; I haven't thought about this in
Hi Daniel,
Thank you for your feedback. I have attached a new patch and log
message that addresses the points that you have mentioned.
> If we can provide the information cheaply, I see no reason not to let
> the APIs provide it. As some of these APIs are already revved for 1.7,
> we might as w
On Sun, Nov 7, 2010 at 12:04 PM, Daniel Trebbien wrote:
> Weird. It seems that `subversion/libsvn_repos/load-fs-vtable.c` was
> the only C file in `subversion/libsvn_repos` that wasn't being
> compiled. So, I modified the CC line that compiled
> `subversion/libsvn_repos/log.c` t
Weird. It seems that `subversion/libsvn_repos/load-fs-vtable.c` was
the only C file in `subversion/libsvn_repos` that wasn't being
compiled. So, I modified the CC line that compiled
`subversion/libsvn_repos/log.c` to instead compile
`subversion/libsvn_repos/load-fs-vtable.c` and manually added
`loa
On Sun, Nov 7, 2010 at 8:01 AM, Stefan Sperling wrote:
> On Sun, Nov 07, 2010 at 07:56:51AM -0800, Daniel Trebbien wrote:
>> I am having trouble building trunk. The make process always fails when
>> linking libsvn_repos-1:
>
> Looks like the linker or libtool is picking up co
I am having trouble building trunk. The make process always fails when
linking libsvn_repos-1:
cd subversion/libsvn_repos && /usr/share/apr-1.0/build/libtool
--tag=CC --silent --mode=link gcc -Wno-system-headers
-Wold-style-definition -Wdeclaration-after-statement -Wpointer-arith
-Wwrite-strings
On Mon, Oct 18, 2010 at 3:05 AM, Gavin Beau Baumanis
wrote:
> Hi Daniel,
>
> This is just a friendly poke.
> Are you happy to have me "annoy" you every so often - or would just like me
> leave it entirely with you ?
>
>
> Gavin "Beau" Baumanis
Hi Gavin,
I don't mind at all. Regarding this svnsy
Hi Julian,
Thank you for your note. Feel free to take all the time that you need.
On Thu, Oct 7, 2010 at 7:09 AM, Julian Foad wrote:
> Daniel, sorry I haven't looked at this yet, and won't be able to today.
>
> - Julian
On Fri, Oct 1, 2010 at 3:57 AM, Julian Foad wrote:
>> Adds a public API function, svn_subst_translate_string2(), an extension of
>> svn_subst_translate_string(), that has two, additional output parameters for
>> determining whether re-encoding and/or line ending translation were
>> performed.
>
>
On Fri, Oct 1, 2010 at 4:14 AM, Bert Huijben wrote:
>> > @@ -650,7 +651,13 @@ translate_newline(const char *eol_str,
>> > *src_format_len = newline_len;
>> > }
>> > /* Translate the newline */
>> > - return translate_write(dst, eol_str, eol_str_len);
>> > + svn_error_t *err = tran
Following Daniel Shahaf's suggestion of splitting the "allow svnsync
to translate non-UTF-8 log messages to UTF-8" work into two patches, I
have revised my changes, prepared one of the two patches, and have
attached the one patch and suggested log message to this e-mail.
Adds a public API function,
> Hi Daniel (Trebbien),
>
> Just thought I would ask for an update, please.
> I still have you on my "watch - list" - so there is no rush - just making
> sure for my own sanity that I haven't missed an email / thread about your
> patch submission.
>
>
> Gavin "Beau" Baumanis
Daniel Trebbien gmail.com> writes:
> Yes, I did copy-and-paste. I see your point, though, and I am going to
> correct this by adding another `static` function that both will call.
Never mind the talk of a new static function. `svn_subst_translate_string`
should
of co
Daniel Shahaf daniel.shahaf.name> writes:
>
> Gavin, thanks for the information, but I think Daniel Trebbien already
> knows this.
>
> Gavin Beau Baumanis wrote on Sun, Sep 19, 2010 at 08:52:05 +1000:
> > Hi Daniel,
> >
> > You should always feel comfo
On Sun, Sep 19, 2010 at 9:39 PM, Daniel Shahaf wrote:
>> * subversion/include/svn_subst.h
>> Added documentation of the new public API function
>> svn_subst_translate_string2().
>>
>
> Should use this syntax:
>
> * subversion/include/svn_subst.h
> (svn_subst_translate_string2): New function.
It has been a few days since I submitted my revised patch
(http://thread.gmane.org/gmane.comp.version-control.subversion.devel/122550),
and I just want to make sure that it hasn't been forgotten. I am waiting for
the changes to be committed before I work on related enhancements.
Hyrum K. Wright mail.utexas.edu> writes:
> Thanks. Though I'll probably wait a day or two, to let any dissenters
> make themselves known. :)
-1/2. There are parts of your idea that I like, such as linking to "common
documentation", enumerating all of the errors that can be returned, and
specifyi
Looking through the source code for `svn_subst_translate_string` in
`subversion/libsvn_subr/subst.c`, it seems odd to me that the `repair`
parameter to the call to `svn_subst_translate_cstring2` (for
translating the line endings) is `FALSE`. `FALSE` means that if the
line endings are inconsistent,
On Sun, Sep 12, 2010 at 1:49 PM, Daniel Shahaf wrote:
>> When I was working on my changes, I was looking for a "to UTF-8"
>> function that would return whether it actually re-encoded the input
>> string, but did not find one. The re-encoding function that I used,
>> `svn_subst_translate_string`, a
>> * subversion/svnsync/main.c
>> (svnsync_cmd_table): Added svnsync_opt_source_encoding to the list
>> of acceptable options for the init, sync, and copy-revprops
>> subcommands.
>
> Missing indentation on the non-first lines. Should be in one of these forms:
>
> [[[
> * subversion/svnsync/main
Note: I was using the GNU Nano repository (svn://svn.sv.gnu.org/nano)
to test my changes, but it's not ideal because the first commit where
the --source-encoding feature is needed is revision 619. Also, as of
now, 29 of the 4518 commits have non-ASCII log messages with 21
encoded in ISO-8859-1 and
On Fri, Sep 10, 2010 at 9:16 AM, Daniel Shahaf wrote:
> The patch didn't make it to the list (only to my personal copy), could
> you please re-send with the patch in "text/plain" MIME type?
Hmmm. I wonder if adding a .txt extension will work...
Index: subversion/svnsync/sync.h
===
[[[
Add a command line option to the svnsync init, sync, and copy-revprops
subcommands (--source-encoding) that allows the user to specify the
character encoding of translatable properties from the source
repository. This is needed to allow svnsync to import some older
Subversion repositories that
;
> (more below)
>
> Daniel Trebbien wrote on Wed, Sep 08, 2010 at 18:58:06 -0700:
>> On Wed, Sep 8, 2010 at 4:39 PM, Daniel Trebbien wrote:
>> > I think that a call to `svn_subst_translate_string`
>> > (http://svn.collab.net/svn-doxygen/svn__
25 matches
Mail list logo
