Re: svn commit: r1925902 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

On Wed, May 28, 2025 at 4:02 PM Branko Čibej wrote: > On 28. 5. 25 14:31, rin...@apache.org wrote: > > Author: rinrab > Date: Wed May 28 12:31:55 2025 > New Revision: 1925902 > > URL: http://svn.apache.org/viewvc?rev=1925902&view=rev > Log: > On the 'utf8-cmdline-prototype' branch: avoid double c

Re: svn commit: r1925902 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

On 28. 5. 25 14:31, rin...@apache.org wrote: Author: rinrab Date: Wed May 28 12:31:55 2025 New Revision: 1925902 URL:http://svn.apache.org/viewvc?rev=1925902&view=rev Log: On the 'utf8-cmdline-prototype' branch: avoid double coping of arguments after encoding conversion. This is a follow-up to

Re: CMake, FindAPR and FindAPRUtil

On 28. 5. 25 14:35, Daniel Sahlberg wrote: Den ons 28 maj 2025 kl 14:29 skrev Timofei Zhakov : ... So, it would be great if serf starts using svn's modules. I can try to support pkgconfig in them if needed. Thoughts? Outside of my area of expertise but doesn't this concern the bui

Re: CMake, FindAPR and FindAPRUtil

On 28. 5. 25 14:27, Timofei Zhakov wrote: On Wed, May 28, 2025 at 2:14 PM Branko Čibej wrote: So I was fiddling with Serf's CMake build recently, and just now I noticed (again) that Serf has FindAPR.cmake and FindAPRUtil.cmake as well, and they're almost entirely completely differen

Re: CMake, FindAPR and FindAPRUtil

Den ons 28 maj 2025 kl 14:29 skrev Timofei Zhakov : ... > So, it would be great if serf starts using svn's modules. I can try to > support pkgconfig in them if needed. > > Thoughts? > Outside of my area of expertise but doesn't this concern the build system in Serf? In that case I think we are on

Re: CMake, FindAPR and FindAPRUtil

On Wed, May 28, 2025 at 2:14 PM Branko Čibej wrote: > So I was fiddling with Serf's CMake build recently, and just now I noticed > (again) that Serf has FindAPR.cmake and FindAPRUtil.cmake as well, and > they're almost entirely completely different from Subversion's. Not only > completely differe

CMake, FindAPR and FindAPRUtil

So I was fiddling with Serf's CMake build recently, and just now I noticed (again) that Serf has FindAPR.cmake and FindAPRUtil.cmake as well, and they're almost entirely completely different from Subversion's. Not only completely different but far more complete, IMO. I'd like to merge the two

Re: libsvn_cmdline

On Wed, May 28, 2025 at 10:32 AM Branko Čibej wrote: > On 28. 5. 25 00:11, Timofei Zhakov wrote: > > See? SEE!!?? I *told* you it was a mess. :D >> >> This stuff should all be in libsvn_subr/cmdline.c. I don't even remember >> any more how this happened. I think that at one point I was even >> co

Re: svn commit: r1925827 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

On 28. 5. 25 13:56, Timofei Zhakov wrote: You changed that opt_state.encoding to be in UTF-8 (a change that, by the way, I'm not sure about. That value is a parameter for the xlate functions, which may require the original native-encoded name). Yup. I think I clarified this in the

Re: svn commit: r1925827 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

> > [...] > That svn_utf_cstring_to_utf8(&utf8_opt_arg, opt_arg, pool) at the top of > the loop guaranees that utf8_opt_arg is in the pool. In all the case I > pointed out, that string was copied into the same pool again. Before you > change, that actually happened immediately after the conversion.

Re: svn commit: r1925827 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

On 28. 5. 25 13:28, Timofei Zhakov wrote: On Wed, May 28, 2025 at 12:51 PM Branko Čibej wrote: On 26. 5. 25 16:58, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 14:58:30 2025 New Revision: 1925827 URL:http://svn.apache.org/viewvc?rev=1925827&view=rev

Re: svn commit: r1925841 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

> > > I like the special-casing of the error for lock comment vs. log message, > but such changes that are unrelated to what you're doing on the branch > should really be done on trunk, it makes the merge review a little easier > later on. > > I fully agree, but I'd prefer to first try this in the

Re: svn commit: r1925827 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

On Wed, May 28, 2025 at 12:51 PM Branko Čibej wrote: > On 26. 5. 25 16:58, rin...@apache.org wrote: > > Author: rinrab > Date: Mon May 26 14:58:30 2025 > New Revision: 1925827 > > URL: http://svn.apache.org/viewvc?rev=1925827&view=rev > Log: > On the 'utf8-cmdline-prototype' branch: convert opt_a

Re: svn commit: r1925841 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

On 26. 5. 25 21:55, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 19:55:30 2025 New Revision: 1925841 URL:http://svn.apache.org/viewvc?rev=1925841&view=rev Log: On the 'utf8-cmdline-prototype' branch: follow-up to r1925834: prevent 'log message is pathname' warning from showing when t

Re: svn commit: r1925834 - in /subversion/branches/utf8-cmdline-prototype/subversion/svn: cl.h svn.c util.c

On 26. 5. 25 19:24, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 17:24:16 2025 New Revision: 1925834 URL:http://svn.apache.org/viewvc?rev=1925834&view=rev Log: On the 'utf8-cmdline-prototype' branch: Store utf8-ized message in opt_state. The reason this is stored unchanged is so t

Re: svn commit: r1925827 - /subversion/branches/utf8-cmdline-prototype/subversion/svn/svn.c

On 26. 5. 25 16:58, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 14:58:30 2025 New Revision: 1925827 URL:http://svn.apache.org/viewvc?rev=1925827&view=rev Log: On the 'utf8-cmdline-prototype' branch: convert opt_arg to utf8 once in the beginning of argument handling loop instead of d

Re: svn commit: r1925899 - in /subversion/trunk: CMakeLists.txt build/run_tests.py subversion/tests/cmdline/prop_tests.py subversion/tests/cmdline/svntest/main.py subversion/tests/cmdline/svntest/veri

On 28. 5. 25 11:36, br...@apache.org wrote: Author: brane Date: Wed May 28 09:36:46 2025 New Revision: 1925899 URL:http://svn.apache.org/viewvc?rev=1925899&view=rev Log: Improve the XML validation support in the test suite by making it optional and adding some tooling for different ways to insta

Re: svn commit: r1925822 - /subversion/trunk/CMakeLists.txt

On 26. 5. 25 15:38, rin...@apache.org wrote: Author: rinrab Date: Mon May 26 13:38:39 2025 New Revision: 1925822 URL:http://svn.apache.org/viewvc?rev=1925822&view=rev Log: cmake: Add SVN_TEST_COMMAND_ARGUMENTS option that can configure additional command line arguments to pass to our test-suite.

Re: libsvn_cmdline

On 28. 5. 25 00:11, Timofei Zhakov wrote: See? SEE!!?? I *told* you it was a mess. :D This stuff should all be in libsvn_subr/cmdline.c. I don't even remember any more how this happened. I think that at one point I was even considering creating a new library that would contain