Hi,
Originally an issue reported to TortoiseSVN and discussed on StackOverflow,
a user added this to JIRA: https://issues.apache.org/jira/browse/SVN-4868
I'm attaching a test for reviewing.
I have a patch in temp_file_create in libsvn_subr/io.c which seems to be
working on Linux but it doesn't h
On 26 Jan 2021, Daniel Shahaf wrote:
>+1 to using sys.executable. Fixing the quoting while in there would be
>nice to have, but as it's not a regression it's not a blocker either.
>Happy to leave the details to you.
Well, things turn out to be a bit more complicated than I thought.
My original p
>I'm running the tests right now. If it passes the test suite, and you
>don't see any obvious further to the patch, I'll commit. Thanks again
"obvious further improvements", I meant to say.
-K
Okay, revised patch for review.
I'm running the tests right now. If it passes the test suite, and you
don't see any obvious further to the patch, I'll commit. Thanks again
for your help, Daniel!
Best regards,
-Karl
[[[
Distinguish between regular properties and revprops in tmpfile name.
* sub
On Tue, Jan 26, 2021 at 01:47:23AM -0600, Karl Fogel wrote:
> On recent versions of Debian GNU/Linux, the 'python' command doesn't
> normally exist. Instead, there are separate 'python3' and 'python2'
> commands.
>
> As a result, four tests fail in the Subversion test suite as of
> r1885910, all
On Tue, Jan 26, 2021 at 9:56 PM Johan Corveleyn wrote:
>
> On Tue, Jan 26, 2021 at 7:43 PM Alexandr Miloslavskiy
> wrote:
> >
> > On 25.01.2021 1:55, Johan Corveleyn wrote:
> >
> > > As an update: I've started looking into this, but it's a bit more work
> > > than I anticipated. I want to underst
On 26 Jan 2021, Daniel Shahaf wrote:
>Karl Fogel wrote on Tue, Jan 26, 2021 at 16:11:31 -0600:
>> This change is useful because many editors display the file's basename during
>> editing (e.g., in a status line somewhere near the bottom of the screen). So
>> if you get interrupted while editing a
On Tue, Jan 26, 2021 at 11:57:50PM +0100, Johan Corveleyn wrote:
> Yes, I agree we should stick to our established policy here.
>
> We recently loosened our backport-voting policy a bit for non-LTS
> (Regular) releases, but we didn't for LTS releases (no time to dig up
> the thread, but ISTR we di
Nathan Hartman wrote on Sun, Jan 24, 2021 at 12:19:57 -0500:
> $ make check TESTS=subversion/tests/cmdline/info_tests.py#21
This syntax — the «#foo» part, I mean — doesn't seem to be documented.
Nor is the ability to specify multiple files in there
(«TESTS="path/to/foo_tests.py path/to/bar_tests
On Tue, Jan 26, 2021 at 11:47 PM Stefan Sperling wrote:
>
> On Tue, Jan 26, 2021 at 04:45:32PM -0500, Nathan Hartman wrote:
> > On Tue, Jan 26, 2021 at 4:28 PM Daniel Shahaf
> > wrote:
> >
> > > Stefan Sperling wrote on Fri, Jan 22, 2021 at 14:36:56 +0100:
> > > > [...] I will allow myself to mer
On Tue, Jan 26, 2021 at 04:45:32PM -0500, Nathan Hartman wrote:
> On Tue, Jan 26, 2021 at 4:28 PM Daniel Shahaf
> wrote:
>
> > Stefan Sperling wrote on Fri, Jan 22, 2021 at 14:36:56 +0100:
> > > [...] I will allow myself to merge any nominations which received at
> > least
> > > two +1 votes and
Karl Fogel wrote on Tue, Jan 26, 2021 at 16:11:31 -0600:
> This small patch makes it so that when you do 'svn propedit --revprop', the
> tmpfile's name is "svn-revprop-rN.tmp" (where N is the number of the revision
> whose revprop is being edited).
>
> For regular properties, nothing has changed:
On 26 Jan 2021, Daniel Shahaf wrote:
>Yay! *gestures* Here's your old chair, right where you left it; I think you'll
>find the only difference from when you last occupied it is that your DHCP lease
>may have expired ;-)
:laugh+cry emoji::)
>AFAICT:
>
>1. SVN_TEST_PYTHON is only used by the
> From: Karl Fogel
> Subject: [PATCH] Fix tests failing on Debian due to lack of 'python' command.
Yay! *gestures* Here's your old chair, right where you left it; I think you'll
find the only difference from when you last occupied it is that your DHCP lease
may have expired ;-)
> But in practice
This small patch makes it so that when you do 'svn propedit --revprop', the
tmpfile's name is "svn-revprop-rN.tmp" (where N is the number of the revision
whose revprop is being edited).
For regular properties, nothing has changed: the tmpfile name is still just
"svn-prop.tmp".
This change is u
Yasuhito FUTATSUKI wrote on Sat, Jan 23, 2021 at 01:57:07 +0900:
> Parhaps it is a missed one, that should be fixed :)
>
> With this patch, even if environment variable PYTHON pointed to Python 2,
> the configure script searches Python 3 at first. I'm irresolute that
> it is what it should be or n
On Tue, Jan 26, 2021 at 4:28 PM Daniel Shahaf
wrote:
> Stefan Sperling wrote on Fri, Jan 22, 2021 at 14:36:56 +0100:
> > [...] I will allow myself to merge any nominations which received at
> least
> > two +1 votes and no vetoes.
>
> HACKING [1] states:
>
> "For an LTS release line, a change is a
Stefan Sperling wrote on Fri, Jan 22, 2021 at 14:36:56 +0100:
> [...] I will allow myself to merge any nominations which received at least
> two +1 votes and no vetoes.
HACKING [1] states:
"For an LTS release line, a change is approved if it receives three +1s and no
vetoes. (Only binding votes c
Apologies for the late answer.
Eric S. Raymond wrote on Thu, Jan 21, 2021 at 23:34:24 -0500:
> Daniel Shahaf :
> > > > It makes me twitchy that there's any possible future in which that
> > > > format might be unsuppoted or inaccessible.
> >
> > We _are_ committed to providing an upgrade path fro
On Tue, Jan 26, 2021 at 7:43 PM Alexandr Miloslavskiy
wrote:
>
> On 25.01.2021 1:55, Johan Corveleyn wrote:
>
> > As an update: I've started looking into this, but it's a bit more work
> > than I anticipated. I want to understand and properly review the
> > changes.
>
> Thanks! I already started t
On 25.01.2021 1:55, Johan Corveleyn wrote:
As an update: I've started looking into this, but it's a bit more work
than I anticipated. I want to understand and properly review the
changes.
Thanks! I already started thinking that all hope is lost :)
The branch contains additional tests (added o
On 26 Jan 2021, M. Buecher wrote:
>On 2021-01-26 08:47, Karl Fogel wrote:
>> On recent versions of Debian GNU/Linux, the 'python' command doesn't
>> normally exist. Instead, there are separate 'python3' and 'python2'
>> commands.
>
>Side note:
>There are additional packages to set either python2 o
On 2021-01-26 08:47, Karl Fogel wrote:
On recent versions of Debian GNU/Linux, the 'python' command doesn't
normally exist. Instead, there are separate 'python3' and 'python2'
commands.
Side note:
There are additional packages to set either python2 or python3 as the
"default" Python.
This cha
23 matches
Mail list logo
