Re: Blame callback: remove start/end parameters

2019-01-14 Thread Johan Corveleyn
On Mon, Jan 14, 2019 at 4:13 PM Julian Foad wrote: > > Julian Foad wrote: > > The svn_client_blame_receiver4_t parameters "start_revnum" and > > "end_revnum" do not really belong here because they are not per-line > > data. They are the "resolved" versions of the input revnums to > > svn_client_bl

Re: extending the blame callback

2019-01-14 Thread Stefan Kueng
On 14.01.2019 14:25, Branko Čibej wrote: On 14.01.2019 13:36, Julian Foad wrote: Stefan, thanks for taking account of the feedback and updating the doc string in r1851197. I took a look and thought to rewrite the part about encoding and line splitting like this: * Character Encoding and

Unshelving through the new WC editor API

2019-01-14 Thread Julian Foad
I'm starting to re-implement "unshelve" using the new WC editor API. Here's what "unshelve" looks like now: for each node-change found by shelf_status_walk(shelf-storage): if it's "delete": call svn_wc_delete4(path,...) if it's "modify": wc_file_merge(path,...) etc. What I'll want to do no

Re: Blame callback: remove start/end parameters

2019-01-14 Thread Julian Foad
Julian Foad wrote: > The svn_client_blame_receiver4_t parameters "start_revnum" and > "end_revnum" do not really belong here because they are not per-line > data. They are the "resolved" versions of the input revnums to > svn_client_blame6(). I introduced them in r955895, applying a patch by >

Re: extending the blame callback

2019-01-14 Thread Branko Čibej
On 14.01.2019 15:37, Julian Foad wrote: > Branko Čibej wrote: >> On 14.01.2019 13:36, Julian Foad wrote: > [...] > > Thanks, Brane; you gave a good initial summary of the scope of the problem. > As you said on IRC there's even more to it, such as the relationship between > line splitting and keyw

Re: extending the blame callback

2019-01-14 Thread Julian Foad
Branko Čibej wrote: > On 14.01.2019 13:36, Julian Foad wrote: [...] Thanks, Brane; you gave a good initial summary of the scope of the problem. As you said on IRC there's even more to it, such as the relationship between line splitting and keywords, meaning that all has to be addressed together.

Re: svn commit: r1851244 - /subversion/trunk/subversion/include/svn_client.h

2019-01-14 Thread Branko Čibej
On 14.01.2019 14:10, julianf...@apache.org wrote: > Author: julianfoad > Date: Mon Jan 14 13:10:45 2019 > New Revision: 1851244 > > URL: http://svn.apache.org/viewvc?rev=1851244&view=rev > Log: > * subversion/include/svn_client.h > (svn_client_blame_receiver4_t): Improve doc string. > > Modified:

Re: extending the blame callback

2019-01-14 Thread Branko Čibej
On 14.01.2019 13:36, Julian Foad wrote: > Stefan, thanks for taking account of the feedback and updating the doc string > in r1851197. > > I took a look and thought to rewrite the part about encoding and line > splitting like this: > > * Character Encoding and Line Splitting: > * > * It is up

Blame callback: remove start/end parameters

2019-01-14 Thread Julian Foad
The svn_client_blame_receiver4_t parameters "start_revnum" and "end_revnum" do not really belong here because they are not per-line data. They are the "resolved" versions of the input revnums to svn_client_blame6(). I introduced them in r955895, applying a patch by Johan. I propose to move them

Re: extending the blame callback

2019-01-14 Thread Julian Foad
Stefan, thanks for taking account of the feedback and updating the doc string in r1851197. I took a look and thought to rewrite the part about encoding and line splitting like this: * Character Encoding and Line Splitting: * * It is up to the client to determine the character encoding. The @

Re: Spack - package manager for Linux+Mac

2019-01-14 Thread Paul Hammant
In praise of that community, they appear to be "on it" with respect to problem reports - https://github.com/spack/spack/pull/10335 being an example that coming from an issue I'd had with their Python as I ran through the 1.9.7 install of Subversion with it. That after them quickly solving an issue

Re: Spack - package manager for Linux+Mac

2019-01-14 Thread Julian Foad
Paul Hammant wrote: > Spack currently has 1.9.7 as the most recent Svn that it can deliver: > > https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/subversion/package.py > > Someone may be interested in dipping their toe into that world and > updating their script for the

Re: [PATCH]On branch swig-py3: accept both of bytes/str for inputchar * args

2019-01-14 Thread Yasuhito FUTATSUKI
On 1/14/19 3:10 PM, Yasuhito FUTATSUKI wrote: In article troycurti...@gmail.com writes: On Thu, Jan 10, 2019 at 9:50 AM Yasuhito FUTATSUKI wrote: The patch attached modifies 4 kind of input argment translations. (1) typemap(in) char * (with/without const modifiers); not allow NULL, t