Re: svn commit: r1826720 - /subversion/trunk/subversion/libsvn_fs_fs/cached_data.c

2018-03-18 Thread Philip Martin
phi...@apache.org writes: > Author: philip > Date: Wed Mar 14 14:24:36 2018 > New Revision: 1826720 > > URL: http://svn.apache.org/viewvc?rev=1826720&view=rev > Log: > Add a checksum length verification to the FSFS checksum code. This > may have prevented the issue 4722 checksum bug by making the

Re: Testsuite options

2018-03-18 Thread Philip Martin
Philip Martin writes: > The testsuite already has support for testing with revprop-cache on. It > can be used with svnserveautocheck but is pointless with davautocheck as > mod_dav_svn now enables it by default. It is even more pointless than that. Looking at the code in svn_fs_fs__initialize_

Re: [PATCH] Hackathon project: Dumping viewspec

2018-03-18 Thread Philip Martin
Julian Foad writes: > I haven't looked further into this, but what I think is the core of > the problem is there's no way to generate a WC directory with its > depth set to 'infinity' but sparse inside, without checking out the > whole tree. It might be difficult to do automatically, but there i

Re: [PATCH] Hackathon project: Dumping viewspec

2018-03-18 Thread Julian Foad
Branko Čibej wrote: On 18.03.2018 13:43, Julian Foad wrote: Branko Čibej wrote: On 16.03.2018 18:33, Julian Foad wrote: Suggested exercises for the reader (you, plural):    * implement a UI to choose the output format (currently 'svn info --viewspec' is hard-coded to produce that 'format 2')

Re: svn commit: r1827100 - /subversion/branches/1.10.x/STATUS

2018-03-18 Thread Branko Čibej
On 18.03.2018 16:04, Daniel Shahaf wrote: > Branko Čibej wrote on Sat, 17 Mar 2018 20:27 +0100: >> On 17.03.2018 20:24, br...@apache.org wrote: >>> >>> + * r1825979 >>> + Minor clarification to docstring. >>> + Justification: >>> + Trivial documentation fix. >>> + Votes: >>> + +1: d

Re: svn commit: r1827100 - /subversion/branches/1.10.x/STATUS

2018-03-18 Thread Daniel Shahaf
Branko Čibej wrote on Sat, 17 Mar 2018 20:27 +0100: > On 17.03.2018 20:24, br...@apache.org wrote: > > > > + * r1825979 > > + Minor clarification to docstring. > > + Justification: > > + Trivial documentation fix. > > + Votes: > > + +1: danielsh, jamessan > > + -1: brane (the do

Re: [PATCH] Hackathon project: Dumping viewspec

2018-03-18 Thread Branko Čibej
On 18.03.2018 13:43, Julian Foad wrote: > Branko Čibej wrote: >> On 16.03.2018 18:33, Julian Foad wrote: >>> I implemented an output format compatible with 'svn-viewspec.py' in >>> r1826990. Then I updated that output format to also support 'switched' >>> and revisions, in r1826993. This version ou

Re: [PATCH] Hackathon project: Dumping viewspec

2018-03-18 Thread Julian Foad
Branko Čibej wrote: On 16.03.2018 18:33, Julian Foad wrote: I implemented an output format compatible with 'svn-viewspec.py' in r1826990. Then I updated that output format to also support 'switched' and revisions, in r1826993. This version outputs a header declaring 'Format: 2', and svn-viewspec

Testsuite options

2018-03-18 Thread Philip Martin
Branko Čibej writes: > As long as we have tuning options, we should test them. It's not that > hard to add buildslave configurations. > > As for eliminating them: it would be nice if the server could auto-tune > these parameters, but that is probably not a worthwhile goal to spend > our efforts a