Philip Martin <phi...@codematters.co.uk> writes: > The testsuite already has support for testing with revprop-cache on. It > can be used with svnserveautocheck but is pointless with davautocheck as > mod_dav_svn now enables it by default.
It is even more pointless than that. Looking at the code in svn_fs_fs__initialize_caches() I see that revprop caching is now enabled unconditionally for all FSFS access. The config setting SVN_FS_CONFIG_FSFS_CACHE_REVPROPS is public in svn_fs.h so it has to remain for backward compatibility. The mod_dav_svn SVNCacheRevprops apache directive also still exists. svnserve still has the --cache-revprops command line option. Oddly, we still have code in mod_dav_svn.c and svnserve.c that responds to the directive/option setting and changes the setting of SVN_FS_CONFIG_FSFS_CACHE_REVPROPS in the config hash. That's pointless as there is no FSFS code that responds to that config setting. I suppose the mod_dav_svn directive and svnserve command line option have to remain for backward compatibility, but why do we retain the code that sets SVN_FS_CONFIG_FSFS_CACHE_REVPROPS? -- Philip
