Thank you, Melissa, for tracking this down!
Your effort is very much appreciated.
Cheers,
Stefan
On Wed, Mar 07, 2018 at 11:18:43PM +, Philip Martin wrote:
> [Moving this to the dev@s.a.o list.]
>
> Well done! It looks like you have identified a serious bug here. The
> function svn_fs_fs__
Philip Martin writes:
> https://issues.apache.org/jira/browse/SVN-4722
I've proposed a fix in STATUS.
--
Philip
Philip Martin writes:
> My reproduction doesn't trigger the bug in 1.8 but that seems to be
> because 1.8 has some other problem and the rep-cache deduplication
> doesn't trigger. The third commit restoring the content in the first
> commit simply stores a new delta.
Comparing 1.8 and 1.9 the r
Nathan Hartman writes:
> Is it possible and does it make sense to always continue reading until
> EOF, when the read is either 0 or < 16k? In other words to eliminate
> the comparison against the expanded size?
I believe setting the expanded size correctly is the only fix we need.
> Alternative
On Wed, Mar 7, 2018 at 10:37 PM, Philip Martin
wrote:
>
> The cause of the bug, as identified by Melissa, is that the wrong
> expanded size if computed -- it gets set to the size of the delta in the
> protorev file. The svn_stream_t that is producing the fulltext works in
> 16K chunks, so the t
Julian Foad writes:
> Can someone file an issue in the tracker please. I need to refer to it
> in discussion with potential rc1 trials.
https://issues.apache.org/jira/browse/SVN-4723
--
Philip
Julian Foad writes:
> Please would you file this issue in the issue tracker so I can give
> outsiders a reference to it?
https://issues.apache.org/jira/browse/SVN-4722
My reproduction doesn't trigger the bug in 1.8 but that seems to be
because 1.8 has some other problem and the rep-cache dedupl
Daniel Shahaf wrote:
To be clear, I described two solutions:
1. wdiff3
2. Having the translator run plain old 'svn diff -r N:M' and eyeball the output.
I agree that #1 is a blue sky idea --- more precisely, one with a non-
trivial bootstrap cost --- and as such it is reasonable to reject it,
f
Please would you file this issue in the issue tracker so I can give
outsiders a reference to it?
- Julian
Philip Martin wrote:
Philip Martin writes:
svn cat http://svn.apache.org/repos/asf/subversion/trunk/INSTALL@1826165 > f1
(for i in `seq 0 8712`;do echo -n $i;done && echo -n 1)
Please would you file this issue in the issue tracker so I can give
outsiders a reference to it?
- Julian
Philip Martin wrote:
Philip Martin writes:
svn cat http://svn.apache.org/repos/asf/subversion/trunk/INSTALL@1826165 > f1
(for i in `seq 0 8712`;do echo -n $i;done && echo -n 1)
10 matches
Mail list logo
