Re: svnmover simulates a WC

2015-06-03 Thread Julian Foad
Julian Foad wrote: > On the 'move-tracking-2' branch, 'svnmover' now simulates a WC, [...] danielsh commented on IRC [1]: > svnmover in-memory wc will allow playing with cyclic moves? (cf comment above > simple_moves_within_a_branch()) That may not be a major use-case but certainly > a good tortur

svnmover simulates a WC

2015-06-03 Thread Julian Foad
On the 'move-tracking-2' branch, 'svnmover' now simulates a WC, in memory. Changes you make are committed when you exit svnmover, or whenever you use the 'commit' command. Recently added svnmover commands: commit # also, in effect, updates to head update .@REV # the '.@' is required syntax b

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Branko Čibej
On 03.06.2015 19:50, Ivan Zhakov wrote: > On 3 June 2015 at 20:44, Branko Čibej wrote: >> On 03.06.2015 19:38, Ivan Zhakov wrote: >>> On 3 June 2015 at 20:29, Branko Čibej wrote: >>> An API user who wants an early exit can always trigger the cancel_func in her notification handler and g

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 20:44, Branko Čibej wrote: > On 03.06.2015 19:38, Ivan Zhakov wrote: >> On 3 June 2015 at 20:29, Branko Čibej wrote: >> >>> An API user who wants an early exit can always trigger the cancel_func >>> in her notification handler and get SVN_ERR_CANCELLED in response. >>> >> The pr

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Branko Čibej
On 03.06.2015 19:38, Ivan Zhakov wrote: > On 3 June 2015 at 20:29, Branko Čibej wrote: > >> An API user who wants an early exit can always trigger the cancel_func >> in her notification handler and get SVN_ERR_CANCELLED in response. >> > The problem that it's could be hard to distinguish summary e

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 20:29, Branko Čibej wrote: > On 03.06.2015 17:10, Ivan Zhakov wrote: >> On 3 June 2015 at 17:19, Branko Čibej wrote: >>> On 03.06.2015 15:31, Ivan Zhakov wrote: > I'm also not sure that we have to return error if we already reported it via notify_func in svn_rep

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Branko Čibej
On 03.06.2015 17:10, Ivan Zhakov wrote: > On 3 June 2015 at 17:19, Branko Čibej wrote: >> On 03.06.2015 15:31, Ivan Zhakov wrote: >>> I'm also not sure that we have to return error if we already reported it >>> via notify_func in >>> svn_repos_verify_fs3(). >> >> Out notification mechanism cann

Re: svn commit: r1683387 - /subversion/trunk/subversion/mod_dav_svn/status.c

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 19:47, Bert Huijben wrote: > > >> -Original Message- >> From: i...@apache.org [mailto:i...@apache.org] >> Sent: woensdag 3 juni 2015 18:31 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1683387 - >> /subversion/trunk/subversion/mod_dav_svn/status.c >> >> Au

RE: svn commit: r1683387 - /subversion/trunk/subversion/mod_dav_svn/status.c

2015-06-03 Thread Bert Huijben
> -Original Message- > From: i...@apache.org [mailto:i...@apache.org] > Sent: woensdag 3 juni 2015 18:31 > To: comm...@subversion.apache.org > Subject: svn commit: r1683387 - > /subversion/trunk/subversion/mod_dav_svn/status.c > > Author: ivan > Date: Wed Jun 3 16:31:08 2015 > New Revis

RE: svn commit: r1683378 - in /subversion/trunk/subversion/libsvn_fs_fs: pack.c revprops.c

2015-06-03 Thread Bert Huijben
> -Original Message- > From: i...@apache.org [mailto:i...@apache.org] > Sent: woensdag 3 juni 2015 17:49 > To: comm...@subversion.apache.org > Subject: svn commit: r1683378 - in /subversion/trunk/subversion/libsvn_fs_fs: > pack.c revprops.c > > Author: ivan > Date: Wed Jun 3 15:48:35 20

Re: svn commit: r1683378 - in /subversion/trunk/subversion/libsvn_fs_fs: pack.c revprops.c

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 19:02, Bert Huijben wrote: > > >> -Original Message- >> From: i...@apache.org [mailto:i...@apache.org] >> Sent: woensdag 3 juni 2015 17:49 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1683378 - in /subversion/trunk/subversion/libsvn_fs_fs: >> pack.c revpr

Re: Segfault in Perl bindings when commit touches a large number of files

2015-06-03 Thread Roderich Schupp
On Wed, May 27, 2015 at 7:56 PM, Roderich Schupp wrote: > I've dug a little deeper and think I've found a serious flaw in how the > Perl bindings handle > the Perl arguments and return values stack. > I've committed a series of patches (r1683261:1683271) to address this problem: - identify h

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 17:19, Branko Čibej wrote: > On 03.06.2015 15:31, Ivan Zhakov wrote: > > On 3 June 2015 at 15:33, Branko Čibej wrote: > > On 21.05.2015 17:23, Evgeny Kotkov wrote: > > Subversion 1.9.0-rc1 introduced a new svnadmin verify --keep-going mode [1]. > In order to achieve this, we add

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Branko Čibej
On 03.06.2015 15:31, Ivan Zhakov wrote: > On 3 June 2015 at 15:33, Branko Čibej wrote: >> On 21.05.2015 17:23, Evgeny Kotkov wrote: >>> Subversion 1.9.0-rc1 introduced a new svnadmin verify --keep-going mode [1]. >>> In order to achieve this, we added a svn_repos_verify_fs3() API function and >>>

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 15:33, Branko Čibej wrote: > On 21.05.2015 17:23, Evgeny Kotkov wrote: >> Subversion 1.9.0-rc1 introduced a new svnadmin verify --keep-going mode [1]. >> In order to achieve this, we added a svn_repos_verify_fs3() API function and >> deprecated its predecessor, svn_repos_verify_f

Re: 1.9.0-rc2 up for testing/signing

2015-06-03 Thread Branko Čibej
On 03.06.2015 14:57, Ivan Zhakov wrote: > On 3 June 2015 at 15:35, Branko Čibej wrote: >> On 03.06.2015 14:24, Ivan Zhakov wrote: >>> On 3 June 2015 at 14:37, Branko Čibej wrote: On 02.06.2015 20:05, Branko Čibej wrote: > On 02.06.2015 12:45, Daniel Shahaf wrote: >> Ben Reser wrote o

Re: 1.9.0-rc2 up for testing/signing

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 15:35, Branko Čibej wrote: > On 03.06.2015 14:24, Ivan Zhakov wrote: >> On 3 June 2015 at 14:37, Branko Čibej wrote: >>> On 02.06.2015 20:05, Branko Čibej wrote: On 02.06.2015 12:45, Daniel Shahaf wrote: > Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700: >> T

Re: 1.9.0-rc2 up for testing/signing

2015-06-03 Thread Branko Čibej
On 03.06.2015 14:24, Ivan Zhakov wrote: > On 3 June 2015 at 14:37, Branko Čibej wrote: >> On 02.06.2015 20:05, Branko Čibej wrote: >>> On 02.06.2015 12:45, Daniel Shahaf wrote: Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700: > The 1.9.0-rc2 release artifacts are now available for

Re: Possible incompatibility of svn_repos_verify_fs2() in 1.9.0-rc1

2015-06-03 Thread Branko Čibej
On 21.05.2015 17:23, Evgeny Kotkov wrote: > Subversion 1.9.0-rc1 introduced a new svnadmin verify --keep-going mode [1]. > In order to achieve this, we added a svn_repos_verify_fs3() API function and > deprecated its predecessor, svn_repos_verify_fs2(), that now calls the newer > function with keep

Re: 1.9.0-rc2 up for testing/signing

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 14:37, Branko Čibej wrote: > On 02.06.2015 20:05, Branko Čibej wrote: >> On 02.06.2015 12:45, Daniel Shahaf wrote: >>> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700: The 1.9.0-rc2 release artifacts are now available for testing/signing. Please get the tarballs

Re: 1.9.0-rc2 up for testing/signing

2015-06-03 Thread Branko Čibej
On 02.06.2015 20:05, Branko Čibej wrote: > On 02.06.2015 12:45, Daniel Shahaf wrote: >> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700: >>> The 1.9.0-rc2 release artifacts are now available for testing/signing. >>> Please get the tarballs from >>> https://dist.apache.org/repos/dist/dev/su

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-03 Thread Philip Martin
Ivan Zhakov writes: > FWIW libsvn_fsfs uses dirent->name as key since it's already copied to > result_pool: That was a FSFS change in r1572049; I think it is a better solution so I have applied it to FSX. -- Philip Martin | Subversion Committer WANdisco // *Non-Stop Data*

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-03 Thread Ivan Zhakov
On 3 June 2015 at 12:39, Philip Martin wrote: > Bert Huijben writes: > >> Strange… this should never be necessarily when *removing* something >> from a hash (value =NULL). >> >> >> I think you see some kind of other problem. > > I agree this bit is unnecessary, I have changed it back. > >> @@ -24

Re: svn commit: r1683126 - /subversion/trunk/subversion/libsvn_fs_x/cached_data.c

2015-06-03 Thread Philip Martin
Bert Huijben writes: > Strange… this should never be necessarily when *removing* something > from a hash (value =NULL). > > > I think you see some kind of other problem. I agree this bit is unnecessary, I have changed it back. > @@ -2494,7 +2494,9 @@ read_dir_entries(apr_array_header_t *ent >