On 3 June 2015 at 20:44, Branko Čibej <br...@wandisco.com> wrote: > On 03.06.2015 19:38, Ivan Zhakov wrote: >> On 3 June 2015 at 20:29, Branko Čibej <br...@wandisco.com> wrote: >> >>> An API user who wants an early exit can always trigger the cancel_func >>> in her notification handler and get SVN_ERR_CANCELLED in response. >>> >> The problem that it's could be hard to distinguish summary errors from >> repository corruption errors itself for API user. > > Why? The summary error code (SVN_ERR_REPOS_VERIFY_FAILED) is used in > only at the end of a run with keep_going=TRUE iff the FS backend > returned an error. It cannot be returned from the FS backend validation > functions, so it will never appear in a notification and will never be > returned when keep_going=FALSE. In fact, that's the main reason I > decided to keep a separate, new error code for this case. > Is it documented that only SVN_ERR_REPOS_VERIFY_FAILED used for summary errors? Do we promise to always return this error code?
Anyway I didn't say that it's impossible to distinguish them, but could be complicated and may be we should make it API user responsibility to construct summary error if needed. -- Ivan Zhakov
