Re: Weird bug with directory deltification in 1.8.x

2015-04-28 Thread Stefan Fuhrmann
On Tue, Apr 28, 2015 at 6:18 PM, Roderich Schupp wrote: > Hi, > > found in the wild, reproducible with this script: > > -- > [...] > > Notes: > - "svnadmin verify" does NOT report any errors > - indeed the output of "svnadmin dump" looks correct > - enable-dir-deltification is defini

Re: 1.9: javahl.ISVNClient#cleanup(String) always fails with "Attempted to lock an already-locked dir"

2015-04-28 Thread Branko Čibej
On 23.04.2015 16:44, Marc Strapetz wrote: > cleanup-related code which is working fine with 1.8 JavaHL starts > failing with 1.9 JavaHL. > > According to the docs, ISVNClient#cleanup(String) does not break > locks, which seems to cause the problems: > > /** >* Recursively cleans up a local di

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-28 Thread Branko Čibej
On 28.04.2015 21:22, Bert Huijben wrote: > >> -Original Message- >> From: Marc Strapetz [mailto:marc.strap...@syntevo.com] >> Sent: dinsdag 28 april 2015 20:26 >> To: Branko Čibej >> Cc: Subversion Development >> Subject: Re: 1.9 JavaHL memory leak in ISVNRemote#status >> Also, I should add

Re: Weird bug with directory deltification in 1.8.x

2015-04-28 Thread Stefan Fuhrmann
On Tue, Apr 28, 2015 at 6:18 PM, Roderich Schupp wrote: > Hi, > > found in the wild, reproducible with this script: > Hi Roderich, Thanks for the report & reproduction recipe. I'll have a look at it over the next few days (currently travelling with a few hours to spare) and I already have a sus

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-28 Thread Branko Čibej
On 28.04.2015 20:06, Marc Strapetz wrote: > On 28.04.2015 18:12, Branko Čibej wrote: >> On 28.04.2015 18:03, Marc Strapetz wrote: >>> Hi Brane, >>> >>> On 28.04.2015 07:36, Branko Čibej wrote: On 24.04.2015 14:11, Branko Čibej wrote: > > Hi Marc, > > Just a quick note: your las

RE: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-28 Thread Bert Huijben
> -Original Message- > From: Marc Strapetz [mailto:marc.strap...@syntevo.com] > Sent: dinsdag 28 april 2015 20:26 > To: Branko Čibej > Cc: Subversion Development > Subject: Re: 1.9 JavaHL memory leak in ISVNRemote#status > Also, I should add that according to the Profiler, the byte[]s ar

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-28 Thread Marc Strapetz
On 28.04.2015 20:06, Marc Strapetz wrote: On 28.04.2015 18:12, Branko Čibej wrote: On 28.04.2015 18:03, Marc Strapetz wrote: Hi Brane, On 28.04.2015 07:36, Branko Čibej wrote: On 24.04.2015 14:11, Branko Čibej wrote: Hi Marc, Just a quick note: your last msg jogged my memory and I think I

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-28 Thread Marc Strapetz
On 28.04.2015 18:12, Branko Čibej wrote: On 28.04.2015 18:03, Marc Strapetz wrote: Hi Brane, On 28.04.2015 07:36, Branko Čibej wrote: On 24.04.2015 14:11, Branko Čibej wrote: Hi Marc, Just a quick note: your last msg jogged my memory and I think I know the root cause of the leak: improper J

Re: svn commit: r1676535 -/subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Branko Čibej
On 28.04.2015 18:54, Bert Huijben wrote: > Not on a pc, but this uses a Windows function that allows moving the > file while it is still open. Normally when the file is reopened for > moving by the os, virus scanners will lock the file until they are > sure they are safe. In many cases involving ou

RE: svn commit: r1676535 -/subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Bert Huijben
Not on a pc, but this uses a Windows function that allows moving the file while it is still open. Normally when the file is reopened for moving by the os, virus scanners will lock the file until they are sure they are safe. In many cases involving our retry logic) This moves this check to *afte

Weird bug with directory deltification in 1.8.x

2015-04-28 Thread Roderich Schupp
Hi, found in the wild, reproducible with this script: -- # cleanup previous experiments rm -rf repo import url=file://$PWD/repo svnadmin create --compatible-version 1.8 repo cat > repo/db/fsfs.conf < foo.txt echo bar > bar.txt mkdir -p directory-with-a-longish-name svn im

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-28 Thread Branko Čibej
On 28.04.2015 18:03, Marc Strapetz wrote: > Hi Brane, > > On 28.04.2015 07:36, Branko Čibej wrote: >> On 24.04.2015 14:11, Branko Čibej wrote: >>> >>> Hi Marc, >>> >>> Just a quick note: your last msg jogged my memory and I think I know >>> the root cause of the leak: improper JNI frame management

Re: 1.9 JavaHL memory leak in ISVNRemote#status

2015-04-28 Thread Marc Strapetz
Hi Brane, On 28.04.2015 07:36, Branko Čibej wrote: On 24.04.2015 14:11, Branko Čibej wrote: Hi Marc, Just a quick note: your last msg jogged my memory and I think I know the root cause of the leak: improper JNI frame management within a loop. If I'm right, I can both fix the leak and remove t

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Ivan Zhakov
On 28 April 2015 at 18:42, Philip Martin wrote: > Ivan Zhakov writes: > >>> What does "can be installed using Windows checkouts much slower than >>> Unix" mean? >>> >> I have no idea. This function was added in r1559758 [1] as preparation >> to fix issue #4450 "Windows checkouts much slower then

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Philip Martin
Ivan Zhakov writes: >> What does "can be installed using Windows checkouts much slower than >> Unix" mean? >> > I have no idea. This function was added in r1559758 [1] as preparation > to fix issue #4450 "Windows checkouts much slower then Unix" [2]. May > issue summary leaked to function docstri

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Ivan Zhakov
On 28 April 2015 at 18:32, Philip Martin wrote: > Ivan Zhakov writes: > SVN_ERR(svn_stream__create_for_install(&stream, deep_dir, pool, pool)); SVN_ERR(svn_stream_puts(stream, "stream1 content")); + SVN_ERR(svn_stream_close(stream)); SVN_ERR(svn_stream__install_strea

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Philip Martin
Ivan Zhakov writes: >>>SVN_ERR(svn_stream__create_for_install(&stream, deep_dir, pool, pool)); >>>SVN_ERR(svn_stream_puts(stream, "stream1 content")); >>> + SVN_ERR(svn_stream_close(stream)); >>>SVN_ERR(svn_stream__install_stream(stream, >>> fina

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Branko Čibej
On 28.04.2015 17:03, Ivan Zhakov wrote: > On 28 April 2015 at 17:56, Branko Čibej wrote: >> On 28.04.2015 15:45, i...@apache.org wrote: >>> Author: ivan >>> Date: Tue Apr 28 13:45:42 2015 >>> New Revision: 1676535 >>> >>> URL: http://svn.apache.org/r1676535 >>> Log: >>> Follow-up to r1676526: Clos

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Ivan Zhakov
On 28 April 2015 at 17:56, Branko Čibej wrote: > On 28.04.2015 15:45, i...@apache.org wrote: >> Author: ivan >> Date: Tue Apr 28 13:45:42 2015 >> New Revision: 1676535 >> >> URL: http://svn.apache.org/r1676535 >> Log: >> Follow-up to r1676526: Close install_stream in test. >> >> * subversion/tests

Re: svn commit: r1676535 - /subversion/trunk/subversion/tests/libsvn_subr/io-test.c

2015-04-28 Thread Branko Čibej
On 28.04.2015 15:45, i...@apache.org wrote: > Author: ivan > Date: Tue Apr 28 13:45:42 2015 > New Revision: 1676535 > > URL: http://svn.apache.org/r1676535 > Log: > Follow-up to r1676526: Close install_stream in test. > > * subversion/tests/libsvn_subr/io-test.c > (test_install_stream_to_longpath

Re: Subversion 1.9: svn cp --pin-externals may produce dummy logentries

2015-04-28 Thread Stefan Sperling
On Thu, Apr 23, 2015 at 05:46:29PM +0100, Julian Foad wrote: > Bert Huijben wrote: > > I don't think this is really a noop change. Most likely svnadmin dump will > > show that it recorded a change on the fs layer. > > > > The replay API (such as used by svnsync and svnrdump) probably won't show a >

Re: Cannot checkout or clean up using 1.9 dev build

2015-04-28 Thread Benjamin Fritz
On Apr 28, 2015 8:02 AM, "Ivan Zhakov" wrote: > > > I've fixed at least one problem in svn_stream__install*() on Windows > with long path names in r1676526. > > But I was getting different error message on Windows 8.1. Benjamin, > what operating system do you use? > Windows 7

Re: Cannot checkout or clean up using 1.9 dev build

2015-04-28 Thread Ivan Zhakov
On 28 April 2015 at 16:15, Benjamin Fritz wrote: > > On Apr 28, 2015 8:02 AM, "Ivan Zhakov" wrote: >> >> >> I've fixed at least one problem in svn_stream__install*() on Windows >> with long path names in r1676526. >> >> But I was getting different error message on Windows 8.1. Benjamin, >> what o

Re: Cannot checkout or clean up using 1.9 dev build

2015-04-28 Thread Ivan Zhakov
On 28 April 2015 at 10:07, Ivan Zhakov wrote: > On 27 April 2015 at 21:35, Benjamin Fritz wrote: >> Apparently I'm not subscribed to get list emails; please CC me on future >> responses. I had to get this message from the archive :-) >> >> Branko Čibej wrote: >>> On 27.04.2015 18:06, Benjamin Fri