On 28 April 2015 at 18:42, Philip Martin <philip.mar...@wandisco.com> wrote: > Ivan Zhakov <i...@visualsvn.com> writes: > >>> What does "can be installed using Windows checkouts much slower than >>> Unix" mean? >>> >> I have no idea. This function was added in r1559758 [1] as preparation >> to fix issue #4450 "Windows checkouts much slower then Unix" [2]. May >> issue summary leaked to function docstring for some reason. > > I suspect it should be "can be installed using platform specific > optimizations". Perhaps with something additional about closing the > stream before installing. > > Is closing before installing just allowed or is it required? Before > your commit I wrote a patch that closed the stream *after* calling > svn_stream__install_stream and that was sufficient for the test to pass. > As far I understand from learning code close is *required* and should be performed *before* calling svn_stream__install_stream(). Calling svn_stream_close() after svn_stream__install_stream() works because OS just flushes buffers to new location, but it's platform specific behavior and data may be lost if power off between move and flush for some reason.
-- Ivan Zhakov
