Re: Configuring Subversion with Berkeley DB Error: configure: error: Berkeley DB 4.0.14 or 5.x wasn't found

On 06.02.2015 19:14, kay wrote: > I set the LD_LIBRARY_PATH as follows: > > LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/lib:/usr/local/lib:/usr/sfw/lib/:/usr/local/BerkeleyDB.5.3/lib > export LD_LIBRARY_PATH > > and also have the below in my ./configure as suggested by Brane > > --with-berkeley-db=/usr/

[RFC] Remove pointless 'message' arg from svntest.actions.run_and_verify_*

I have been wanting for a long time to simplify run_and_verify_*() calls a little by removing the 'message' argument, as per the log message below. Does anyone else feel the same way? Or is anybody fond of this 'message' argument, or concerned about code churn in the test suite (making backports

Re: Configuring Subversion with Berkeley DB Error: configure: error: Berkeley DB 4.0.14 or 5.x wasn't found

I set the LD_LIBRARY_PATH as follows: LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/lib:/usr/local/lib:/usr/sfw/lib/:/usr/local/BerkeleyDB.5.3/lib export LD_LIBRARY_PATH and also have the below in my ./configure as suggested by Brane --with-berkeley-db=/usr/local/BerkeleyDB.5.3/include/db.h:/usr/local/

Re: [PATCH] Fix potential crash in libsvn_repos when executing pre-commit hook

> I committed the test using /bin/sh, anything else is a lot more work and > possibly more likely to fail than to find a system without /bin/sh. I'm agree, other options seems to be less reliable and much more complicated. Finally, there is well-known practise of using /usr/bin/env (e.g. '#!/usr/

Re: [PATCH] Fix potential crash in libsvn_repos when executing pre-commit hook

Branko Čibej writes: >> I would expect this to work in practice as I've never seen a Unix >> machine without /bin/sh, but I suppose strictly speaking we cannot rely >> on /bin/sh. Is it portable enough? I suppose we could have a configure >> variable based on CONFIG_SHELL. Or have a configure

Re: [PATCH] Fix potential crash in libsvn_repos when executing pre-commit hook

On 06.02.2015 17:14, Philip Martin wrote: > Sergey Raevskiy writes: > >> + /* Set an empty pre-commit hook. */ >> +#ifdef WIN32 >> + SVN_ERR(svn_io_file_create( >> + "test-repo-deprecated-access-context-api/hooks/pre-commit.bat", >> + "exit 0" APR_EOL_STR, pool)); >> +#else >> + SVN_E

Re: [PATCH] Fix potential crash in libsvn_repos when executing pre-commit hook

Sergey Raevskiy writes: > + /* Set an empty pre-commit hook. */ > +#ifdef WIN32 > + SVN_ERR(svn_io_file_create( > + "test-repo-deprecated-access-context-api/hooks/pre-commit.bat", > + "exit 0" APR_EOL_STR, pool)); > +#else > + SVN_ERR(svn_io_file_create( > + "test-repo-deprecate

Re: svn commit: r1657846 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c wc_db.h wc_db_private.h wc_db_update_move.c

On 06.02.2015 16:48, Bert Huijben wrote: > >> -Original Message- >> From: Branko Čibej [mailto:br...@wandisco.com] >> Sent: vrijdag 6 februari 2015 15:58 >> To: dev@subversion.apache.org >> Subject: Re: svn commit: r1657846 - in >> /subversion/trunk/subversion/libsvn_wc: >> wc-queries.sql

RE: svn commit: r1657846 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c wc_db.h wc_db_private.h wc_db_update_move.c

> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: vrijdag 6 februari 2015 15:58 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1657846 - in /subversion/trunk/subversion/libsvn_wc: > wc-queries.sql wc_db.c wc_db.h wc_db_private.h wc_db_update_move.c

Re: [PATCH] Fix potential crash in libsvn_repos when executing pre-commit hook

Thanks for the review! I really messed up the test. > How is that going to work? "exit 0" is not a valid hook script. It > might work with an additional "/bin/sh" but that is not portable. This will actually work on Windows, but yes, it isn't portable. > Ah! The fs layer does not run any hoo

Re: svn commit: r1657846 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c wc_db.h wc_db_private.h wc_db_update_move.c

On 06.02.2015 15:46, rhuij...@apache.org wrote: > Author: rhuijben > Date: Fri Feb 6 14:46:49 2015 > New Revision: 1657846 > > URL: http://svn.apache.org/r1657846 > Log: > Instead of transforming nodes into an copy by changing their op-depth make > a proper copy, to allow the layer bump code to ha

Re: svn commit: r1657797 - /subversion/branches/reuse-ra-session/subversion/libsvn_client/ra_cache.c

On 6 February 2015 at 17:13, Branko Čibej wrote: > On 06.02.2015 15:00, Ivan Zhakov wrote: >> On 6 February 2015 at 16:50, Branko Čibej wrote: >>> On 06.02.2015 14:13, i...@apache.org wrote: Author: ivan Date: Fri Feb 6 13:13:14 2015 New Revision: 1657797 URL: http://svn

Re: svn commit: r1657797 - /subversion/branches/reuse-ra-session/subversion/libsvn_client/ra_cache.c

On 06.02.2015 15:00, Ivan Zhakov wrote: > On 6 February 2015 at 16:50, Branko Čibej wrote: >> On 06.02.2015 14:13, i...@apache.org wrote: >>> Author: ivan >>> Date: Fri Feb 6 13:13:14 2015 >>> New Revision: 1657797 >>> >>> URL: http://svn.apache.org/r1657797 >>> Log: >>> On the reuse-ra-session b

Re: svn commit: r1657797 - /subversion/branches/reuse-ra-session/subversion/libsvn_client/ra_cache.c

On 6 February 2015 at 16:50, Branko Čibej wrote: > On 06.02.2015 14:13, i...@apache.org wrote: >> Author: ivan >> Date: Fri Feb 6 13:13:14 2015 >> New Revision: 1657797 >> >> URL: http://svn.apache.org/r1657797 >> Log: >> On the reuse-ra-session branch: Avoid svn_ra_reparent() call and network >>

Re: svn commit: r1657782 - /subversion/branches/reuse-ra-session/BRANCH-README

On 6 February 2015 at 16:50, Branko Čibej wrote: > On 06.02.2015 14:47, Ivan Zhakov wrote: >> On 6 February 2015 at 16:13, Bert Huijben wrote: >>> -Original Message- From: Ivan Zhakov [mailto:i...@visualsvn.com] Sent: vrijdag 6 februari 2015 14:04 To: Bert Huijben

Re: svn commit: r1657797 - /subversion/branches/reuse-ra-session/subversion/libsvn_client/ra_cache.c

On 06.02.2015 14:13, i...@apache.org wrote: > Author: ivan > Date: Fri Feb 6 13:13:14 2015 > New Revision: 1657797 > > URL: http://svn.apache.org/r1657797 > Log: > On the reuse-ra-session branch: Avoid svn_ra_reparent() call and network > round-trip for svn:// protocol if possible. > > * subversi

Re: svn commit: r1657782 - /subversion/branches/reuse-ra-session/BRANCH-README

On 06.02.2015 14:47, Ivan Zhakov wrote: > On 6 February 2015 at 16:13, Bert Huijben wrote: >> >>> -Original Message- >>> From: Ivan Zhakov [mailto:i...@visualsvn.com] >>> Sent: vrijdag 6 februari 2015 14:04 >>> To: Bert Huijben >>> Cc: Subversion Development >>> Subject: Re: svn commit: r1

Re: svn commit: r1657782 - /subversion/branches/reuse-ra-session/BRANCH-README

On 6 February 2015 at 16:13, Bert Huijben wrote: > > >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: vrijdag 6 februari 2015 14:04 >> To: Bert Huijben >> Cc: Subversion Development >> Subject: Re: svn commit: r1657782 - /subversion/branches/reuse-ra- >> sess

Re: svn commit: r1657782 - /subversion/branches/reuse-ra-session/BRANCH-README

On 06.02.2015 13:55, Bert Huijben wrote: > >> -Original Message- >> From: br...@apache.org [mailto:br...@apache.org] >> Sent: vrijdag 6 februari 2015 12:10 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1657782 - /subversion/branches/reuse-ra- >> session/BRANCH-README >> >> A

RE: svn commit: r1657782 - /subversion/branches/reuse-ra-session/BRANCH-README

> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: vrijdag 6 februari 2015 14:04 > To: Bert Huijben > Cc: Subversion Development > Subject: Re: svn commit: r1657782 - /subversion/branches/reuse-ra- > session/BRANCH-README > > On 6 February 2015 at 15:55, Bert Hu

Re: svn commit: r1657782 - /subversion/branches/reuse-ra-session/BRANCH-README

On 6 February 2015 at 15:55, Bert Huijben wrote: > > >> -Original Message- >> From: br...@apache.org [mailto:br...@apache.org] >> Sent: vrijdag 6 februari 2015 12:10 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1657782 - /subversion/branches/reuse-ra- >> session/BRANCH-REA

RE: svn commit: r1657782 - /subversion/branches/reuse-ra-session/BRANCH-README

> -Original Message- > From: br...@apache.org [mailto:br...@apache.org] > Sent: vrijdag 6 februari 2015 12:10 > To: comm...@subversion.apache.org > Subject: svn commit: r1657782 - /subversion/branches/reuse-ra- > session/BRANCH-README > > Author: brane > Date: Fri Feb 6 11:09:54 2015 >

[PATCH] The reuse-ra-session branch: optimize RA session usage in merge code

Hi, Automatic merge creates minimum 8 connection using code in trunk. The RA cache framework implemented in reuse-ra-session reduce number of used RA sessions to 3. The attached patch for reuse-ra-session branch reworks merge.c a bit to use just 2 RA sessions. It also resolves RA CACHE TODO: comm

Re: svn commit: r1657756 - /subversion/trunk/subversion/libsvn_wc/wc_db_update_move.c

On Fri, Feb 6, 2015 at 11:06 AM, Branko Čibej wrote: > On 06.02.2015 09:40, stef...@apache.org wrote: > > Author: stefan2 > > Date: Fri Feb 6 08:40:35 2015 > > New Revision: 1657756 > > > > URL: http://svn.apache.org/r1657756 > > Log: > > Fix "variable 'shadowed' set but not used" compiler warni

Re: [PATCH] Fix potential crash in libsvn_repos when executing pre-commit hook

Sergey Raevskiy writes: > +static svn_error_t * > +pre_commit_hook_lock_token_without_path(const svn_test_opts_t *opts, > +apr_pool_t *pool) > +{ > + svn_repos_t *repos; > + svn_fs_access_t *access; > + svn_fs_txn_t *txn; > + svn_fs_root_t *root; > + c

Re: svn commit: r1657756 - /subversion/trunk/subversion/libsvn_wc/wc_db_update_move.c

On 06.02.2015 09:40, stef...@apache.org wrote: > Author: stefan2 > Date: Fri Feb 6 08:40:35 2015 > New Revision: 1657756 > > URL: http://svn.apache.org/r1657756 > Log: > Fix "variable 'shadowed' set but not used" compiler warning. > This seems to be a fallout of r1657725. > > * subversion/libsvn_w

Re: svn commit: r1656616 - in /subversion/branches/reuse-ra-session: BRANCH-README subversion/libsvn_client/client.h subversion/libsvn_client/ra_cache.c

On 06.02.2015 09:54, Greg Stein wrote: > > > On Wed, Feb 4, 2015 at 3:35 AM, Branko Čibej > wrote: > > On 04.02.2015 03:22, Greg Stein wrote: > > On Mon, Feb 2, 2015 at 7:52 PM, > wrote: > >> ... > >> +++ subversion/branches/

Re: [PATCH] Fix potential crash in libsvn_repos when executing pre-commit hook

Sergey Raevskiy writes: > I've attached the patch with crashing test and simple fix, but I'm not really > sure about my solution. A probably better approach would be to replace magic > pointer value by an empty string, but I'm not sure about binary compatibility > etc. The empty string is a val

Re: svn commit: r1656616 - in /subversion/branches/reuse-ra-session: BRANCH-README subversion/libsvn_client/client.h subversion/libsvn_client/ra_cache.c

On Wed, Feb 4, 2015 at 3:35 AM, Branko Čibej wrote: > On 04.02.2015 03:22, Greg Stein wrote: > > On Mon, Feb 2, 2015 at 7:52 PM, wrote: > >> ... > >> +++ subversion/branches/reuse-ra-session/BRANCH-README Tue Feb 3 > 01:52:26 > >> 2015 > >> @@ -8,12 +8,19 @@ all changes made in the branch. > >>