Re: svn commit: r1505121 - /subversion/trunk/build/generator/gen_base.py

2013-08-01 Thread Daniel Shahaf
rhuij...@apache.org wrote on Sat, Jul 20, 2013 at 10:44:32 -: > Author: rhuijben > Date: Sat Jul 20 10:44:31 2013 > New Revision: 1505121 > > URL: http://svn.apache.org/r1505121 > Log: > * build/generator/gen_base.py > (write_errno_table): Remove obsolete part of comment. On Windows we alway

Importing -deps tarballs to archive.apache.org

2013-08-01 Thread Daniel Shahaf
They're not there right now. I assume it'll be good to have them there, so I've begun the process of clearing the import with legal@: https://issues.apache.org/jira/browse/LEGAL-176 It seems there were no -deps tarballs produced prior to 1.4.0.

Re: svn commit: r1509342 - in /subversion/branches/log-addressing/subversion/libsvn_fs_fs: fs.h fs_fs.c util.c util.h

2013-08-01 Thread Daniel Shahaf
stef...@apache.org wrote on Thu, Aug 01, 2013 at 17:36:42 -: > Author: stefan2 > Date: Thu Aug 1 17:36:42 2013 > New Revision: 1509342 > > URL: http://svn.apache.org/r1509342 > Log: > On the log-addressing branch: High-level question: how does this compare to fsx? Is this a feature fsx alre

Re: FSX ready for /trunk

2013-08-01 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Aug 01, 2013 at 16:38:09 +0200: > The fsx branch is in sync with /trunk and passes all tests > for fsfs and fsx. The latter is marked as experimental and > will remain so for the 1.9 release and possibly 1.10 as well. Two minor comments: Can we have an "Experimental"

Re: FSX ready for /trunk

2013-08-01 Thread Masaru Tsuchiyama
Hi. I tried to compile it on Windows (with VS2008). But I got a compler at libsvn_fs_x. subversion\libsvn_fs_x\cached_data.c(1042) : error C4115: 'rep_state' : named type definition in parentheses I attach a patch to fix the compiler error. Regards. -- Masaru Tsuchiyama fsx-r1509467-20130

FSX ready for /trunk

2013-08-01 Thread Stefan Fuhrmann
Hi all, The fsx branch is in sync with /trunk and passes all tests for fsfs and fsx. The latter is marked as experimental and will remain so for the 1.9 release and possibly 1.10 as well. Existing FS backends remain untouched. If there are no objections, I will merge the branch to /trunk on Aug 3

Re: [PATCH] add 'svn:use-commit-times' property

2013-08-01 Thread Philip Martin
Daniel Shahaf writes: > Philip Martin wrote on Wed, Jul 31, 2013 at 15:09:10 +0100: >> Perhaps this property should be inheritable? Then it could be set on a >> directory and apply to the whole tree? > > Even if yes, can't inheritability be implemented in a future patch? > i.e., maybe we should

Re: svn commit: r1509189 - /subversion/branches/1.8.x/STATUS

2013-08-01 Thread Daniel Shahaf
stevek...@apache.org wrote on Thu, Aug 01, 2013 at 12:02:39 -: > - * r1507382 > + * r1507382, 1509186 In the future, please don't omit the "r" here, the parser relies on it. Thanks. (used by svn-role@ commits, svn-backport-conflicts-1.8.x buildbot, and by Ben and I's workflow) > Allow pa

Re: [PATCH] add 'svn:use-commit-times' property

2013-08-01 Thread Daniel Shahaf
Could you generate patches with svn diff -x-p , please? That makes review easier. Thanks.

Re: [PATCH] add 'svn:use-commit-times' property

2013-08-01 Thread Daniel Shahaf
Philip Martin wrote on Wed, Jul 31, 2013 at 15:09:10 +0100: > Perhaps this property should be inheritable? Then it could be set on a > directory and apply to the whole tree? Even if yes, can't inheritability be implemented in a future patch? i.e., maybe we should commit this patch and then think

Re: [PATCH] print debug information when subprocess.Popen subprocess.Popen

2013-08-01 Thread Daniel Shahaf
Please send patches as text/plain (*.txt extension often does this). Masaru Tsuchiyama wrote on Sun, Jul 28, 2013 at 20:00:27 +0900: > +++ subversion/tests/cmdline/svntest/main.py (working copy) > @@ -412,12 +412,19 @@ >if not stderr: > stderr = subprocess.PIPE > > - p = subprocess.Po

Re: config dir and svn_config_walk_auth_data

2013-08-01 Thread Daniel Shahaf
Stefan Küng wrote on Fri, Jul 26, 2013 at 19:55:18 +0200: > On 26.07.2013 19:32, Branko Čibej wrote: >> On 26.07.2013 19:19, Stefan Küng wrote: >>> Hi, >>> >>> In TSVN I'm using the API svn_config_walk_auth_data(). Unfortunately, >>> I'm passing NULL as the first parameter (the config dir path). >>

Re: svn commit: r1508170 - in /subversion/trunk:

2013-08-01 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Aug 01, 2013 at 12:31:27 +0200: > On Thu, Aug 1, 2013 at 6:36 AM, Daniel Shahaf wrote: > > #define svn_hash_sets(ht, key, val) \ > > apr_hash_set(ht, key, APR_HASH_KEY_STRING, val) > > > > I would keep the current code for that. I allows for the > compile

Re: svn commit: r1508170 - in /subversion/trunk:

2013-08-01 Thread Stefan Fuhrmann
On Thu, Aug 1, 2013 at 12:51 PM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Thu, Aug 01, 2013 at 12:27:08 +0200: > > On Thu, Aug 1, 2013 at 4:47 AM, Daniel Shahaf wrote: > > > > > Stefan Fuhrmann wrote on Wed, Jul 31, 2013 at 23:21:45 +0200: > > > > * revert svn_hash_gets to simply use APR_

Re: svn commit: r1508170 - in /subversion/trunk:

2013-08-01 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Wed, Jul 31, 2013 at 23:21:45 +0200: > * revert svn_hash_gets to simply use APR_HASH_KEY_STRING Went ahead and did this in r1509166 + r1509168.

Re: svn commit: r1508170 - in /subversion/trunk:

2013-08-01 Thread Daniel Shahaf
Stefan Fuhrmann wrote on Thu, Aug 01, 2013 at 12:27:08 +0200: > On Thu, Aug 1, 2013 at 4:47 AM, Daniel Shahaf wrote: > > > Stefan Fuhrmann wrote on Wed, Jul 31, 2013 at 23:21:45 +0200: > > > * revert svn_hash_gets to simply use APR_HASH_KEY_STRING > > > > ... > > > > > * where it is being used, m

Re: svn commit: r1508170 - in /subversion/trunk:

2013-08-01 Thread Stefan Fuhrmann
On Thu, Aug 1, 2013 at 6:36 AM, Daniel Shahaf wrote: > Daniel Shahaf wrote on Thu, Aug 01, 2013 at 05:47:58 +0300: > > Stefan Fuhrmann wrote on Wed, Jul 31, 2013 at 23:21:45 +0200: > > > * revert svn_hash_gets to simply use APR_HASH_KEY_STRING > > > > ... > > > > > * where it is being used, make

Re: svn commit: r1508170 - in /subversion/trunk:

2013-08-01 Thread Stefan Fuhrmann
On Thu, Aug 1, 2013 at 4:47 AM, Daniel Shahaf wrote: > Stefan Fuhrmann wrote on Wed, Jul 31, 2013 at 23:21:45 +0200: > > * revert svn_hash_gets to simply use APR_HASH_KEY_STRING > > ... > > > * where it is being used, make svn_private_config.h the first #include > > Why would the order of include

Re: Unexplained "Corrupt representation" errors with 1.8.1

2013-08-01 Thread Ben Reser
On Wed, Jul 31, 2013 at 11:30 PM, Branko Čibej wrote: > People will also "svnadmin create" and then "cp -a" the results all over > the place -- a case where using an inode is better than using a UUID. At least with the cache system you can solve that by simply also storing the path as part of you

Re: [PATCH] add 'svn:use-commit-times' property

2013-08-01 Thread Ben Reser
On Wed, Jul 31, 2013 at 11:19 PM, Markus Schaber wrote: > Using another property is not compatible with inheritance, as it will be > difficult to override the setting again in deeper nested directories. > > What about disabling the feature when the property contains the test "false"? +1 Inherit