Stefan Fuhrmann wrote on Thu, Aug 01, 2013 at 12:27:08 +0200: > On Thu, Aug 1, 2013 at 4:47 AM, Daniel Shahaf <danie...@elego.de> wrote: > > > Stefan Fuhrmann wrote on Wed, Jul 31, 2013 at 23:21:45 +0200: > > > * revert svn_hash_gets to simply use APR_HASH_KEY_STRING > > > > ... > > > > > * where it is being used, make svn_private_config.h the first #include > > > > Why would the order of includes matter? Do you plan to still use > > SVN_HAS_DUNDER_BUILTINS in svn_hash_sets()? > > > > No such plans ATM. However, I was thinking that global > settings should always be available - even to our internal > headers. Today, you get a compiler error, if you use _() in > a header without including svn_private_config.h before it.
Public headers or private headers? Public headers must not refer to svn_private_config.h, so #include'ing svn_private_config.h before public headers could only lead to bugs. > > I'm not *strongly* advocating for that coding rule but since > we are already halfway there, I might as well complete it > and possibly benefit from it in the future. I'd even volunteer > to invest 30mins to do it ;) > > -- Stefan^2.
