Approve group? (was: svn commit: r1502108 ...)

2013-07-10 Thread Greg Stein
Hey all, I'd like to see us get this approved and applied to 1.8.x. My recent changes "should" remove danielsh's issue with the patch group. Regarding Ben's, I'd suggest: any additional change would build upon this group. Thus, since the darned group is getting pretty large, I think it would make

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Greg Stein
On Wed, Jul 10, 2013 at 6:57 PM, Ben Reser wrote: >... > I have about 160ms of latency to this server. Mostly because I'm on > the west coast of the US and it's in the UK someplace based on it's > domain name. Human perception is right around the 250ms mark. User interface designers use that met

Re: svn commit: r1501654 - in /subversion/branches/tristate-chunked-request/subversion: include/svn_config.h libsvn_ra_serf/options.c libsvn_ra_serf/ra_serf.h libsvn_ra_serf/serf.c libsvn_ra_serf/util

2013-07-10 Thread Greg Stein
On Wed, Jul 10, 2013 at 1:59 AM, wrote: >... > * subversion/libsvn_ra_serf/ra_serf.h > (svn_ra_serf__session_t): Replace using_chunked_requests and busted_proxy > members with set_CL and using_chunked_requests members respectively. > The new using_chunked_requests member is now a trist

Re: [PATCH] svn: enforce exact version match

2013-07-10 Thread Branko Čibej
On 11.07.2013 01:22, Daniel Shahaf wrote: > We decided a while ago that the cmdline client and all C libraries must > be upgraded in lockstep.[1] However, a Subversion 1.7.10 client out > there happily uses 1.7.9 libraries that happened to be lying in the > runtime linker's search path. Did we? I

[PATCH] svn: enforce exact version match

2013-07-10 Thread Daniel Shahaf
We decided a while ago that the cmdline client and all C libraries must be upgraded in lockstep.[1] However, a Subversion 1.7.10 client out there happily uses 1.7.9 libraries that happened to be lying in the runtime linker's search path. The enclosed patch fixes that to require exact version matc

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Ben Reser
On Wed, Jul 10, 2013 at 3:57 PM, Ben Reser wrote: > LOG --diff: RTT*(1+(revisions*2) [It appears we make 2 connections > per revision to do the diff, ouch, I guess that explains why log > --diff is so slow already] Err I mean we make 2 sessions. For log --diff with make 1+(revisions*2) sessions

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Ben Reser
On Wed, Jul 10, 2013 at 7:45 AM, Greg Stein wrote: > IOW, while I may agree with "regression", I'm not sure that we should > impact 99+% in order to deal with it. I'm not sure it is a reasonable > tradeoff. Providing some real world numbers. I tested against: http://svn.mkgmap.org.uk/mkgmap/trun

Re: Semantics of svn_error_t->apr_err

2013-07-10 Thread Greg Stein
On Wed, Jul 10, 2013 at 1:08 PM, Daniel Shahaf wrote: >... > Okay. Suppose an API caller gets 120171 as the error code from > svn_ra_foo(). I ignore the question of how to recognise that 120171 is > not a Subversion error[1]. > > 1 - How does he know that 120171 is a serf error? > > 2 - Given th

Re: [Apache HTTP Server Project: [Announcement] Apache HTTP Server 2.2.25 Released]

2013-07-10 Thread Ben Reser
On Wed, Jul 10, 2013 at 11:13 AM, Mark Phippard wrote: > I am not seeing the release on their web site or on their announce@ list. I think they're like us emails go out before the website is updated. I can assure you that the release is real it's in their dist dir: https://dist.apache.org/repos/

Re: [Apache HTTP Server Project: [Announcement] Apache HTTP Server 2.2.25 Released]

2013-07-10 Thread Mark Phippard
I am not seeing the release on their web site or on their announce@ list. Also there is no mention of a 2.4.5 here? Mark On Wed, Jul 10, 2013 at 11:00 AM, Daniel Shahaf wrote: > - Forwarded message from Apache HTTP Server Project > - > >> From: "Apache HTTP Server Project" >> Subje

Fwd: [Apache HTTP Server Project: [Announcement] Apache HTTP Server 2.2.25 Released]

2013-07-10 Thread Daniel Shahaf
- Forwarded message from Apache HTTP Server Project - > From: "Apache HTTP Server Project" > Subject: [Announcement] Apache HTTP Server 2.2.25 Released > To: annou...@subversion.apache.org > Date: Wed, 10 Jul 2013 12:51:06 -0500 > Message-ID: <20130710125106.6a2eb0d7.wr...@rowe-clan.net>

Re: Semantics of svn_error_t->apr_err

2013-07-10 Thread Daniel Shahaf
Greg Stein wrote on Tue, Jul 09, 2013 at 20:59:48 -0400: > On Tue, Jul 9, 2013 at 4:40 PM, Daniel Shahaf wrote: > > Bert Huijben wrote on Tue, Jul 09, 2013 at 22:32:00 +0200: > >... > >> There is no rule that apr_err must be set to something that is defined by > >> APR or Subversion. > > Correct.

Re: [RFC, PATCH] RA context abstraction layer in libsvn_client

2013-07-10 Thread Ivan Zhakov
On Sat, Jun 15, 2013 at 3:34 PM, Ivan Zhakov wrote: > On Tue, Jun 11, 2013 at 3:22 PM, Ivan Zhakov wrote: >> Hi, >> >> Currently Subversion client layer creates new RA session for every >> svn_client_* call. Even more: for some operations like >> svn_client_merge() it creates 10-15 RA sessions. E

Re: svn commit: r1501049 - in /subversion/trunk/subversion: include/svn_error_codes.h libsvn_ra_serf/util_error.c

2013-07-10 Thread 'Daniel Shahaf'
Bert Huijben wrote on Tue, Jul 09, 2013 at 16:47:36 +0200: > Api users like those explicit error codes... and looking up the chain is not > without errors; loses information etc. Not in this case. Given ERR, you would only look in err->child->apr_err (not in err->child->...->child->apr_err), and

Re: svn commit: r1501371 - /subversion/trunk/subversion/libsvn_ra_serf/util_error.c

2013-07-10 Thread Daniel Shahaf
Bert Huijben wrote on Tue, Jul 09, 2013 at 23:00:31 +0200: > But note that the original patch this discussion started with, did > exactly the opposite: It decoupled the message and the error code, > which made svn produce the warning that it didn't understand the > error. > > So: how about agree-i

Re: Typo in CHANGES for r1494287 for upcoming 1.8.1

2013-07-10 Thread Ben Reser
On Wed, Jul 10, 2013 at 5:56 AM, Konstantin Kolinko wrote: > In the following file > https://svn.apache.org/repos/asf/subversion/trunk/CHANGES > > there is a typo on the following line in the list of changes for Version > 1.8.1: > > * fix 'svnadmin upgrade' error of non-shared fsfs repositories

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Greg Stein
On Wed, Jul 10, 2013 at 4:20 AM, Branko Čibej wrote: >... > Taking the "the client MAY ..." literally, we're compliant ... but > there's something to be said about about following the spirit of the > spec as well as the letter. You're the one debating compliance. > I wouldn't really mind breakin

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Greg Stein
On Wed, Jul 10, 2013 at 7:50 AM, Johan Corveleyn wrote: > On Wed, Jul 10, 2013 at 1:24 PM, Philip Martin > wrote: >> Johan Corveleyn writes: >> >>> Can someone explain again why ra_serf / serf can't just resend >>> requests, with C-L, whenever it has received a 411? So (after we know >>> it's HT

Typo in CHANGES for r1494287 for upcoming 1.8.1

2013-07-10 Thread Konstantin Kolinko
Hi! In the following file https://svn.apache.org/repos/asf/subversion/trunk/CHANGES there is a typo on the following line in the list of changes for Version 1.8.1: * fix 'svnadmin upgrade' error of non-shared fsfs repositories (r1494287) 1) s/ non-shared / non-sharded / 2) s/ r1494287 / r14948

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Johan Corveleyn
On Wed, Jul 10, 2013 at 1:24 PM, Philip Martin wrote: > Johan Corveleyn writes: > >> Can someone explain again why ra_serf / serf can't just resend >> requests, with C-L, whenever it has received a 411? So (after we know >> it's HTTP/1.1) send every request optimistically assuming chunked >> enco

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Philip Martin
Johan Corveleyn writes: > Can someone explain again why ra_serf / serf can't just resend > requests, with C-L, whenever it has received a 411? So (after we know > it's HTTP/1.1) send every request optimistically assuming chunked > encoding, and fallback whenever we get a 411 (and perhaps remember

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Johan Corveleyn
On Tue, Jul 9, 2013 at 7:33 PM, Ben Reser wrote: > On Tue, Jul 9, 2013 at 1:25 AM, Stefan Sperling wrote: >> On Tue, Jul 09, 2013 at 12:45:49AM -0700, Ben Reser wrote: >>> The option doesn't seem like a big barrier when you're applying it to >>> a handful of machines for yourself. Scale that eff

Re: build-svn-deps-win.pl and debug builds

2013-07-10 Thread Ben Reser
On Tue, Jul 9, 2013 at 4:41 PM, Ben Reser wrote: > On Tue, Jul 9, 2013 at 1:44 PM, Johan Corveleyn wrote: >> It would be interesting if build-svn-deps-win.pl could also build >> debug builds of the dependencies (so I can use them to make a debug >> build of svn). > > Agreed this was on my todo li

Re: subversion.apache.org/docs/swig-py ? Re: Perl bindings docstrings Re: svn commit: r1488693 - /subversion/trunk/subversion/bindings/swig/perl/native/Client.pm

2013-07-10 Thread Roderich Schupp
On Tue, Jul 9, 2013 at 4:37 PM, Daniel Shahaf wrote: > Separately, is there a reason the compiled swig-* docs aren't online on > http://subversion.apache.org/docs/, alongside the C and javahl ones? At > least the Perl ones are on CPAN[1], > [1] > http://search.cpan.org/~mschwern/Alien-SVN-v1.7.3.

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Lieven Govaerts
On Wed, Jul 10, 2013 at 10:41 AM, Branko Čibej wrote: > On 10.07.2013 10:20, Branko Čibej wrote: >> On 10.07.2013 05:43, Greg Stein wrote: >>> On Tue, Jul 9, 2013 at 10:50 PM, Branko Čibej wrote: On 09.07.2013 05:53, Greg Stein wrote: ... > For *this* project, that is absolutely the

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Branko Čibej
On 10.07.2013 10:20, Branko Čibej wrote: > On 10.07.2013 05:43, Greg Stein wrote: >> On Tue, Jul 9, 2013 at 10:50 PM, Branko Čibej wrote: >>> On 09.07.2013 05:53, Greg Stein wrote: >>> ... For *this* project, that is absolutely the case. We have never said "let's work against any server

Re: svn commit: r1495419 - in /subversion/trunk/subversion/libsvn_ra_serf: options.c ra_serf.h serf.c util.c

2013-07-10 Thread Branko Čibej
On 10.07.2013 05:43, Greg Stein wrote: > On Tue, Jul 9, 2013 at 10:50 PM, Branko Čibej wrote: >> On 09.07.2013 05:53, Greg Stein wrote: >> ... >>> For *this* project, that is absolutely the case. We have never said >>> "let's work against any server anybody decides to implement." We write >>> to o