Re: forbidding control characters prohibition in libsvn_repos in 1.7.10 (issue #4340)

On Sat, May 11, 2013 at 03:03:50AM +0200, Stefan Sperling wrote: > You also said this in STATUS: > "FSFS escape_newline should escape any control character, not just '\n'" Nevermind. escape_newline() is the function that performs cosmetic transformation of a path for an error message. I was confus

RE: forbidding control characters prohibition in libsvn_repos in 1.7.10 (issue #4340)

> -Original Message- > From: Daniel Shahaf [mailto:danie...@elego.de] > Sent: zaterdag 11 mei 2013 01:06 > To: C. Michael Pilato > Cc: dev@subversion.apache.org > Subject: Re: forbidding control characters prohibition in libsvn_repos in 1.7.10 > (issue #4340) > > C. Michael Pilato wrote

Re: forbidding control characters prohibition in libsvn_repos in 1.7.10 (issue #4340)

C. Michael Pilato wrote on Fri, May 10, 2013 at 18:19:56 -0400: > On 05/10/2013 04:51 PM, Daniel Shahaf wrote: > > For issue #4340, we decided to block filenames containing \n in FSFS and > > filenames containing control characters in libsvn_repos. (I agree with > > that decision.) > > > > Howeve

Re: Problems building trunk (and probably 1.8.x) on FreeBSD 9.0

Ben Reser wrote on Fri, May 10, 2013 at 13:55:16 -0700: > The problem is that FreeBSD's `apu-1-config --includes` has > -I/usr/local/include included in the output (which is where > sqlite3ext.h is installed). I'm not sure what the precise reason for > this is but I'm assuming there's some legit r

Re: forbidding control characters prohibition in libsvn_repos in 1.7.10 (issue #4340)

On 05/10/2013 04:51 PM, Daniel Shahaf wrote: > For issue #4340, we decided to block filenames containing \n in FSFS and > filenames containing control characters in libsvn_repos. (I agree with > that decision.) > > However, those changes are now nominated for backport towards 1.7.10 in > 1.7.x/ST

Problems building trunk (and probably 1.8.x) on FreeBSD 9.0

I was trying to build trunk on some ASF Infrastructure machines that have FreeBSD 9.0 on them. I ran into the following error: [[[ /bin/sh /home/breser/trunk/libtool --tag=CC --silent --mode=compile gcc -std=c89 -g -O2 -g -O2 -I./subversion/include -I./subversion -I/usr/local/include/apr-1 -

forbidding control characters prohibition in libsvn_repos in 1.7.10 (issue #4340)

For issue #4340, we decided to block filenames containing \n in FSFS and filenames containing control characters in libsvn_repos. (I agree with that decision.) However, those changes are now nominated for backport towards 1.7.10 in 1.7.x/STATUS, and I voted -0 on them, saying that "[the new] libs

Re: 1.8.0-rc1 up for testing/signing

On Fri, May 10, 2013 at 2:29 PM, Mark Phippard wrote: > On Fri, May 10, 2013 at 12:43 PM, Ben Reser wrote: >> On Wed, May 8, 2013 at 9:40 AM, Mark Phippard wrote: >>> I am using a new build process and using VS 2012, so I am sure that is >>> the problem. But I am getting 49 test failures. I am

Re: 1.8.0-rc1 up for testing/signing

On Fri, May 10, 2013 at 12:43 PM, Ben Reser wrote: > On Wed, May 8, 2013 at 9:40 AM, Mark Phippard wrote: >> I am using a new build process and using VS 2012, so I am sure that is >> the problem. But I am getting 49 test failures. I am attaching the >> fails.log but I do not think it lends much

Re: Would like to add file to contrib/hook-scripts

On Fri, May 10, 2013 at 7:31 AM, Rice, Kevin (Contractor) wrote: > I’d like to add a hook script to contrib, one that I’ve written, I’ve used > before, and is handy. > > Please advise how to go about submitting this. > > There seems to be no documentation on how to submit these scripts. > > I’d re

Re: [PATCH] Add contrib/hook-scripts pre-commit for python requiring tabs and svn properties

On Fri, May 10, 2013 at 11:11 AM, Daniel Shahaf wrote: > Rice, Kevin (Contractor) wrote on Fri, May 10, 2013 at 15:48:38 +: >> This message, including any attachments, is the property of Sears > ... >> without reading the contents. Thank you. > > Please nuke these footers when emailing public

Re: Thread issues in svnserve

On Fri, May 10, 2013 at 1:16 PM, Philip Martin wrote: > Ivan Zhakov writes: > >> Another way add some kind of svn__shared_pool_t with atomic reference >> counter and destroying attached pool when counter reaches zero. >> >> Something like this: > > An implementation of your idea: > > Index: subve

Re: [PATCH] Add contrib/hook-scripts pre-commit for python requiring tabs and svn properties

Rice, Kevin (Contractor) wrote on Fri, May 10, 2013 at 15:48:38 +: > [[[ > Add contrib/hook-scripts/precommit-pyfiles-notabs-properties.py > > Functions as a pre-commit hook script that does several things: > * prevents committing any python file containing a tab character > * checks i

[PATCH] Add contrib/hook-scripts pre-commit for python requiring tabs and svn properties

[[[ Add contrib/hook-scripts/precommit-pyfiles-notabs-properties.py Functions as a pre-commit hook script that does several things: * prevents committing any python file containing a tab character * checks if there are tabs in the source file and warns if so * aborts if incorrect prope

Would like to add file to contrib/hook-scripts

Hello: I'd like to add a hook script to contrib, one that I've written, I've used before, and is handy. Please advise how to go about submitting this. There seems to be no documentation on how to submit these scripts. I'd recommend putting a file named 'How2contribute' into the contrib directory

Re: 1.8.0-rc1 up for testing/signing

On 10.05.2013 18:56, Mark Phippard wrote: > On Fri, May 10, 2013 at 12:50 PM, Branko Čibej wrote: >> On 10.05.2013 18:47, Mark Phippard wrote: >>> FWIW, I do not agree with you on the syntax though. file:///foo Has >>> always worked on Windows to access C:\foo The drive letter was only >>> needed

Re: 1.8.0-rc1 up for testing/signing

On Fri, May 10, 2013 at 12:50 PM, Branko Čibej wrote: > On 10.05.2013 18:47, Mark Phippard wrote: >> FWIW, I do not agree with you on the syntax though. file:///foo Has >> always worked on Windows to access C:\foo The drive letter was only >> needed to access other drives. > > Well ... file:///foo

Re: 1.8.0-rc1 up for testing/signing

On 10.05.2013 18:47, Mark Phippard wrote: > FWIW, I do not agree with you on the syntax though. file:///foo Has > always worked on Windows to access C:\foo The drive letter was only > needed to access other drives. Well ... file:///foo is converted to (local) path \foo wich is a drive-relative pat

Re: 1.8.0-rc1 up for testing/signing

On Fri, May 10, 2013 at 12:33 PM, Branko Čibej wrote: > On 10.05.2013 18:22, Mark Phippard wrote: >> On Fri, May 10, 2013 at 11:42 AM, Mark Phippard wrote: >>> On Wed, May 8, 2013 at 12:40 PM, Mark Phippard wrote: I am using a new build process and using VS 2012, so I am sure that is t

Re: 1.8.0-rc1 up for testing/signing

On 10.05.2013 18:44, C. Michael Pilato wrote: > On 05/10/2013 11:18 AM, Philip Martin wrote: >> "C. Michael Pilato" writes: >> >>> I removed the system-installed APR and APR-Util. Still seeing the problem. >>> I'm a bit confused because the library appears (via ldd, at least) to be >>> linking a

Re: 1.8.0-rc1 up for testing/signing

On 05/10/2013 11:18 AM, Philip Martin wrote: > "C. Michael Pilato" writes: > >> I removed the system-installed APR and APR-Util. Still seeing the problem. >> I'm a bit confused because the library appears (via ldd, at least) to be >> linking against the correct apr-util (and was doing so before

Re: 1.8.0-rc1 up for testing/signing

On Wed, May 8, 2013 at 9:40 AM, Mark Phippard wrote: > I am using a new build process and using VS 2012, so I am sure that is > the problem. But I am getting 49 test failures. I am attaching the > fails.log but I do not think it lends much ideas. I tried running > with --verbose but the output

Re: 1.8.0-rc1 up for testing/signing

On 10.05.2013 18:22, Mark Phippard wrote: > On Fri, May 10, 2013 at 11:42 AM, Mark Phippard wrote: >> On Wed, May 8, 2013 at 12:40 PM, Mark Phippard wrote: >>> I am using a new build process and using VS 2012, so I am sure that is >>> the problem. But I am getting 49 test failures. I am attachi

Re: 1.8.0-rc1 up for testing/signing

On Fri, May 10, 2013 at 11:42 AM, Mark Phippard wrote: > On Wed, May 8, 2013 at 12:40 PM, Mark Phippard wrote: >> I am using a new build process and using VS 2012, so I am sure that is >> the problem. But I am getting 49 test failures. I am attaching the >> fails.log but I do not think it lends

Re: 1.8.0-rc1 up for testing/signing

"C. Michael Pilato" writes: > I removed the system-installed APR and APR-Util. Still seeing the problem. > I'm a bit confused because the library appears (via ldd, at least) to be > linking against the correct apr-util (and was doing so before I removed the > system-install versions, even). Th

Re: Releasing 1.7.10

On Fri, May 10, 2013 at 05:32:05PM +0200, Branko Čibej wrote: > RC-1 was effectively vetoed by the svnserve threading problems which are > being actively fixed now. We cannot release that tarball. Ah, I wasn't aware of that. I thought we were still going to release that tarball anyway. > > Are yo

Re: 1.8.0-rc1 up for testing/signing

On Wed, May 8, 2013 at 12:40 PM, Mark Phippard wrote: > I am using a new build process and using VS 2012, so I am sure that is > the problem. But I am getting 49 test failures. I am attaching the > fails.log but I do not think it lends much ideas. I tried running > with --verbose but the output

Re: Releasing 1.7.10

On 10.05.2013 17:28, Stefan Sperling wrote: > On Fri, May 10, 2013 at 05:17:47PM +0200, Branko Čibej wrote: >> On 10.05.2013 16:32, Stefan Sperling wrote: >>> The STATUS file on 1.7.x contains a lot of entries. >>> There is one critical issue (the \n problem with FSFS) that I would >>> like to rele

Re: Backporting changes in renamed files to 1.7

On Fri, May 10, 2013 at 11:23 AM, Stefan Sperling wrote: > On Fri, May 10, 2013 at 04:14:36PM +0100, Philip Martin wrote: >> The 1.7 files >> >>subversion/svn/main.c >>subversion/svnserve/main.c >> >> were renamed in 1.8 to >> >>subversion/svn/svn.c >>subversion/svnserve/svnserve.c

Re: Releasing 1.7.10

On Fri, May 10, 2013 at 05:17:47PM +0200, Branko Čibej wrote: > On 10.05.2013 16:32, Stefan Sperling wrote: > > The STATUS file on 1.7.x contains a lot of entries. > > There is one critical issue (the \n problem with FSFS) that I would > > like to release a fix for ASAP. > > > > I'd be happy to dri

Re: 1.8.0-rc1 up for testing/signing

"C. Michael Pilato" writes: > I removed the system-installed APR and APR-Util. Still seeing the problem. > I'm a bit confused because the library appears (via ldd, at least) to be > linking against the correct apr-util (and was doing so before I removed the > system-install versions, even). Tr

Re: Backporting changes in renamed files to 1.7

On Fri, May 10, 2013 at 04:14:36PM +0100, Philip Martin wrote: > The 1.7 files > >subversion/svn/main.c >subversion/svnserve/main.c > > were renamed in 1.8 to > >subversion/svn/svn.c >subversion/svnserve/svnserve.c > > and this causes conflicts when backporting changes from trun

Re: Releasing 1.7.10

On Fri, May 10, 2013 at 11:17 AM, Branko Čibej wrote: > On 10.05.2013 16:32, Stefan Sperling wrote: >> The STATUS file on 1.7.x contains a lot of entries. >> There is one critical issue (the \n problem with FSFS) that I would >> like to release a fix for ASAP. >> >> I'd be happy to drive the relea

Re: Releasing 1.7.10

On 10.05.2013 16:32, Stefan Sperling wrote: > The STATUS file on 1.7.x contains a lot of entries. > There is one critical issue (the \n problem with FSFS) that I would > like to release a fix for ASAP. > > I'd be happy to drive the release process for 1.7.10, and would roll > a tarball next Thursda

Re: issues dump ?

On 10.05.2013 16:21, Lieven Govaerts wrote: > > > On Fri, May 10, 2013 at 2:06 AM, Branko Čibej > wrote: > > On 10.05.2013 01:08, Ben Reser wrote: > > On Thu, May 9, 2013 at 4:04 PM, Daniel Shahaf > mailto:d...@daniel.shahaf.name>> wrote: > >> Can we get

Backporting changes in renamed files to 1.7

The 1.7 files subversion/svn/main.c subversion/svnserve/main.c were renamed in 1.8 to subversion/svn/svn.c subversion/svnserve/svnserve.c and this causes conflicts when backporting changes from trunk. On the branch 1.7.x-r1475724 this was resolved by doing a subtree merge and thus

Releasing 1.7.10

The STATUS file on 1.7.x contains a lot of entries. There is one critical issue (the \n problem with FSFS) that I would like to release a fix for ASAP. I'd be happy to drive the release process for 1.7.10, and would roll a tarball next Thursday or Friday. This would leave about one week for additi

Re: issues dump ?

On Fri, May 10, 2013 at 2:06 AM, Branko Čibej wrote: > On 10.05.2013 01:08, Ben Reser wrote: > > On Thu, May 9, 2013 at 4:04 PM, Daniel Shahaf > wrote: > >> Can we get a periodic data dump of subversion.tigris.org/issues/ onto > >> ASF hardware? > > Drive by comment here but we should probably s

Re: issues dump ?

C. Michael Pilato wrote on Fri, May 10, 2013 at 09:07:12 -0400: > On 05/09/2013 07:04 PM, Daniel Shahaf wrote: > > Can we get a periodic data dump of subversion.tigris.org/issues/ onto > > ASF hardware? > > > > Not because we need to migrate from tigris, but because we need to have > > our own bac

Re: 1.8.0-rc1 up for testing/signing

On 05/07/2013 08:23 AM, Branko Čibej wrote: > On 07.05.2013 14:06, C. Michael Pilato wrote: >> My guess is also that the build was picking up the older system >> apr-util version, but I haven't been able to verify that yet. > > All I can suggest (assuming you're on Linux) is to check the RPATH >

Re: issues dump ?

Mark Phippard wrote on Fri, May 10, 2013 at 09:40:19 -0400: > OK, here is an easy example. This gets the task data for Issue 4365. > > http://subversion.tigris.org/issues/xml.cgi?include_attachments=false&id=4365 > > You will see the XML contains the information about the attachments, > so it wo

Re: issues dump ?

On 10.05.2013 15:40, Mark Phippard wrote: > On Fri, May 10, 2013 at 9:20 AM, Mark Phippard wrote: >> On Fri, May 10, 2013 at 9:07 AM, C. Michael Pilato >> wrote: >>> On 05/09/2013 07:04 PM, Daniel Shahaf wrote: Can we get a periodic data dump of subversion.tigris.org/issues/ onto ASF h

Re: issues dump ?

On Fri, May 10, 2013 at 9:20 AM, Mark Phippard wrote: > On Fri, May 10, 2013 at 9:07 AM, C. Michael Pilato > wrote: >> On 05/09/2013 07:04 PM, Daniel Shahaf wrote: >>> Can we get a periodic data dump of subversion.tigris.org/issues/ onto >>> ASF hardware? >>> >>> Not because we need to migrate f

Re: issues dump ?

On Fri, May 10, 2013 at 9:07 AM, C. Michael Pilato wrote: > On 05/09/2013 07:04 PM, Daniel Shahaf wrote: >> Can we get a periodic data dump of subversion.tigris.org/issues/ onto >> ASF hardware? >> >> Not because we need to migrate from tigris, but because we need to have >> our own backup of our

Re: issues dump ?

On 05/10/2013 09:07 AM, C. Michael Pilato wrote: > On 05/09/2013 07:04 PM, Daniel Shahaf wrote: >> Can we get a periodic data dump of subversion.tigris.org/issues/ onto >> ASF hardware? >> >> Not because we need to migrate from tigris, but because we need to have >> our own backup of our data. (Ye

Re: issues dump ?

On 05/09/2013 07:04 PM, Daniel Shahaf wrote: > Can we get a periodic data dump of subversion.tigris.org/issues/ onto > ASF hardware? > > Not because we need to migrate from tigris, but because we need to have > our own backup of our data. (Yes, there is the issues@ history, but, > besides it is n

Re: Thread issues in svnserve

Ivan Zhakov writes: > Another way add some kind of svn__shared_pool_t with atomic reference > counter and destroying attached pool when counter reaches zero. > > Something like this: An implementation of your idea: Index: subversion/svnserve/svnserve.c ==

Re: issues dump ?

On Fri, May 10, 2013 at 02:15:23AM +0300, Daniel Shahaf wrote: > Or Allura (incubating). Hmm, I don't think we need a full-blown forge system. I think bloodhound is better suited for our needs. Bloodhound itself might also benefit more from having us as regular users than Allura would. There alre

Re: issues dump ?

On Thu, May 09, 2013 at 04:08:57PM -0700, Ben Reser wrote: > Drive by comment here but we should probably spend some time and > migrate this to Bloodhound. very much +1