Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Daniel Shahaf
Gabriela Gibson wrote on Tue, Feb 19, 2013 at 22:37:35 +: > On 19/02/13 13:06, Daniel Shahaf wrote: >> I see. The interesting part is that I asked about >> AddOutputFilter INCLUDES .html >> because httpd.conf has it enabled for us specifically. I Also tested by >> hand and confirmed that

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Daniel Shahaf
Shivani Poddar wrote on Wed, Feb 20, 2013 at 04:00:34 +0530: > On Wed, Feb 20, 2013 at 2:41 AM, Daniel Shahaf wrote: > > > Shivani Poddar wrote on Wed, Feb 20, 2013 at 00:28:41 +0530: > > > On Tue, Feb 19, 2013 at 11:55 PM, Ben Reser wrote: > > > > > > > On Sat, Feb 16, 2013 at 4:26 AM, Shivani P

[PATCH] swig-py: Adding tests for svn_checksum_dup() and svn_checksum_match()

2013-02-19 Thread Shivani Poddar
[ [ [ Improving support for svn_checksum.h in SWIG bindings. * subversion/bindings/swig/python/tests/checksum.py: "swig-py: Adding tests for svn_checksum_dup() and svn_checksum_match()" Patch by: Shivani Poddar Review by : breser ] ] ] Regards, Shivani Poddar, irc-nik -> trinity_28 I

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Shivani Poddar
On Wed, Feb 20, 2013 at 4:31 AM, Ben Reser wrote: > On Tue, Feb 19, 2013 at 2:33 PM, Shivani Poddar > wrote: > > I see. I did run an 'svn update' on my working copy before making any new > > changed this time around. > > Maybe i'll recheck the diff yes. > > If Subversion can apply the changes (o

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Ben Reser
On Tue, Feb 19, 2013 at 2:33 PM, Shivani Poddar wrote: > I see. I did run an 'svn update' on my working copy before making any new > changed this time around. > Maybe i'll recheck the diff yes. If Subversion can apply the changes (or at least thinks it can) without creating a conflict it will do

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Gabriela Gibson
On 19/02/13 13:06, Daniel Shahaf wrote: I see. The interesting part is that I asked about AddOutputFilter INCLUDES .html because httpd.conf has it enabled for us specifically. I Also tested by hand and confirmed that /www/subversion.apache.org/index2.html has SSI directives parsed even if

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Shivani Poddar
On Wed, Feb 20, 2013 at 3:04 AM, Ben Reser wrote: > On Tue, Feb 19, 2013 at 10:58 AM, Shivani Poddar > wrote: > > Maybe writing "adding tests for svn_checksum_dup() function in > > svn_checksum.h would be the correct thing to do. > > Yes. I'd probably say something like "swig-py: Adding tests f

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Shivani Poddar
On Wed, Feb 20, 2013 at 2:41 AM, Daniel Shahaf wrote: > Shivani Poddar wrote on Wed, Feb 20, 2013 at 00:28:41 +0530: > > On Tue, Feb 19, 2013 at 11:55 PM, Ben Reser wrote: > > > > > On Sat, Feb 16, 2013 at 4:26 AM, Shivani Poddar > > > wrote: > > > > [ [ [ > > > > > > > > Improving support for s

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Ben Reser
On Tue, Feb 19, 2013 at 10:58 AM, Shivani Poddar wrote: > Maybe writing "adding tests for svn_checksum_dup() function in > svn_checksum.h would be the correct thing to do. Yes. I'd probably say something like "swig-py: Adding tests for svn_checksum_dup()" > Since in the earlier patches we had L

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Daniel Shahaf
Shivani Poddar wrote on Wed, Feb 20, 2013 at 00:28:41 +0530: > On Tue, Feb 19, 2013 at 11:55 PM, Ben Reser wrote: > > > On Sat, Feb 16, 2013 at 4:26 AM, Shivani Poddar > > wrote: > > > [ [ [ > > > > > > Improving support for svn_checksum.h in SWIG bindings. > > > > This isn't how I'd word this c

Re: [PATCH] mailer.py: Add Date and Message ID headers

2013-02-19 Thread Daniel Shahaf
Peelman, Nick wrote on Tue, Feb 19, 2013 at 13:59:59 -0500: > Using both sendmail and an internal SMTP server (postfix), neither the > date nor message ID would get inserted; that said, the foreign MTA > would spawn a message-ID and a date. > OK. Fair enough. I'm convinced that these headers s

Re: [PATCH] mailer.py: Add Date and Message ID headers

2013-02-19 Thread Peelman, Nick
Using both sendmail and an internal SMTP server (postfix), neither the date nor message ID would get inserted; that said, the foreign MTA would spawn a message-ID and a date. However: As per RFC2822, the Date field is one of only two required fields for a valid message; relying on the MTA to

Re: [PATCH] mailer.py: Add Date and Message ID headers

2013-02-19 Thread Ben Reser
On Tue, Feb 19, 2013 at 10:15 AM, Daniel Shahaf wrote: > Peelman, Nick wrote on Tue, Feb 19, 2013 at 13:13:28 -0500: >> Adds a Date header and a Message-ID with the revision property embedded at >> the end. > > Why is this necessary? Can you describe a setup in which Date or > Message-ID are not

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Shivani Poddar
On Tue, Feb 19, 2013 at 11:55 PM, Ben Reser wrote: > On Sat, Feb 16, 2013 at 4:26 AM, Shivani Poddar > wrote: > > [ [ [ > > > > Improving support for svn_checksum.h in SWIG bindings. > > This isn't how I'd word this commit description. You haven't actually > improved support at all with this pa

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Ben Reser
On Tue, Feb 19, 2013 at 10:09 AM, Daniel Shahaf wrote: > How so? If the proxy caches the master version per-process or > per-connection, it won't need to be restarted to notice master upgrades, > will it? Per-connection would be fine but based on the discussion in the thread I was presuming per-

Re: Resolving conflicts during merge - could not postpone all

2013-02-19 Thread Ben Reser
On Mon, Feb 18, 2013 at 10:36 AM, Mark Phippard wrote: > My "trunk" working copy had the WC upgraded by running the JavaHL test > suite. I can live with it, but it means I have to change PATH before > updating my WC. I've been doing this for a long time now, but for > some reason sometimes I get

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Ben Reser
On Tue, Feb 19, 2013 at 5:06 AM, Daniel Shahaf wrote: > I see. The interesting part is that I asked about > AddOutputFilter INCLUDES .html > because httpd.conf has it enabled for us specifically. I Also tested by > hand and confirmed that /www/subversion.apache.org/index2.html has SSI > dire

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Philip Martin
Ben Reser writes: > On Tue, Feb 19, 2013 at 8:03 AM, Philip Martin > wrote: >> When the client sends the OPTIONS request to the proxy mod_dav calls >> into mod_dav_svn/version.c:get_option. Is it possible for mod_dav_svn >> to send an OPTIONS request to the master at that stage? I suppose >> t

Re: [PATCH] Improve support for svn_checksum.h in SWIG bindings for python

2013-02-19 Thread Ben Reser
On Sat, Feb 16, 2013 at 4:26 AM, Shivani Poddar wrote: > [ [ [ > > Improving support for svn_checksum.h in SWIG bindings. This isn't how I'd word this commit description. You haven't actually improved support at all with this patch, but rather you've added tests for a function that already works

Re: [PATCH] mailer.py: Add Date and Message ID headers

2013-02-19 Thread Daniel Shahaf
Peelman, Nick wrote on Tue, Feb 19, 2013 at 13:13:28 -0500: > Adds a Date header and a Message-ID with the revision property embedded at > the end. Why is this necessary? Can you describe a setup in which Date or Message-ID are not added? (I assume usually the MTA would add them if they're miss

[PATCH] mailer.py: Add Date and Message ID headers

2013-02-19 Thread Peelman, Nick
Adds a Date header and a Message-ID with the revision property embedded at the end. -nick -- Peelman, Nick n...@peelman.us mailer.py.diff Description: Binary data smime.p7s Description: S/MIME cryptographic signature

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Daniel Shahaf
Ben Reser wrote on Tue, Feb 19, 2013 at 09:22:13 -0800: > On Tue, Feb 19, 2013 at 8:03 AM, Philip Martin > wrote: > > When the client sends the OPTIONS request to the proxy mod_dav calls > > into mod_dav_svn/version.c:get_option. Is it possible for mod_dav_svn > > to send an OPTIONS request to th

Re: [PATCH] Small fixes to the Perl bindings

2013-02-19 Thread Ben Reser
On Sun, Feb 17, 2013 at 2:53 PM, Roderich Schupp wrote: > I used swig 2.0.9, but the change happened from 2.0.4 to 2.0.5. > A quick "git bisect" puts the blame on > https://github.com/swig/swig/commit/30206f975c3c3fbd6e702499727375b4321b490e > "Fix constructors in named typedef class declarations"

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Ben Reser
On Tue, Feb 19, 2013 at 8:03 AM, Philip Martin wrote: > When the client sends the OPTIONS request to the proxy mod_dav calls > into mod_dav_svn/version.c:get_option. Is it possible for mod_dav_svn > to send an OPTIONS request to the master at that stage? I suppose > that's a not quite the same a

Re: exclusive WC locks by default? (was: Re: svn commit: r1447487 - /subversion/trunk/subversion/svn/svn.c)

2013-02-19 Thread Ben Reser
On Mon, Feb 18, 2013 at 7:18 PM, Justin Erenkrantz wrote: > +1 - "svn diff" while running "svn commit" (blocking waiting for $EDITOR to > exit) is my SOP as well. If we break that by default, I consider it a > regression. -- justin +1

Re: Gsoc 2013 Project

2013-02-19 Thread Daniel Shahaf
On Tue, Feb 19, 2013 at 09:50:27PM +0530, Chetna Gupta wrote: > Hey People, > I am completely new to open source development, but i seriously wana > contribute towards OSD projects. Can someone please guide me, or mentor me > while i take my first step towards Open source Hi Chetna. This kind of

Re: Gsoc 2013 Project

2013-02-19 Thread Chetna Gupta
Hey People, I am completely new to open source development, but i seriously wana contribute towards OSD projects. Can someone please guide me, or mentor me while i take my first step towards Open source Thanks On Tue, Feb 19, 2013 at 6:49 PM, Abhishek Singh < abhishekkumarsingh@gmail.com> wro

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Philip Martin
Mark Phippard writes: > I guess it would be nice if mod_dav_svn could do this probing itself > upon startup or something and then cache it. Obviously it cannot do > it as part of the actual proxying as that would be too late. When the client sends the OPTIONS request to the proxy mod_dav calls

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Mark Phippard
On Tue, Feb 19, 2013 at 10:43 AM, Daniel Shahaf wrote: >> We needed this information in Subversion Edge so that we could >> configure a slave correctly. In our case, we only knew the master was >> either running 1.6 or 1.7 so we just send the master an HTTP request >> to figure out if it support

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Daniel Shahaf
Mark Phippard wrote on Tue, Feb 19, 2013 at 10:24:03 -0500: > On Tue, Feb 19, 2013 at 9:09 AM, Daniel Shahaf wrote: > > Reviving an old thread: has anyone evaluated the possibility of having the > > slave ask the master for its version at runtime? > > I have considered asking for that before, but

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Mark Phippard
On Tue, Feb 19, 2013 at 9:09 AM, Daniel Shahaf wrote: > Reviving an old thread: has anyone evaluated the possibility of having the > slave ask the master for its version at runtime? I have considered asking for that before, but I held off because if this were possible wouldn't that be considered

Re: WebDAV proxy feature "negotiation" -- there's *got* to be a better way.

2013-02-19 Thread Daniel Shahaf
Reviving an old thread: has anyone evaluated the possibility of having the slave ask the master for its version at runtime? Currently we require an "SVNMasterVersion 1.7" directive in the slave's httpd.conf, but the problem is that the value of that directive can get out of date as the master is u

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Daniel Shahaf
Gabriela Gibson wrote on Sun, Jan 20, 2013 at 11:57:13 +: > On 20/01/13 05:17, Daniel Shahaf wrote: >> Gabriela Gibson wrote on Sun, Jan 20, 2013 at 00:15:46 +: >>> On 03/01/13 04:34, Daniel Shahaf wrote: > + Enable Server Side Includes for the relevant DocumentRoot. The > +

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Gabriela Gibson
(this is a test, I hope this does not make it's own, new thread!) On 1/20/13, Gabriela Gibson wrote: > On 20/01/13 05:17, Daniel Shahaf wrote: >> Gabriela Gibson wrote on Sun, Jan 20, 2013 at 00:15:46 +: >>> On 03/01/13 04:34, Daniel Shahaf wrote: > + Enable Server Side Includes for the

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Daniel Shahaf
Gabriela Gibson wrote on Tue, Feb 19, 2013 at 12:35:16 +: > Sorry for the reply mess, I wish I could reply to my last post to the > thread, but I can't -- as Brane informs me, Google is discarding my > emails, so I have to see about another email account that isn't as > 'helpful' :) > I

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Branko Čibej
On 19.02.2013 13:35, Gabriela Gibson wrote: > On 20/01/13 05:17, Daniel Shahaf wrote: >> Gabriela Gibson wrote on Sun, Jan 20, 2013 at 00:15:46 +: >>> On 03/01/13 04:34, Daniel Shahaf wrote: > + Enable Server Side Includes for the relevant DocumentRoot. > The > + relevant Ap

Re: [PATCH] Procedure for making web page changes

2013-02-19 Thread Gabriela Gibson
On 20/01/13 05:17, Daniel Shahaf wrote: Gabriela Gibson wrote on Sun, Jan 20, 2013 at 00:15:46 +: On 03/01/13 04:34, Daniel Shahaf wrote: + Enable Server Side Includes for the relevant DocumentRoot. The + relevant Apache directive is: + Options +Include What about:

Re: svn commit: r1447487 - /subversion/trunk/subversion/svn/svn.c

2013-02-19 Thread Johan Corveleyn
On Tue, Feb 19, 2013 at 12:50 PM, Bert Huijben wrote: > > >> -Original Message- >> From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of >> Philip Martin >> Sent: dinsdag 19 februari 2013 11:50 >> To: Bert Huijben >> Cc: dev@subversion.apache.org >> Subject: Re: svn commit: r1

RE: svn commit: r1447487 - /subversion/trunk/subversion/svn/svn.c

2013-02-19 Thread Bert Huijben
> -Original Message- > From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of > Philip Martin > Sent: dinsdag 19 februari 2013 11:50 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1447487 - /subversion/trunk/subversion/svn/svn.c > > "Bert Huijb

Re: svn commit: r1447487 - /subversion/trunk/subversion/svn/svn.c

2013-02-19 Thread Branko Čibej
On 19.02.2013 11:49, Philip Martin wrote: > Users that mix the command line with GUIs can switch off exclusive > locking. If we switch the default then users that want performance > need to switch on exclusive locking. I don't know which group is > bigger, users who want performance or users who wa

Re: svn commit: r1447487 - /subversion/trunk/subversion/svn/svn.c

2013-02-19 Thread Philip Martin
"Bert Huijben" writes: >> + This blocks every other application from accessing our wc.db at the >> same >> + time as this process. So instead of using the working copy lock >> functions >> + as designed other processes will already block before being able to >> check >> + that

Re: exclusive WC locks by default? (was: Re: svn commit: r1447487 - /subversion/trunk/subversion/svn/svn.c)

2013-02-19 Thread Daniel Shahaf
Justin Erenkrantz wrote on Mon, Feb 18, 2013 at 22:18:33 -0500: > +1 - "svn diff" while running "svn commit" (blocking waiting for $EDITOR to > exit) is my SOP as well. If we break that by default, I consider it a > regression. -- justin +1

Re: Bug in mailer.py

2013-02-19 Thread olli hauer
On 2013-02-19 07:44, Daniel Shahaf wrote: > Will this break any use-cases? (eg: do some people send commit mails to > mailing lists configured to reject Precedence:bulk inbound mails?) > > Would it be better to allow the user to set arbitrary headers? Example > UI for mailer.py.conf: > >[he