Re: svn commit: r1444956 - in /subversion/branches/fsfs-format7/subversion: libsvn_client/patch.c libsvn_fs_fs/fs.c libsvn_fs_fs/fs_fs.c libsvn_fs_fs/hotcopy.c libsvn_fs_fs/transaction.c libsvn_repos/

2013-02-11 Thread Ivan Zhakov
On Tue, Feb 12, 2013 at 11:21 AM, Stefan Fuhrmann wrote: > On Mon, Feb 11, 2013 at 10:03 PM, Bert Huijben wrote: >> >> >> >> > -Original Message- >> > From: stef...@apache.org [mailto:stef...@apache.org] >> > Sent: maandag 11 februari 2013 21:47 >> > To: comm...@subversion.apache.org >> >

Re: svn commit: r1444956 - in /subversion/branches/fsfs-format7/subversion: libsvn_client/patch.c libsvn_fs_fs/fs.c libsvn_fs_fs/fs_fs.c libsvn_fs_fs/hotcopy.c libsvn_fs_fs/transaction.c libsvn_repos/

2013-02-11 Thread Stefan Fuhrmann
On Mon, Feb 11, 2013 at 10:03 PM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: maandag 11 februari 2013 21:47 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1444956 - in /subversion/branches/fsfs- > > fo

Re: Perl bindings tests don't seem to work

2013-02-11 Thread Ben Reser
This should be fixed in r1444970. There's a deeper issue with the svn_opt_revision_t accessor methods that I haven't tracked down yet. I've commented the tests out that try to retrieve values from the svn_opt_revision_t fields for now till I managed to track that down.

RE: svn commit: r1444956 - in /subversion/branches/fsfs-format7/subversion: libsvn_client/patch.c libsvn_fs_fs/fs.c libsvn_fs_fs/fs_fs.c libsvn_fs_fs/hotcopy.c libsvn_fs_fs/transaction.c libsvn_repos/

2013-02-11 Thread Bert Huijben
> -Original Message- > From: stef...@apache.org [mailto:stef...@apache.org] > Sent: maandag 11 februari 2013 21:47 > To: comm...@subversion.apache.org > Subject: svn commit: r1444956 - in /subversion/branches/fsfs- > format7/subversion: libsvn_client/patch.c libsvn_fs_fs/fs.c > libsvn_fs_

Re: Global replace: apr_hash_get/set(APR_HASH_KEY_STRING) -> svn_hash_get/set()

2013-02-11 Thread Stefan Fuhrmann
On Mon, Feb 11, 2013 at 5:32 PM, Julian Foad wrote: > I just noticed that in r1443387, Bert added: > > > /* Shortcut for apr_hash_get() with a const char * key. > * > * @since New in 1.8. > */ > #define svn_hash_gets(ht, key) \ > apr_hash_get(ht, key, APR_HASH_KEY_STRING) > [...] >

Re: Perl bindings tests don't seem to work

2013-02-11 Thread Ben Reser
On Mon, Feb 11, 2013 at 5:15 AM, Philip Martin wrote: > Note that it checks externals[0] twice rather than checking externals[0] > and externals[1]. If I change the test to check externals[2] That's clearly an error on my part. > isa_ok($externals->[2], '_p_svn_wc_external_item2_t'); > > I get

Re: cannot install mod_dontdothat.la to a directory not ending in /home/.../lib/apache2/modules

2013-02-11 Thread Julian Foad
Philip Martin wrote: > Julian Foad writes: >> I am stuck at this point as I don't understand the installation >> process well enough. > > We have had similar problems on 1.7.x.  The problem is that the > build.conf entry > >   install = tools > > causes the module to be installed with LIBTOOL

Global replace: apr_hash_get/set(APR_HASH_KEY_STRING) -> svn_hash_get/set()

2013-02-11 Thread Julian Foad
I just noticed that in r1443387, Bert added: /* Shortcut for apr_hash_get() with a const char * key.  *  * @since New in 1.8.  */ #define svn_hash_gets(ht, key) \     apr_hash_get(ht, key, APR_HASH_KEY_STRING) [...] #define svn_hash_sets(ht, key, val) \     apr_hash_set(ht, key, A

Re: cannot install mod_dontdothat.la to a directory not ending in /home/.../lib/apache2/modules

2013-02-11 Thread Philip Martin
Julian Foad writes: > I am stuck at this point as I don't understand the installation > process well enough. We have had similar problems on 1.7.x. The problem is that the build.conf entry install = tools causes the module to be installed with LIBTOOL while it should be installed with APXS.

cannot install mod_dontdothat.la to a directory not ending in /home/.../lib/apache2/modules

2013-02-11 Thread Julian Foad
I am getting an error from 'make install-tools' on current trunk: [[[ $ (cd obj-dir && make install-tools) /usr/bin/install -c -d /home/.../bin/svn-tools cd tools/diff ; /bin/bash /.../libtool --mode=install /usr/bin/install -c diff /home/.../bin/svn-tools/diff libtool: install: /usr/bin/install

Re: [PATCH] Don't break 'make install-tools' if TOOLSDIR is same as BINDIR.

2013-02-11 Thread Julian Foad
Alexander Thomas wrote: > This originated from one of my requirement where svn* binaries and tools need > to > be installed in same location. > I'm not sure this one qualifies as a valid patch, because for this to happen > someone should tweaks Makefile.in > and points $bindir and $toolsdir to s

Perl bindings tests don't seem to work

2013-02-11 Thread Philip Martin
The test subversion/bindings/swig/perl/native/t/9wc.t was added recently, it's failing on the openbsd buildbot but passes on my Linux box. The test contains: # Check the first member of the returned array. # TEST isa_ok($externals->[0], '_p_svn_wc_external_item2_t'); # TEST ok($externals->[0]->tar

[PATCH] Don't break 'make install-tools' if TOOLSDIR is same as BINDIR.

2013-02-11 Thread Alexander Thomas
All, This originated from one of my requirement where svn* binaries and tools need to be installed in same location. I'm not sure this one qualifies as a valid patch, because for this to happen someone should tweaks Makefile.in and points $bindir and $toolsdir to same location. [[[ Don't brea

Re: PATCH: keyword expansion 1.8

2013-02-11 Thread Stefan Sperling
On Mon, Feb 11, 2013 at 09:38:05AM +, Philip Martin wrote: > Stefan Sperling writes: > > >> Index: subversion/include/private/svn_subst_private.h > >> === > >> --- subversion/include/private/svn_subst_private.h (revision 0) > >>

Re: PATCH: keyword expansion 1.8

2013-02-11 Thread Philip Martin
Stefan Sperling writes: >> Index: subversion/include/private/svn_subst_private.h >> === >> --- subversion/include/private/svn_subst_private.h (revision 0) >> +++ subversion/include/private/svn_subst_private.h (working copy) >> @@