Stefan Sperling <s...@elego.de> writes: >> Index: subversion/include/private/svn_subst_private.h >> =================================================================== >> --- subversion/include/private/svn_subst_private.h (revision 0) >> +++ subversion/include/private/svn_subst_private.h (working copy) >> @@ -0,0 +1,68 @@
>> + * @file svn_subst_private.h >> + * @brief Non-public subst utility functions. >> + */ >> + >> + >> +#ifndef SVN_SUBST_PRIVATE_H >> +#define SVN_SUBST_PRIVATE_H >> + >> +#include "svn_subst.h" /* for svn_boolean_t, svn_error_t */ >> + >> +#ifdef __cplusplus >> +extern "C" { >> +#endif /* __cplusplus */ >> + >> +/** >> + * Set @a *kw to a new keywords hash filled with the appropriate contents >> + * given a @a keywords_string (the contents of the svn:keywords >> + * property for the file in question), the revision @a rev, the @a url, >> + * the url of the root of the @a repos, the @a date the file was committed >> + * on, and the @a author of the last commit. Any of these can be @c NULL >> + * to indicate that the information is not present, or @c 0 for @a date. >> + * >> + * Hash keys are of type <tt>const char *</tt>. >> + * Hash values are of type <tt>svn_string_t *</tt>. >> + * >> + * All memory is allocated out of @a pool. >> + * >> + * @since New in 1.6 1.6 is wrong. >> + */ >> +svn_error_t * >> +svn_subst_build_keywords3(apr_hash_t **kw, >> + const char *keywords_string, >> + const char *rev, >> + const char *url, >> + const char *repos, >> + apr_time_t date, >> + const char *author, >> + apr_pool_t *pool); >> + Our private API uses a double underscore svn_subst__build_keywords3 however this is replacing a public API svn_subst_build_keywords2 declared in include/svn_subst.h. Is the intention to deprecate the entire svn_subst_build_keywords public API? Or is svn_subst_build_keywords3 intended to be the new public API? -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download