Re: disregarding svn:global-ignores

2012-11-05 Thread Daniel Shahaf
Paul Burba wrote on Mon, Nov 05, 2012 at 21:45:23 -0500: > On Mon, Nov 5, 2012 at 5:41 PM, Daniel Shahaf wrote: > > http://wiki.apache.org/subversion/Inheritable-Ignores-AutoProps#Ignores_.22Hierarchy.22 > > says 'svn status --no-ignore' does not disregard inherited > > 'svn:global-ignores' proper

Re: disregarding svn:global-ignores

2012-11-05 Thread Paul Burba
On Mon, Nov 5, 2012 at 5:41 PM, Daniel Shahaf wrote: > http://wiki.apache.org/subversion/Inheritable-Ignores-AutoProps#Ignores_.22Hierarchy.22 > says 'svn status --no-ignore' does not disregard inherited > 'svn:global-ignores' properties. Hi Daniel, Sorry, that section is out of date, I correcte

Re: Random serf checkout failures

2012-11-05 Thread Justin Erenkrantz
On Mon, Nov 5, 2012 at 1:33 PM, C. Michael Pilato wrote: > My debugging indicates that when close_all_dirs() is called, there are a > slew of unclosed directories which each have a non-zero ref_count. Save for > the root directory of the edit (/tags), fetch_props == TRUE, > propfind_handler->done

disregarding svn:global-ignores

2012-11-05 Thread Daniel Shahaf
http://wiki.apache.org/subversion/Inheritable-Ignores-AutoProps#Ignores_.22Hierarchy.22 says 'svn status --no-ignore' does not disregard inherited 'svn:global-ignores' properties. This breaks a use-case for me: % svn status --no-ignore | xargs rm -rf How, with a 1.8 client, would I obtain a compl

Re: Random serf checkout failures

2012-11-05 Thread C. Michael Pilato
On 11/05/2012 04:21 PM, Lieven Govaerts wrote: > Do you plan on patching this issue? If yes I can continue looking at > Philip's original issue in this thread - assuming it is not caused by > the memory leak. Thanks for the helpful cross-checking! Yes, I plan to continue looking into this issue.

Re: Random serf checkout failures

2012-11-05 Thread Lieven Govaerts
Hi Mike On Mon, Nov 5, 2012 at 9:39 PM, C. Michael Pilato wrote: > On 11/05/2012 01:33 PM, C. Michael Pilato wrote: >> On 11/05/2012 11:49 AM, Lieven Govaerts wrote: >>> My current test with svn trunk & apache+mod_dav_svn 1.6.12 does not >>> reproduce this issue. >>> >>> What I am seeing is that

Re: Random serf checkout failures

2012-11-05 Thread C. Michael Pilato
On 11/05/2012 01:33 PM, C. Michael Pilato wrote: > On 11/05/2012 11:49 AM, Lieven Govaerts wrote: >> My current test with svn trunk & apache+mod_dav_svn 1.6.12 does not >> reproduce this issue. >> >> What I am seeing is that svn is using a lot of memory, up to 1GB. >> Currently looking at the root

Re: Random serf checkout failures

2012-11-05 Thread C. Michael Pilato
On 11/05/2012 11:49 AM, Lieven Govaerts wrote: > On Mon, Nov 5, 2012 at 12:41 PM, Lieven Govaerts wrote: >> On Mon, Nov 5, 2012 at 11:33 AM, Philip Martin >> wrote: >>> Philip Martin writes: >>> I've been experimenting checking out subversion/tags from my local mirror of the Subversion

Re: Random serf checkout failures

2012-11-05 Thread Philip Martin
Lieven Govaerts writes: > My current test with svn trunk & apache+mod_dav_svn 1.6.12 does not > reproduce this issue. I'm seeing the problem with trunk mod_dav_svn. > What I am seeing is that svn is using a lot of memory, up to 1GB. > Currently looking at the root cause there. http://subversio

Re: Random serf checkout failures

2012-11-05 Thread Lieven Govaerts
On Mon, Nov 5, 2012 at 12:41 PM, Lieven Govaerts wrote: > On Mon, Nov 5, 2012 at 11:33 AM, Philip Martin > wrote: >> Philip Martin writes: >> >>> I've been experimenting checking out subversion/tags from my local >>> mirror of the Subversion repository using a client and mod_dav_svn from >>> tru

[PATCH] Implement '--include-externals' option to 'svn list'

2012-11-05 Thread vijay
Hi, This patch implements '--include-externals' option to 'svn list' [Issue #4225] [1]. All tests pass with 'make check' & 'make davautocheck'. Attached the patch and log message. Please review this patch and share your thoughts. Thanks in advance for your time. Thanks & Regards, Vijayagur

Re: Random serf checkout failures

2012-11-05 Thread Philip Martin
Lieven Govaerts writes: > From your previous report I noticed the 406 response that serf isn't > handling, at least serf doesn't support a response coming in while the > matching request wasn't completely sent yet. I guess that 406 response > was for a REPORT request not flushed fast enough. In

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Branko Čibej
On 05.11.2012 15:43, Ivan Zhakov wrote: > On Mon, Nov 5, 2012 at 6:30 PM, Branko Čibej wrote: >> On 05.11.2012 15:10, Ivan Zhakov wrote: >>> Here is updated patch: >>> [[[ >>> Add target platform information to user agent string. >>> >>> * subversion/libsvn_ra_serf/ra_serf.h >>> (USER_AGENT): Ad

Re: svn commit: r1405832 - /subversion/site/publish/docs/release-notes/1.8.html

2012-11-05 Thread Paul Burba
On Mon, Nov 5, 2012 at 10:30 AM, Stefan Sperling wrote: > On Mon, Nov 05, 2012 at 03:25:00PM -, pbu...@apache.org wrote: >> Author: pburba >> Date: Mon Nov 5 15:24:59 2012 >> New Revision: 1405832 >> >> URL: http://svn.apache.org/viewvc?rev=1405832&view=rev >> Log: >> * site/publish/docs/rele

Re: [PATCH] Implement svnadmin verify --force

2012-11-05 Thread Prabhu Gnana Sundar
Folks, I seriously think that it is time for me to take a break from sending iterative patches and just sit back and analyse the whole problem from first. I value all your precious times spent on this and I wish to come back with a much cleaner work which would abide by the coding standards of

Re: svn commit: r1405832 - /subversion/site/publish/docs/release-notes/1.8.html

2012-11-05 Thread Stefan Sperling
On Mon, Nov 05, 2012 at 03:25:00PM -, pbu...@apache.org wrote: > Author: pburba > Date: Mon Nov 5 15:24:59 2012 > New Revision: 1405832 > > URL: http://svn.apache.org/viewvc?rev=1405832&view=rev > Log: > * site/publish/docs/release-notes/1.8.html > Minor wording tweak to account for rename

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 6:34 PM, Ben Reser wrote: > On Mon, Nov 5, 2012 at 6:10 AM, Ivan Zhakov wrote: >> Here is updated patch: >> [[[ >> Add target platform information to user agent string. >> >> * subversion/libsvn_ra_serf/ra_serf.h >> (USER_AGENT): Add target platform information. >> * subv

Re: inheritable properties names (was: Re: svn commit: r1404404 - /subversion/site/publish/docs/release-notes/1.8.html)

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 6:19 PM, Paul Burba wrote: > On Thu, Nov 1, 2012 at 10:59 AM, Stefan Sperling wrote: >> On Thu, Nov 01, 2012 at 10:40:41AM -0400, Mark Phippard wrote: >>> Guess I just do not see big benefit from using the existing property. >>> I am not vetoing the idea or anything, just d

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 7:05 PM, Bert Huijben wrote: > > >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: maandag 5 november 2012 15:10 >> To: Branko Čibej >> Cc: dev@subversion.apache.org >> Subject: Re: [PATCH] Add platform information to user agent string >

RE: [PATCH] Add platform information to user agent string

2012-11-05 Thread Bert Huijben
> -Original Message- > From: Branko Čibej [mailto:br...@wandisco.com] > Sent: maandag 5 november 2012 15:31 > To: dev@subversion.apache.org > Subject: Re: [PATCH] Add platform information to user agent string > > On 05.11.2012 15:10, Ivan Zhakov wrote: > > Here is updated patch: > > [[[

RE: [PATCH] Add platform information to user agent string

2012-11-05 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: maandag 5 november 2012 15:10 > To: Branko Čibej > Cc: dev@subversion.apache.org > Subject: Re: [PATCH] Add platform information to user agent string > > On Fri, Nov 2, 2012 at 10:40 PM, Ivan Zhakov wrote: > >

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 6:30 PM, Branko Čibej wrote: > On 05.11.2012 15:10, Ivan Zhakov wrote: >> Here is updated patch: >> [[[ >> Add target platform information to user agent string. >> >> * subversion/libsvn_ra_serf/ra_serf.h >> (USER_AGENT): Add target platform information. >> * subversion/li

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ben Reser
On Mon, Nov 5, 2012 at 6:10 AM, Ivan Zhakov wrote: > Here is updated patch: > [[[ > Add target platform information to user agent string. > > * subversion/libsvn_ra_serf/ra_serf.h > (USER_AGENT): Add target platform information. > * subversion/libsvn_ra_serf/ra_svn.h > (SVN_RA_SVN__DEFAULT_USE

Re: inheritable properties names

2012-11-05 Thread Branko Čibej
On 05.11.2012 15:19, Paul Burba wrote: > On Thu, Nov 1, 2012 at 10:59 AM, Stefan Sperling wrote: >> On Thu, Nov 01, 2012 at 10:40:41AM -0400, Mark Phippard wrote: >>> Guess I just do not see big benefit from using the existing property. >>> I am not vetoing the idea or anything, just do not see th

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Branko Čibej
On 05.11.2012 15:10, Ivan Zhakov wrote: > Here is updated patch: > [[[ > Add target platform information to user agent string. > > * subversion/libsvn_ra_serf/ra_serf.h > (USER_AGENT): Add target platform information. > * subversion/libsvn_ra_serf/ra_svn.h > (SVN_RA_SVN__DEFAULT_USERAGENT): Add

Re: inheritable properties names (was: Re: svn commit: r1404404 - /subversion/site/publish/docs/release-notes/1.8.html)

2012-11-05 Thread Paul Burba
On Thu, Nov 1, 2012 at 10:59 AM, Stefan Sperling wrote: > On Thu, Nov 01, 2012 at 10:40:41AM -0400, Mark Phippard wrote: >> Guess I just do not see big benefit from using the existing property. >> I am not vetoing the idea or anything, just do not see the big >> improvement and the parsing/merging

Re: Race in svn_atomic_namespace__create

2012-11-05 Thread Stefan Sperling
On Mon, Nov 05, 2012 at 02:54:07PM +0100, Stefan Fuhrmann wrote: > On Sun, Nov 4, 2012 at 10:40 AM, Stefan Sperling wrote: > > I just came across something that reminded me of this thread. > > It seems PostgreSQL is doing something quite similar to what we > > want to do here: > > > > When the fi

Re: [PATCH] Add platform information to user agent string

2012-11-05 Thread Ivan Zhakov
On Fri, Nov 2, 2012 at 10:40 PM, Ivan Zhakov wrote: > On Fri, Nov 2, 2012 at 9:04 PM, Branko Čibej wrote: >> >> On 02.11.2012 17:30, Ivan Zhakov wrote: >> > On Fri, Nov 2, 2012 at 5:12 PM, Branko Čibej wrote: >> >> On 02.11.2012 12:36, Ivan Zhakov wrote: >> >>> On Wed, Oct 31, 2012 at 2:04 AM, B

Re: [PATCH] Implement svnadmin verify --force

2012-11-05 Thread Julian Foad
Prabhu Gnana Sundar wrote: > Julian Foad wrote: >> [...]  We should choose either "notification" style >> (that is, messages that are not error messages), such as [...] >> or "error messages" style, in which case the messages should be >> formatted like all svn err msgs, for example: [...] >>

Re: Race in svn_atomic_namespace__create

2012-11-05 Thread Stefan Fuhrmann
On Sun, Nov 4, 2012 at 10:40 AM, Stefan Sperling wrote: > On Wed, Oct 31, 2012 at 03:24:10PM +0100, Stefan Fuhrmann wrote: > > On Wed, Oct 31, 2012 at 2:54 PM, Philip Martin > > wrote: > > > > > Philip Martin writes: > > > > > > > Stefan Fuhrmann writes: > > > > > > > >> Excellent analysis, Phi

Re: Authz on Collection of Repositories

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 5:06 PM, Lieven Govaerts wrote: > On Mon, Nov 5, 2012 at 1:15 PM, Ivan Zhakov wrote: >> On Mon, Nov 5, 2012 at 12:11 PM, Branko Čibej wrote: >>> On 05.11.2012 00:21, Thomas Åkesson wrote: I did some tests with curl --head just as a sanity check. It seems to be a

Re: Authz on Collection of Repositories

2012-11-05 Thread Lieven Govaerts
Mark, On Mon, Nov 5, 2012 at 2:12 PM, Mark Phippard wrote: > On Mon, Nov 5, 2012 at 8:07 AM, Mark Phippard wrote: >> On Mon, Nov 5, 2012 at 8:01 AM, Lieven Govaerts wrote: >>> On Mon, Nov 5, 2012 at 12:02 PM, Mark Phippard wrote: On Nov 5, 2012, at 3:11 AM, Branko Čibej wrote: >

Re: Authz on Collection of Repositories

2012-11-05 Thread Mark Phippard
On Mon, Nov 5, 2012 at 8:12 AM, Mark Phippard wrote: > On Mon, Nov 5, 2012 at 8:07 AM, Mark Phippard wrote: >> On Mon, Nov 5, 2012 at 8:01 AM, Lieven Govaerts wrote: >>> On Mon, Nov 5, 2012 at 12:02 PM, Mark Phippard wrote: On Nov 5, 2012, at 3:11 AM, Branko Čibej wrote: > On 05.

Re: Authz on Collection of Repositories

2012-11-05 Thread Mark Phippard
On Mon, Nov 5, 2012 at 8:07 AM, Mark Phippard wrote: > On Mon, Nov 5, 2012 at 8:01 AM, Lieven Govaerts wrote: >> On Mon, Nov 5, 2012 at 12:02 PM, Mark Phippard wrote: >>> On Nov 5, 2012, at 3:11 AM, Branko Čibej wrote: >>> On 05.11.2012 00:21, Thomas Åkesson wrote: > I did some tests w

Re: [PATCH] Implement svnadmin verify --force

2012-11-05 Thread Daniel Shahaf
Stefan Sperling wrote on Mon, Nov 05, 2012 at 12:37:19 +0100: > On Mon, Nov 05, 2012 at 02:42:29PM +0530, Prabhu Gnana Sundar wrote: > > I guess, this also solves the layer violation problem. Correct me if > > am wrong. > > Daniel suggested to use svn_error_quick_wrap() which you aren't using. > S

Re: Authz on Collection of Repositories

2012-11-05 Thread Mark Phippard
On Mon, Nov 5, 2012 at 8:01 AM, Lieven Govaerts wrote: > On Mon, Nov 5, 2012 at 12:02 PM, Mark Phippard wrote: >> On Nov 5, 2012, at 3:11 AM, Branko Čibej wrote: >> >>> On 05.11.2012 00:21, Thomas Åkesson wrote: I did some tests with curl --head just as a sanity check. It seems to be a >>>

Re: Authz on Collection of Repositories

2012-11-05 Thread Lieven Govaerts
On Mon, Nov 5, 2012 at 1:15 PM, Ivan Zhakov wrote: > On Mon, Nov 5, 2012 at 12:11 PM, Branko Čibej wrote: >> On 05.11.2012 00:21, Thomas Åkesson wrote: >>> I did some tests with curl --head just as a sanity check. It seems to be a >>> good choice for access control. I primarily wanted to see tha

Re: Authz on Collection of Repositories

2012-11-05 Thread Lieven Govaerts
On Mon, Nov 5, 2012 at 12:02 PM, Mark Phippard wrote: > On Nov 5, 2012, at 3:11 AM, Branko Čibej wrote: > >> On 05.11.2012 00:21, Thomas Åkesson wrote: >>> I did some tests with curl --head just as a sanity check. It seems to be a >>> good choice for access control. I primarily wanted to see tha

Re: svn commit: r1405441 - /subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db_pristine.c

2012-11-05 Thread Stefan Fuhrmann
On Mon, Nov 5, 2012 at 1:14 PM, Philip Martin wrote: > as...@apache.org writes: > > > Author: ashod > > Date: Sat Nov 3 23:51:31 2012 > > New Revision: 1405441 > > > > URL: http://svn.apache.org/viewvc?rev=1405441&view=rev > > Log: > > Added a helper to compress files in-memory. > Please write m

Re: svn commit: r1405517 - in /subversion/trunk/subversion/bindings/javahl/native: CopySources.cpp CreateJ.cpp SVNClient.cpp StringArray.cpp Targets.cpp

2012-11-05 Thread Stefan Fuhrmann
On Sun, Nov 4, 2012 at 3:40 PM, Branko Čibej wrote: > On 04.11.2012 12:37, Blair Zajac wrote: > > On Nov 4, 2012, at 2:14 AM, stef...@apache.org wrote: > > > >> Author: stefan2 > >> Date: Sun Nov 4 10:14:56 2012 > >> New Revision: 1405517 > >> > >> URL: http://svn.apache.org/viewvc?rev=1405517&v

Re: svn commit: r1404159 - /subversion/trunk/subversion/libsvn_subr/named_atomic.c

2012-11-05 Thread Stefan Fuhrmann
On Wed, Oct 31, 2012 at 5:38 PM, Julian Foad wrote: > Philip Martin: > > > stef...@apache.org writes: > >> + /* Sanitize (in case of data corruption) > >> + */ > >> + if (new_ns->data->count > MAX_ATOMIC_COUNT) > >> +new_ns->data->count = MAX_ATOMIC_COUNT; > > > > I'm s

Re: Authz on Collection of Repositories

2012-11-05 Thread Ivan Zhakov
On Mon, Nov 5, 2012 at 12:11 PM, Branko Čibej wrote: > On 05.11.2012 00:21, Thomas Åkesson wrote: >> I did some tests with curl --head just as a sanity check. It seems to be a >> good choice for access control. I primarily wanted to see that HEAD requests >> were not allowed in situations where

Re: svn commit: r1405441 - /subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db_pristine.c

2012-11-05 Thread Philip Martin
as...@apache.org writes: > Author: ashod > Date: Sat Nov 3 23:51:31 2012 > New Revision: 1405441 > > URL: http://svn.apache.org/viewvc?rev=1405441&view=rev > Log: > Added a helper to compress files in-memory. > +/* Compress a complete file into a stringbuf. */ > +static svn_error_t * > +file_to_

Re: svn commit: r1405741 - /subversion/upstream/

2012-11-05 Thread Branko Čibej
On 05.11.2012 12:07, Greg Stein wrote: > This is good stuff. > > In a following commit, you added a package in here... do you actually > intend to modify it? > > I would posit we do not need vendor branches unless we specifically intend > to make local changes. Yes, I intend to modify it (slightly

Re: Random serf checkout failures

2012-11-05 Thread Lieven Govaerts
On Mon, Nov 5, 2012 at 11:33 AM, Philip Martin wrote: > Philip Martin writes: > >> I've been experimenting checking out subversion/tags from my local >> mirror of the Subversion repository using a client and mod_dav_svn from >> trunk. I'm getting several different errors seemingly at random, I >

Re: [PATCH] Implement svnadmin verify --force

2012-11-05 Thread Stefan Sperling
On Mon, Nov 05, 2012 at 02:42:29PM +0530, Prabhu Gnana Sundar wrote: > On 11/04/2012 06:14 AM, Daniel Shahaf wrote: > > > >>Index: subversion/svnadmin/main.c > >>=== > >>--- subversion/svnadmin/main.c (revision 1402414) > >>+++ su

Re: svn commit: r1405741 - /subversion/upstream/

2012-11-05 Thread Greg Stein
This is good stuff. In a following commit, you added a package in here... do you actually intend to modify it? I would posit we do not need vendor branches unless we specifically intend to make local changes. Cheers, -g On Nov 5, 2012 5:52 AM, wrote: > Author: brane > Date: Mon Nov 5 10:52:06

Re: Authz on Collection of Repositories

2012-11-05 Thread Branko Čibej
On 05.11.2012 12:02, Mark Phippard wrote: > On Nov 5, 2012, at 3:11 AM, Branko Čibej wrote: > >> On 05.11.2012 00:21, Thomas Åkesson wrote: >>> I did some tests with curl --head just as a sanity check. It seems to be a >>> good choice for access control. I primarily wanted to see that HEAD >>> r

Re: Authz on Collection of Repositories

2012-11-05 Thread Mark Phippard
On Nov 5, 2012, at 3:11 AM, Branko Čibej wrote: > On 05.11.2012 00:21, Thomas Åkesson wrote: >> I did some tests with curl --head just as a sanity check. It seems to be a >> good choice for access control. I primarily wanted to see that HEAD requests >> were not allowed in situations where GET

Re: Random serf checkout failures

2012-11-05 Thread Philip Martin
Philip Martin writes: > I've been experimenting checking out subversion/tags from my local > mirror of the Subversion repository using a client and mod_dav_svn from > trunk. I'm getting several different errors seemingly at random, I > suspect they may be related to some common underlying proble

Re: [PATCH] Implement svnadmin verify --force

2012-11-05 Thread Prabhu Gnana Sundar
On 11/04/2012 06:14 AM, Daniel Shahaf wrote: Index: subversion/svnadmin/main.c === --- subversion/svnadmin/main.c (revision 1402414) +++ subversion/svnadmin/main.c (working copy) @@ -738,6 +743,16 @@

Re: Authz on Collection of Repositories

2012-11-05 Thread Branko Čibej
On 05.11.2012 00:21, Thomas Åkesson wrote: > I did some tests with curl --head just as a sanity check. It seems to be a > good choice for access control. I primarily wanted to see that HEAD requests > were not allowed in situations where GET is not (e.g. when user has access in > directories bel