Re: svn commit: r1403982 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-10-30 Thread Ben Reser
On Tue, Oct 30, 2012 at 10:02 PM, Blair Zajac wrote: > Looking at the diff, do you mean 'should be a const'? Thanks, log fixed.

Re: svn commit: r1403982 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-10-30 Thread Daniel Shahaf
bre...@apache.org wrote on Wed, Oct 31, 2012 at 04:59:43 -: > Author: breser > Date: Wed Oct 31 04:59:42 2012 > New Revision: 1403982 > > URL: http://svn.apache.org/viewvc?rev=1403982&view=rev > Log: > Fix a compile warning and a memory leak in rep_write_cleanup. > > * subversion/libsvn_fs_fs

Re: svn commit: r1403982 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

2012-10-30 Thread Blair Zajac
On 10/30/12 9:59 PM, bre...@apache.org wrote: Author: breser Date: Wed Oct 31 04:59:42 2012 New Revision: 1403982 URL: http://svn.apache.org/viewvc?rev=1403982&view=rev Log: Fix a compile warning and a memory leak in rep_write_cleanup. * subversion/libsvn_fs_fs/fs_fs.c (rep_write_cleanup): t

Re: [Bug] [Subversion 1.7] svn blame doesn't work for locally modified files

2012-10-30 Thread Paul Burba
On Tue, Oct 30, 2012 at 6:08 PM, Julian Foad wrote: > Paul Burba wrote: > >> Mike Pilato is tying off loose ends for the upcoming 1.8 release and >> asked me to check this patch for issue #4034 on my Windows machine. >> >> The patch doesn't appear to make any difference: >> >> With three files, wi

Re: [Bug] [Subversion 1.7] svn blame doesn't work for locally modified files

2012-10-30 Thread Julian Foad
Paul Burba wrote: > Mike Pilato is tying off loose ends for the upcoming 1.8 release and > asked me to check this patch for issue #4034 on my Windows machine. > > The patch doesn't appear to make any difference: > > With three files, with three different eols as per their names: [...] You don't

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Branko Čibej
On 30.10.2012 21:25, Ivan Zhakov wrote: > On Tue, Oct 30, 2012 at 10:42 PM, C. Michael Pilato > wrote: >> On 10/30/2012 02:15 PM, Julian Foad wrote: >>> Ivan Zhakov wrote: >>> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: > On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: >> I

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Stefan Sperling
On Wed, Oct 31, 2012 at 12:25:43AM +0400, Ivan Zhakov wrote: > I completely agree that it would be great to have one code to get > platform information. But current svn_sysinfo* implementation provides > detailed information which very expensive to obtain. In some codepath > we have to execute exte

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Ivan Zhakov
On Tue, Oct 30, 2012 at 10:42 PM, C. Michael Pilato wrote: > On 10/30/2012 02:15 PM, Julian Foad wrote: >> Ivan Zhakov wrote: >> >>> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: > I think it will be useful to add client platform inf

Re: [Bug] [Subversion 1.7] svn blame doesn't work for locally modified files

2012-10-30 Thread Paul Burba
On Fri, Oct 14, 2011 at 6:49 AM, Daniel Shahaf wrote: > [ switching list, please drop users@ from further replies ] > > Konstantin Kolinko wrote on Fri, Oct 14, 2011 at 11:43:14 +0400: >> 2011/10/14 Andrey Paramonov : >> > On 13.10.2011 22:31, Ryan Schmidt wrote: >> >> >> >> On Oct 13, 2011, at 06

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread C. Michael Pilato
[ THIS WAS AN EARLIER DRAFT OF MY INTENDED MAIL. NOT SURE ] [ HOW IT HIT THE LIST. PLEASE IGNORE. ] On 10/30/2012 02:39 PM, C. Michael Pilato wrote: > On 10/30/2012 02:15 PM, Julian Foad wrote: >> Ivan Zhakov wrote: >> >>> On Tue, Oct 30, 2012 at 8:07 PM, Ben Rese

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread C. Michael Pilato
On 10/30/2012 02:15 PM, Julian Foad wrote: > Ivan Zhakov wrote: > >> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: >>> On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: I think it will be useful to add client platform information to user agent string, to use it Apache HTTP Server c

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread C. Michael Pilato
On 10/30/2012 02:15 PM, Julian Foad wrote: > Ivan Zhakov wrote: > >> On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: >>> On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: I think it will be useful to add client platform information to user agent string, to use it Apache HTTP Server c

Re: Race in svn_atomic_namespace__create

2012-10-30 Thread Stefan Sperling
On Tue, Oct 30, 2012 at 05:58:20PM +, Philip Martin wrote: > Another approach would be to create the shared memory created from some > other, long-lived, process. The user would have to run this process to > enable caching. To handle a large number of repositories this would > probably have t

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Julian Foad
Ivan Zhakov wrote: > On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: >> On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: >>> I think it will be useful to add client platform information to user >>> agent string, to use it Apache HTTP Server configuration or Subversion >>> hooks. Within my

Re: Race in svn_atomic_namespace__create

2012-10-30 Thread Philip Martin
Philip Martin writes: > That's a serious problem, the two processes are not longer using the > same shared memory segment to keep in sync. Changes made by one process > won't be visible to another. I don't see how to fix this with the current APR code. The process that creates the named shared

Re: svn commit: r1403733 - /subversion/trunk/subversion/libsvn_ra_serf/serf.c

2012-10-30 Thread Daniel Shahaf
i...@apache.org wrote on Tue, Oct 30, 2012 at 15:09:57 -: > Author: ivan > Date: Tue Oct 30 15:09:56 2012 > New Revision: 1403733 > > URL: http://svn.apache.org/viewvc?rev=1403733&view=rev > Log: > * subversion/libsvn_ra_serf/serf.c > (svn_ra_serf__open): Use whitespace instead of '/' as del

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Ivan Zhakov
On Tue, Oct 30, 2012 at 8:07 PM, Ben Reser wrote: > On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: >> I think it will be useful to add client platform information to user >> agent string, to use it Apache HTTP Server configuration or Subversion >> hooks. Within my patch applied user agent wi

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Stefan Sperling
On Tue, Oct 30, 2012 at 08:00:00PM +0400, Ivan Zhakov wrote: > You already broadcast this information when browsing the Internet :) Not with a custom user agent string a browser allows me to set :) > Also we already broadcast SVN version information. So I don't see big > issue here. Of course it

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Ben Reser
On Tue, Oct 30, 2012 at 8:28 AM, Ivan Zhakov wrote: > I think it will be useful to add client platform information to user > agent string, to use it Apache HTTP Server configuration or Subversion > hooks. Within my patch applied user agent will be like this: > SVN/1.8.0 (Windows) serf/1.1.1 Tortoi

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Ivan Zhakov
On Tue, Oct 30, 2012 at 7:49 PM, Stefan Sperling wrote: > On Tue, Oct 30, 2012 at 07:28:27PM +0400, Ivan Zhakov wrote: >> Hi, >> >> I think it will be useful to add client platform information to user >> agent string, to use it Apache HTTP Server configuration or Subversion >> hooks. Within my pat

Re: [PATCH] Add platform information to user agent string

2012-10-30 Thread Stefan Sperling
On Tue, Oct 30, 2012 at 07:28:27PM +0400, Ivan Zhakov wrote: > Hi, > > I think it will be useful to add client platform information to user > agent string, to use it Apache HTTP Server configuration or Subversion > hooks. Within my patch applied user agent will be like this: > SVN/1.8.0 (Windows)

[PATCH] Add platform information to user agent string

2012-10-30 Thread Ivan Zhakov
Hi, I think it will be useful to add client platform information to user agent string, to use it Apache HTTP Server configuration or Subversion hooks. Within my patch applied user agent will be like this: SVN/1.8.0 (Windows) serf/1.1.1 TortoiseSVN/1.8.0 SVN/1.8.0 (Macintosh) serf/1.1.1 SVN/1.8.0 (

Re: [PATCH] Implement svnadmin verify --force

2012-10-30 Thread Stefan Sperling
On Tue, Oct 30, 2012 at 04:07:49PM +0200, Daniel Shahaf wrote: > Prabhu Gnana Sundar wrote on Tue, Oct 30, 2012 at 19:22:31 +0530: > > + if (err && keep_going) > > +{ > > + svn_repos_notify_t *notify_failure; > > + notify_failure = svn_repos_notify_create(svn_repos_notify_failure, >

Re: [PATCH] Implement svnadmin verify --force

2012-10-30 Thread Stefan Sperling
On Tue, Oct 30, 2012 at 07:22:31PM +0530, Prabhu Gnana Sundar wrote: > Index: subversion/svnadmin/main.c > === > --- subversion/svnadmin/main.c(revision 1402414) > +++ subversion/svnadmin/main.c(working copy) > @@ -738

Re: svn commit: r1403588 - in /subversion/trunk/subversion: mod_dav_svn/reports/update.c tests/cmdline/update_tests.py

2012-10-30 Thread C. Michael Pilato
On 10/30/2012 08:58 AM, Bert Huijben wrote: >>> How hard would it be to port this one back to 1.7? >> >> I don't think it would be hard at all. I certainly plan to make the attempt >> today. > > One of the reasons I was suggesting is that I was thinking that this code > might also relate to the e

Re: [PATCH] Implement svnadmin verify --force

2012-10-30 Thread Daniel Shahaf
Prabhu Gnana Sundar wrote on Tue, Oct 30, 2012 at 19:22:31 +0530: > > Thanks to Stefan and Daniel. > > Attaching a new patch addressing the suggestions given by Stefan and > Daniel. Hope this is good :) > Edited the log message also. > Index: subversion/libsvn_repos/dump.c >

Re: [PATCH] Implement svnadmin verify --force

2012-10-30 Thread Prabhu Gnana Sundar
Thanks to Stefan and Daniel. Attaching a new patch addressing the suggestions given by Stefan and Daniel. Hope this is good :) Edited the log message also. Thanks and regards Prabhu On 10/29/2012 11:53 PM, Stefan Sperling wrote: On Mon, Oct 29, 2012 at 10:45:19PM +0530, Prabhu Gnana Sunda

Re: Race in svn_atomic_namespace__create

2012-10-30 Thread Philip Martin
Stefan Fuhrmann writes: > Maybe, there should be a regression test that > tries concurrent initialization. There are two objects here: the named file and the shared memory segment. The usual sequence for a single process is: create file, create segment, delete segment, delete file. There are t

RE: svn commit: r1403588 - in /subversion/trunk/subversion: mod_dav_svn/reports/update.c tests/cmdline/update_tests.py

2012-10-30 Thread Bert Huijben
> -Original Message- > From: C. Michael Pilato [mailto:cmpil...@collab.net] > Sent: dinsdag 30 oktober 2012 13:01 > To: Bert Huijben > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1403588 - in /subversion/trunk/subversion: > mod_dav_svn/reports/update.c tests/cmdline/update_t

Re: svn commit: r1403588 - in /subversion/trunk/subversion: mod_dav_svn/reports/update.c tests/cmdline/update_tests.py

2012-10-30 Thread C. Michael Pilato
On 10/30/2012 06:46 AM, Bert Huijben wrote: > > >> -Original Message- >> From: cmpil...@apache.org [mailto:cmpil...@apache.org] >> Sent: dinsdag 30 oktober 2012 01:24 >> To: comm...@subversion.apache.org >> Subject: svn commit: r1403588 - in /subversion/trunk/subversion: >> mod_dav_svn/re

RE: svn commit: r1403588 - in /subversion/trunk/subversion: mod_dav_svn/reports/update.c tests/cmdline/update_tests.py

2012-10-30 Thread Bert Huijben
> -Original Message- > From: cmpil...@apache.org [mailto:cmpil...@apache.org] > Sent: dinsdag 30 oktober 2012 01:24 > To: comm...@subversion.apache.org > Subject: svn commit: r1403588 - in /subversion/trunk/subversion: > mod_dav_svn/reports/update.c tests/cmdline/update_tests.py > > Auth

Re: Race in svn_atomic_namespace__create

2012-10-30 Thread Stefan Fuhrmann
On Tue, Oct 30, 2012 at 12:11 AM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > On Mon, Oct 29, 2012 at 10:46 PM, Philip Martin > > wrote: > > > >> Philip Martin writes: > >> > >> > Philip Martin writes: > >> > > >> >> I can't see any order in which we can do attach/create that doesn't >