Re: ISSUE: "To many open files" not being logged by master server when sync fails.

2012-05-07 Thread Kenneth Miles
On 04/05/12 20:09, Philip Martin wrote: Kenneth Miles writes: I'm not sure if a specific revision is causing the issue. But it always fails replaying on a certain revision number as seen in the stack trace. It is definitely opening multiple files more than once. It closes all file handles

Re: ra_serf crashes on Windows with AVG 2012 Surf-Shield

2012-05-07 Thread Greg Stein
On May 7, 2012 8:16 PM, "Lieven Govaerts" wrote: >... > The problem is in ra_serf/util.c svn_ra_serf__handle_xml_parser: > >   if (sl.code == 404 && ctx->ignore_errors == FALSE) >     { >       add_done_item(ctx); > >       err = svn_ra_serf__handle_server_error(request, response, pool); > >      

Re: ra_serf crashes on Windows with AVG 2012 Surf-Shield

2012-05-07 Thread Lieven Govaerts
Johan, On Sat, Apr 14, 2012 at 11:42 PM, Johan Corveleyn wrote: > On Wed, Apr 11, 2012 at 1:43 PM, Johan Corveleyn > wrote: > > On Wed, Apr 11, 2012 at 12:28 PM, Philip Martin > > wrote: > >> Johan Corveleyn writes: > >> > >>> I don't know what Surf-Shield does. Its description says: "Can det

Re: svn commit: r1333936 - in /subversion/trunk/subversion: include/private/svn_wc_private.h include/svn_ra.h libsvn_client/ra.c libsvn_ra_serf/update.c libsvn_wc/adm_ops.c

2012-05-07 Thread Greg Stein
On Mon, May 7, 2012 at 5:22 PM, C. Michael Pilato wrote: > On 05/04/2012 05:16 PM, Greg Stein wrote: >> On Fri, May 4, 2012 at 9:13 AM,   wrote: >>> Author: cmpilato >>> Date: Fri May  4 13:13:00 2012 >>> New Revision: 1333936 > > Okay.  I think I've digested and acted open all of the feedback I'v

Re: svn commit: r1333936 - in /subversion/trunk/subversion: include/private/svn_wc_private.h include/svn_ra.h libsvn_client/ra.c libsvn_ra_serf/update.c libsvn_wc/adm_ops.c

2012-05-07 Thread C. Michael Pilato
On 05/04/2012 05:16 PM, Greg Stein wrote: > On Fri, May 4, 2012 at 9:13 AM, wrote: >> Author: cmpilato >> Date: Fri May 4 13:13:00 2012 >> New Revision: 1333936 Okay. I think I've digested and acted open all of the feedback I've cropped out of this response. There's just this one task remaini

Re: Deletion revision in Ev2

2012-05-07 Thread Greg Stein
On Mon, May 7, 2012 at 3:02 PM, Hyrum K Wright wrote: > On Mon, May 7, 2012 at 1:43 PM, Greg Stein wrote: >... >>>... >>> Simply eliminating the check in editor.c:delete_cb(), and also >>> changing can_modify() to allow invalid revision to act as a wildcard >>> (i.e., "don't bother checking, I kn

Re: Deletion revision in Ev2

2012-05-07 Thread Hyrum K Wright
On Mon, May 7, 2012 at 1:43 PM, Greg Stein wrote: > On Mon, May 7, 2012 at 12:37 PM, Hyrum K Wright > wrote: >>... >> In this case, we are legitimately deleting B/C, but the "revision this >> thing is being deleted from" doesn't exist until commit finalization. > > True. I figured as the FS, we a

Re: Deletion revision in Ev2

2012-05-07 Thread Greg Stein
On Mon, May 7, 2012 at 12:37 PM, Hyrum K Wright wrote: >... > In this case, we are legitimately deleting B/C, but the "revision this > thing is being deleted from" doesn't exist until commit finalization. True. I figured as the FS, we always had a revision... but that's not true :-P >... > Simpl

Re: svn status is slow under a large check-out

2012-05-07 Thread Bob Cardillo
>Yes, please file an issue so we don't lose track of this. Added. http://subversion.tigris.org/issues/show_bug.cgi?id=4178 >very promising. Thanks a lot for your help. I freely plagiarized from this thread. :) Thanks to all, especially Philip for the great analysis!

Deletion revision in Ev2

2012-05-07 Thread Hyrum K Wright
Greg, I noticed there is a check in the filesystem editor implementation to ensure we have a valid revision during delete. Unfortunately, we don't always have such a revision a priori, which means this check is not always valid. Consider the following: $ svn cp A B $ svn rm B/C $ svn ci In this

Re: svn commit: r1333936 - in /subversion/trunk/subversion: include/private/svn_wc_private.h include/svn_ra.h libsvn_client/ra.c libsvn_ra_serf/update.c libsvn_wc/adm_ops.c

2012-05-07 Thread C. Michael Pilato
On 05/04/2012 05:16 PM, Greg Stein wrote: > On Fri, May 4, 2012 at 9:13 AM, wrote: >> Author: cmpilato >> Date: Fri May 4 13:13:00 2012 >> New Revision: 1333936 >> >> URL: http://svn.apache.org/viewvc?rev=1333936&view=rev >> Log: >> Teach libsvn_ra_serf to make use of the server-provided SHA1 ch

Re: svn status is slow under a large check-out

2012-05-07 Thread Stefan Sperling
On Sat, May 05, 2012 at 12:39:05PM -0400, Bob Cardillo wrote: > Thanks for all great info so far! > > >Taking that query out reduces the read() calls back to 99. Do we need > >another SQLite index? Can we improve that query? > > Your index idea was a good one. I used sqlite3 to back up my wc.d

Re: svn status is slow under a large check-out

2012-05-07 Thread Adam D . Walling
Bob Cardillo gmail.com> writes: > CREATE INDEX bobindex1 ON nodes (kind, presence, op_depth) As one of Bob's coworkers, who helped him a bit earlier last week to track down the --non-recursive trick that improved the speed, I had to try this myself after seeing the results of his investigation o

Re: svn commit: r1334953 - /subversion/trunk/subversion/svnserve/main.c

2012-05-07 Thread Stefan Sperling
On Mon, May 07, 2012 at 09:30:30AM -0400, Greg Stein wrote: > On May 7, 2012 7:10 AM, wrote: > >... > > +++ subversion/trunk/subversion/svnserve/main.c Mon May 7 11:10:05 2012 > > @@ -150,6 +150,11 @@ void winservice_notify_stop(void) > > #define SVNSERVE_OPT_CACHE_REVPROPS 267 > > #define SVN

Re: svn commit: r1334953 - /subversion/trunk/subversion/svnserve/main.c

2012-05-07 Thread Greg Stein
On May 7, 2012 7:10 AM, wrote: >... > +++ subversion/trunk/subversion/svnserve/main.c Mon May 7 11:10:05 2012 > @@ -150,6 +150,11 @@ void winservice_notify_stop(void) > #define SVNSERVE_OPT_CACHE_REVPROPS 267 > #define SVNSERVE_OPT_SINGLE_CONN 268 > > +/* Helper macros to stringify ra_svn'