[RFC][PATCH 22/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Add unit tests for the Ra API [ in subversion/bindings/javahl/test/org/tigris/subversion/javahl/ ] * RaReadonlyTests.java: New readonly tests for the RA API * RaTests.java: New read/write tests for the RA API * RunTests.java (suite): Add the RaReadonlyTests

[RFC][PATCH 21/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Expose additional methods publicly so that readonly tests can use them to setup a single shared readonly test repository to speed up tests [ in subversion/bindings/javahl/test/org/tigris/subversion/javahl/ ] * SVNTests.java: (USERNAME, PASSWORD): Make test username a

[RFC][PATCH 19/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Include the new Ra java code in the build process * build.conf (options): Don't try to find new jni header files before they are generated (javahl-java): compile classes in the src/org/apache/subversion/javahl/ra directory (javahl-ra-javah): new section for ge

[RFC][PATCH 01/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Fix return value from the java svn_stream_t read function to be compatible with the txdelta_next_window function [ in subversion/bindings/javahl/native ] * InputStream.cpp (read): Return 0 instead of -1 as expected by the txdelta_next_window function ]]] Index: subve

[RFC][PATCH 18/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: New Java classes exposing the Ra layer to java [ in subversion/bindings/javahl/src/org/tigris/subversion/javahl/ ] * JNIObject.java [ in subversion/bindings/javahl/src/org/tigris/subversion/javahl/ra ] * ISVNDirectory.java, ISVNEditor.java, ISVNFile.java, ISVNNod

[RFC][PATCH 17/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Add support for marking object disposed without deleting it, used by the new Ra JNI code [ in subversion/bindings/javahl/native ] * SVNBase.cpp, SVNBase.h (markDisposed, assertNotDisposed, init): New function to support tracking disposal state of the object (AS

[RFC][PATCH 16/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Add new method for creating new java objects connected to a matching C++ object [ in subversion/bindings/javahl/native ] * SVNBase.cpp, SVNBase.h (createCppBoundObject): New method for creating new java objects connected to a matching C++ object ]]] Index: subversion

[RFC][PATCH 15/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Separated logic for clearing java object cppAddr into its own function as needed by the commit editor C++ objects that require the child to clear the reference and parent to perform deletion [ in subversion/bindings/javahl/native ] * SVNBase.cpp, SVNBase.h (dispose,

[RFC][PATCH 14/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Added support for allocating SVNBase object from passed in pools rather than global pool, as needed by the Ra JNI implementation [ in subversion/bindings/javahl/native ] * SVNBase.cpp, SVNBase.h (SVNBase): Additional constructor taking a parent pool parameter ]]] Ind

[RFC][PATCH 13/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Factor out common progress and cancellation callbacks as well as configuration and authentication context into CommonContext class from SVNClient specific code in the ClientContext class so that it can be shared with the Ra JNI code [ in subversion/bindings/javahl/native ]

[RFC][PATCH 12/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Factor out common java string map processing into StringsTable class from svn_string_t specific processing in the RevpropTable class [ in subversion/bindings/javahl/native ] * StringsTable.cpp, StringsTable.h, RevpropTable.cpp, RevpropTable.h (m_revprops): Move m_rev

[RFC][PATCH 11/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Added SVN_JNI_INPUT_STREAM macro to reduce amount of duplicate code dealing with InputStream wrapper and checking for exceptions [ in subversion/bindings/javahl/native ] * InputStream.h (SVN_JNI_INPUT_STREAM): New macro to declare local variable of type InputStream a

[RFC][PATCH 10/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Added SVN_JNI_BYTE_ARRAY macro to reduce amount of duplicate code dealing with jbyteArray wrapper and checking for exceptions [ in subversion/bindings/javahl/native ] * JNIByteArray.h (SVN_JNI_BYTE_ARRAY): New macro to declare local variable of type JNIByteArray and

[RFC][PATCH 09/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Added support for creating of svn_string_t from JNIByteArray [ in subversion/bindings/javahl/native ] * JNIByteArray.cpp, JNIByteArray.h (getLength): Mark as const as the function does not alter class data and can be used by other const functions (getSvnString)

[RFC][PATCH 08/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Added SVN_JNI_STRING macro to reduce amount of duplicate code dealing with jstring wrapper and checking for exceptions [ in subversion/bindings/javahl/native ] * JNIStringHolder.h (SVN_JNI_STRING): New macro to declare JNIStringHolder local variable and return in cas

[RFC][PATCH 07/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Added CPPADDR_NULL_PTR macro to reduce amount of duplicate code checking C++ pointer extracted from the java object [ in subversion/bindings/javahl/native ] * JNIUtil.h (CPPADDR_NULL_PTR): New macro to test for NULL pointer and raise java exception if necessary ]]] I

[RFC][PATCH 06/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Support logging of the static method calls [ in subversion/bindings/javahl/native ] * JNIStackElement.cpp (JNIStackElement): Add logic to deal with NULL jthis, which happens with static method calls ]]] Index: subversion/bindings/javahl/native/JNIStackElement.cpp ===

[RFC][PATCH 05/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Support keeping global reference to the callback java object as required by the RA API due to callback being used across method calls [ in subversion/bindings/javahl/native ] * CommitCallback.cpp, CommitCallback.h (CommitCallback, ~CommitCallback): Add handling of ad

[RFC][PATCH 04/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Support returning non const, empty rather than NULL hash as required by (svn_ra_get_commit_editor3) apr_hash_t *revprop_table parameter [ in subversion/bindings/javahl/native ] * RevpropTable.cpp, RevpropTable.h (hash): Removed const qualifier and added bool nullIfEm

[RFC][PATCH 03/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Factored out common context for later use by SVNRa class [ in subversion/bindings/javahl/src/org/tigris/subversion/javahl/ ] * CommonContext.java, SVNClient.java (ClientContext): Move to progress listener into CommonContext for later use by the new SVNRa class ]]] In

[RFC][PATCH 02/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
[[[ JavaHL: Explicitly pass jobject jthis when processing dispose() call rather than stashing a reference in the SVNBase class where it can be missused later [ in subversion/bindings/javahl/native ] * SVNBase.cpp, SVNBase.h (dispose, jthis): Accept jobject jthis as explicit para

[RFC][PATCH 00/22] JavaHL Ra API Implementation

2012-04-21 Thread Vladimir Berezniker
Hi All, I am sending patch series that adds support for subset of SVN Ra layer to the JavaHL API. Initial goal was to expose commit editor APIs necessary to commit to the remote repositories without local working copy and then seek feedback before going further. While developing the prototype

Re: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-21 Thread Hyrum K Wright
On Sat, Apr 21, 2012 at 5:08 PM, Greg Stein wrote: > On Sat, Apr 21, 2012 at 17:59, Daniel Shahaf wrote: >> Hyrum K Wright wrote on Sat, Apr 21, 2012 at 16:00:02 -0500: >>> On Sat, Apr 21, 2012 at 11:51 AM, Stefan Sperling wrote: >>> > On Sat, Apr 21, 2012 at 07:49:37AM -0500, Hyrum K Wright wro

Re: svn commit: r1328595 - /subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db.c

2012-04-21 Thread Greg Stein
On Sat, Apr 21, 2012 at 03:03, wrote: > Author: ashod > Date: Sat Apr 21 07:03:51 2012 > New Revision: 1328595 > > URL: http://svn.apache.org/viewvc?rev=1328595&view=rev > Log: > Pristine.db created during db-init. > ** Checkpoint: raw code. Not ready for review yet! ** I would recommend adding

Re: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-21 Thread Greg Stein
On Sat, Apr 21, 2012 at 17:59, Daniel Shahaf wrote: > Hyrum K Wright wrote on Sat, Apr 21, 2012 at 16:00:02 -0500: >> On Sat, Apr 21, 2012 at 11:51 AM, Stefan Sperling wrote: >> > On Sat, Apr 21, 2012 at 07:49:37AM -0500, Hyrum K Wright wrote: >> >> On Fri, Apr 20, 2012 at 10:15 PM, Greg Stein w

Re: Outdated check in import?

2012-04-21 Thread Daniel Shahaf
Hyrum K Wright wrote on Sat, Apr 21, 2012 at 16:14:54 -0500: > On Fri, Apr 20, 2012 at 9:47 AM, C. Michael Pilato > wrote: > > On 04/19/2012 01:37 PM, Julian Foad wrote: > >> C. Michael Pilato wrote: > >> > >>> I guess I don't see this as "whack-a-mole with 'svn > >>> import'".  'svn import' is t

Re: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-21 Thread Daniel Shahaf
Hyrum K Wright wrote on Sat, Apr 21, 2012 at 16:00:02 -0500: > On Sat, Apr 21, 2012 at 11:51 AM, Stefan Sperling wrote: > > On Sat, Apr 21, 2012 at 07:49:37AM -0500, Hyrum K Wright wrote: > >> On Fri, Apr 20, 2012 at 10:15 PM, Greg Stein wrote: > >> > Seems we can/should have a runtime version ch

Re: Outdated check in import?

2012-04-21 Thread Hyrum K Wright
On Fri, Apr 20, 2012 at 9:47 AM, C. Michael Pilato wrote: > On 04/19/2012 01:37 PM, Julian Foad wrote: >> C. Michael Pilato wrote: >> >>> I guess I don't see this as "whack-a-mole with 'svn >>> import'".  'svn import' is treated uniquely because it is >>> genuinely unique -- no other Subversion op

Re: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-21 Thread Hyrum K Wright
On Sat, Apr 21, 2012 at 11:51 AM, Stefan Sperling wrote: > On Sat, Apr 21, 2012 at 07:49:37AM -0500, Hyrum K Wright wrote: >> On Fri, Apr 20, 2012 at 10:15 PM, Greg Stein wrote: >> > Seems we can/should have a runtime version check? Avoid running with >> > 3.7.11? >> >> I dunno.  Arguably, there

RE: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-21 Thread Bert Huijben
> -Original Message- > From: Blair Zajac [mailto:bl...@orcaware.com] > Sent: zaterdag 21 april 2012 1:19 > To: dev@subversion.apache.org > Subject: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested > query abort > > I just got this on my MacPorts svn, the revision num

Re: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-21 Thread Stefan Sperling
On Sat, Apr 21, 2012 at 07:49:37AM -0500, Hyrum K Wright wrote: > On Fri, Apr 20, 2012 at 10:15 PM, Greg Stein wrote: > > Seems we can/should have a runtime version check? Avoid running with 3.7.11? > > I dunno. Arguably, there are bugs in many versions of our dependency > libraries which affect

Re: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-21 Thread Hyrum K Wright
On Fri, Apr 20, 2012 at 10:15 PM, Greg Stein wrote: > > On Apr 20, 2012 9:41 PM, "Blair Zajac" wrote: >> >> >> On Apr 20, 2012, at 5:22 PM, Hyrum K Wright wrote: >> >>> On Fri, Apr 20, 2012 at 6:19 PM, Blair Zajac wrote: I just got this on my MacPorts svn, the revision number output is

Re: AW: svnversion breaks after copying checked out repo

2012-04-21 Thread Stefan Sperling
On Fri, Apr 13, 2012 at 10:46:42AM -0700, Taylor Lookabaugh wrote: > I'm sorry, a couple clarifications: > > I use sqlite 4.7.11, not 4.7.0 You mean sqlite-3.7.11? If so, it could be this problem: http://svn.haxx.se/dev/archive-2012-04/0416.shtml Please downgrade to sqlite-3.7.10 until 3.7.12 is

Re: svn commit: r1328595 - /subversion/branches/compressed-pristines/subversion/libsvn_wc/wc_db.c

2012-04-21 Thread Stefan Sperling
On Sat, Apr 21, 2012 at 07:03:52AM -, as...@apache.org wrote: > Author: ashod > Date: Sat Apr 21 07:03:51 2012 > New Revision: 1328595 > > URL: http://svn.apache.org/viewvc?rev=1328595&view=rev > Log: > Pristine.db created during db-init. > ** Checkpoint: raw code. Not ready for review yet! **

Re: sqlite3 3.7.11 breaks svnversion: E200030: sqlite: callback requested query abort

2012-04-21 Thread Daniel Shahaf
Greg Stein wrote on Fri, Apr 20, 2012 at 23:15:05 -0400: > Seems we can/should have a runtime version check? Avoid running with 3.7.11? +1 Index: subversion/libsvn_subr/sqlite.c === --- subversion/libsvn_subr/sqlite.c (revision 1

Re: Merge policies

2012-04-21 Thread Branko Čibej
On 20.04.2012 23:45, Stefan Fuhrmann wrote: > We could even be more permissive: as long as the merge > does not cross "switch boundaries" (switched / non- > switched or switched to different URL) as may allow > the merge. > > This could be a somewhat typical use-case for people > using switched WCs