Re: Ruby bindings failing on buildbots

2012-03-21 Thread Joe Swatosh
On Wed, Mar 21, 2012 at 8:24 AM, Philip Martin wrote: > Joe Swatosh writes: > >> On Wed, Mar 21, 2012 at 3:33 AM, Philip Martin >> wrote: >>> Joe Swatosh writes: >>> >>> I don't understand why prop_mod is no longer being set. >> >> Because replay is no longer setting it? > > Does that mean the

Re: [Issue 4149] New - psvn.el: ediff broken with new working copy layout

2012-03-21 Thread Daniel Shahaf
Kalle Olavi Niemitalo wrote on Thu, Mar 22, 2012 at 01:18:18 +0200: > Daniel Shahaf writes: > > > Forwarding to maintainers > > Am I considered a maintainer of psvn.el because COMMITTERS > lists me as a dormant partial committer for that? > It might be clearest to just delete that line and the >

Re: [Issue 4149] New - psvn.el: ediff broken with new working copy layout

2012-03-21 Thread Greg Stein
On Wed, Mar 21, 2012 at 19:18, Kalle Olavi Niemitalo wrote: > Daniel Shahaf writes: > >> Forwarding to maintainers > > Am I considered a maintainer of psvn.el because COMMITTERS > lists me as a dormant partial committer for that? Nah... I bet Daniel just gathered names from 'svn log psvn.el', an

Re: [Issue 4149] New - psvn.el: ediff broken with new working copy layout

2012-03-21 Thread Kalle Olavi Niemitalo
Daniel Shahaf writes: > Forwarding to maintainers Am I considered a maintainer of psvn.el because COMMITTERS lists me as a dormant partial committer for that? It might be clearest to just delete that line and the corresponding access-control entry, as I really do not expect to make any changes t

Re: svn commit: r1303252 - /subversion/branches/inheritable-props/subversion/libsvn_ra/ra_loader.c

2012-03-21 Thread Daniel Shahaf
pbu...@apache.org wrote on Wed, Mar 21, 2012 at 01:48:34 -: > +/* Helper for svn_ra_get_file2 and svn_ra_get_dir3 when those APIs need to > + find PATH's inherited properties on a legacy server that doesn't have the > + SVN_RA_CAPABILITY_INHERITED_PROPS capability. > + > + All arguments a

Re: svn commit: r1303016 - in /subversion/trunk/subversion: include/private/svn_client_private.h libsvn_client/merge.c svn/cl.h svn/main.c svn/merge-cmd.c

2012-03-21 Thread Daniel Shahaf
julianf...@apache.org wrote on Tue, Mar 20, 2012 at 17:15:23 -: > Modified: subversion/trunk/subversion/include/private/svn_client_private.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_client_private.h?rev=1303016&r1=1303015&r2=1303016&view=diff >

Re: svn commit: r1302682 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h sb_bucket.c serf.c update.c util.c

2012-03-21 Thread Greg Stein
On Wed, Mar 21, 2012 at 17:16, Daniel Shahaf wrote: > gst...@apache.org wrote on Mon, Mar 19, 2012 at 22:04:37 -: >> +svn_ra_serf__copy_into_spillbuf(svn_spillbuf_t **spillbuf, >> +                                serf_bucket_t *bkt, >> +                                apr_pool_t *result_pool,

Re: [Issue 4149] New - psvn.el: ediff broken with new working copy layout

2012-03-21 Thread Daniel Shahaf
Forwarding to maintainers sq@ -- consider submitting a patch: http://subversion.apache.org/patches s...@tigris.org wrote on Wed, Mar 21, 2012 at 09:56:12 -0700: > http://subversion.tigris.org/issues/show_bug.cgi?id=4149 > Issue #|4149 > Summary|psvn.el: ediff bro

Re: svn commit: r1302682 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h sb_bucket.c serf.c update.c util.c

2012-03-21 Thread Daniel Shahaf
gst...@apache.org wrote on Mon, Mar 19, 2012 at 22:04:37 -: > +svn_ra_serf__copy_into_spillbuf(svn_spillbuf_t **spillbuf, > +serf_bucket_t *bkt, > +apr_pool_t *result_pool, > +apr_pool_t *scratch_poo

Re: Compressed Pristines (Design Doc)

2012-03-21 Thread Branko Čibej
On 21.03.2012 22:08, Daniel Shahaf wrote: > Greg Stein wrote on Wed, Mar 21, 2012 at 16:51:47 -0400: >> On Wed, Mar 21, 2012 at 16:11, Daniel Shahaf wrote: >>> Ashod Nakashian wrote on Wed, Mar 21, 2012 at 12:19:02 -0700: All, I'm happy to share[1] with you the design document for t

Re: Compressed Pristines (Design Doc)

2012-03-21 Thread Daniel Shahaf
Greg Stein wrote on Wed, Mar 21, 2012 at 16:51:47 -0400: > On Wed, Mar 21, 2012 at 16:11, Daniel Shahaf wrote: > > Ashod Nakashian wrote on Wed, Mar 21, 2012 at 12:19:02 -0700: > >> All, > >> > >> I'm happy to share[1] with you the design document for the Compressed > >> Pristines feature. The do

Re: svn commit: r1302571 - /subversion/trunk/subversion/libsvn_ra_serf/replay.c

2012-03-21 Thread Daniel Shahaf
gst...@apache.org wrote on Mon, Mar 19, 2012 at 17:52:36 -: > Author: gstein > Date: Mon Mar 19 17:52:36 2012 > New Revision: 1302571 > > URL: http://svn.apache.org/viewvc?rev=1302571&view=rev > Log: > * subversion/libsvn_ra_serf/replay.c: > (svn_ra_serf__reply_range): add commentary > > Mo

Re: Compressed Pristines (Design Doc)

2012-03-21 Thread Greg Stein
On Wed, Mar 21, 2012 at 16:11, Daniel Shahaf wrote: > Ashod Nakashian wrote on Wed, Mar 21, 2012 at 12:19:02 -0700: >> All, >> >> I'm happy to share[1] with you the design document for the Compressed >> Pristines feature. The document is public and anyone can comment on any part > > I can't.  Can

Re: Compressed Pristines (Design Doc)

2012-03-21 Thread Daniel Shahaf
Ashod Nakashian wrote on Wed, Mar 21, 2012 at 12:19:02 -0700: > All, > > I'm happy to share[1] with you the design document for the Compressed > Pristines feature. The document is public and anyone can comment on any part I can't. Can you please move the document to our wiki, or dump it in an e

Re: Compressed Pristines (Design Doc)

2012-03-21 Thread Ashod Nakashian
All, I'm happy to share[1] with you the design document for the Compressed Pristines feature. The document is public and anyone can comment on any part (select, right-click and comment away). If you'd like to get *editing* permission, please email me and I'll add you to the list of editors. I'

Re: random sort of svn status and svn diff

2012-03-21 Thread Sérgio Basto
On Wed, 2012-03-21 at 16:57 +, Philip Martin wrote: > Or you could rebuild the current APR with a > one-line patch to set ht->seed to 0 in apr_hash.c:apr_hash_make. I think when subversion receive the result of this apr_function , we should do the sort , ie , subversion should not depend on s

Re: random sort of svn status and svn diff

2012-03-21 Thread Sérgio Basto
On Wed, 2012-03-21 at 16:57 +, Philip Martin wrote: > Sérgio Basto writes: > > > Unfortunately I don't had time before end of the month or even more , > > This random thing does not came in a good time . > > I use many svn diff to review my code ... > > > > So any ideas is appreciated. >

Re: random sort of svn status and svn diff

2012-03-21 Thread Branko Čibej
On 21.03.2012 18:03, Julian Foad wrote: > Discussion of the details of APR's hash function has wandered off-topic for > this thread. Can we take that to a new thread and/or the APR dev list? > Yes yes, but I have to get a last word in ... it's your standard multiplicative hash straight out of Kn

Re: random sort of svn status and svn diff

2012-03-21 Thread Julian Foad
Discussion of the details of APR's hash function has wandered off-topic for this thread.  Can we take that to a new thread and/or the APR dev list? - Julian

Re: random sort of svn status and svn diff

2012-03-21 Thread Philip Martin
Sérgio Basto writes: > Unfortunately I don't had time before end of the month or even more , > This random thing does not came in a good time . > I use many svn diff to review my code ... > > So any ideas is appreciated. You can get the old behaviour by downgrading APR to a version that does

Re: random sort of svn status and svn diff

2012-03-21 Thread Sérgio Basto
On Wed, 2012-03-21 at 10:17 +0200, Daniel Shahaf wrote: > Sérgio Basto wrote on Wed, Mar 21, 2012 at 07:25:05 +: > > On Wed, 2012-03-21 at 08:00 +0100, Stefan Sperling wrote: > > > On Wed, Mar 21, 2012 at 03:02:53AM +, Sérgio Basto wrote: > > > > On Wed, 2012-03-21 at 00:51 +, Philip

Re: random sort of svn status and svn diff

2012-03-21 Thread Daniel Shahaf
Branko Čibej wrote on Wed, Mar 21, 2012 at 17:13:07 +0100: > On 21.03.2012 15:17, Daniel Shahaf wrote: > > Philip Martin wrote on Wed, Mar 21, 2012 at 13:00:01 +: > >> Philip Martin writes: > >> > >>> So if I have > >>> > >>>0, 1 ... X, Y ... N-1 > >>> > >>> where X and Y collide I would e

Re: Ruby bindings failing on buildbots

2012-03-21 Thread Philip Martin
Philip Martin writes: > Philip Martin writes: > >> I'm not aware of a deliberate change to core Subversion behaviour. >> Property deletes should still be reported as property mods by the >> Subversion libraries. > > Ah! There is a non-Ruby bug. Repository with property delete: > > svnadmin crea

Re: random sort of svn status and svn diff

2012-03-21 Thread Branko Čibej
On 21.03.2012 15:17, Daniel Shahaf wrote: > Philip Martin wrote on Wed, Mar 21, 2012 at 13:00:01 +: >> Philip Martin writes: >> >>> So if I have >>> >>>0, 1 ... X, Y ... N-1 >>> >>> where X and Y collide I would expect changing the seed to give: >>> >>>K, K+1 ... X, Y ... N-1, 0 ... K-

Re: Ruby bindings failing on buildbots

2012-03-21 Thread Philip Martin
Philip Martin writes: > I'm not aware of a deliberate change to core Subversion behaviour. > Property deletes should still be reported as property mods by the > Subversion libraries. Ah! There is a non-Ruby bug. Repository with property delete: svnadmin create repo svn -mm import repo/format f

Re: svn commit: r1303375 - in /subversion/trunk/subversion/bindings/swig/python: svn/core.py tests/pool.py

2012-03-21 Thread Greg Stein
This dance you're doing is exactly why I disrecommend using *-imports. It hands power/infection of your local namespace to a module not under your control. Cheers, -g On Mar 21, 2012 8:55 AM, wrote: > Author: danielsh > Date: Wed Mar 21 12:54:49 2012 > New Revision: 1303375 > > URL: http://svn.a

Re: Ruby bindings failing on buildbots

2012-03-21 Thread Philip Martin
Joe Swatosh writes: > On Wed, Mar 21, 2012 at 3:33 AM, Philip Martin > wrote: >> Joe Swatosh writes: >> >> I don't understand why prop_mod is no longer being set. > > Because replay is no longer setting it? Does that mean the core Subversion libraries have changed? I don't do Ruby but it prop

Re: Ruby bindings failing on buildbots

2012-03-21 Thread Joe Swatosh
On Wed, Mar 21, 2012 at 3:33 AM, Philip Martin wrote: > Joe Swatosh writes: > >> Before r1293375, the node that represented 'diff1.txt' in this walk >> had the "prop_mod" member set true. After r1293375, the "prop_mod" >> member for this node is false. Since the implementation of >> Svn::Info#get

Re: random sort of svn status and svn diff

2012-03-21 Thread Daniel Shahaf
Philip Martin wrote on Wed, Mar 21, 2012 at 13:00:01 +: > Philip Martin writes: > > > So if I have > > > >0, 1 ... X, Y ... N-1 > > > > where X and Y collide I would expect changing the seed to give: > > > >K, K+1 ... X, Y ... N-1, 0 ... K-1 > > > > Is that going to remove the collisi

Re: random sort of svn status and svn diff

2012-03-21 Thread Philip Martin
Philip Martin writes: > So if I have > >0, 1 ... X, Y ... N-1 > > where X and Y collide I would expect changing the seed to give: > >K, K+1 ... X, Y ... N-1, 0 ... K-1 > > Is that going to remove the collision? Is it something to do with the bins?. If X and Y were originally in the same

Re: random sort of svn status and svn diff

2012-03-21 Thread Philip Martin
Branko Čibej writes: > On 21.03.2012 10:29, Philip Martin wrote: >> In passing I note that the way APR "randomises" the hash is not all >> that random. It just adds a fixed prefix to the keys passed to the >> default hash function. I thought the point of the APR change was to >> make it harder fo

Re: random sort of svn status and svn diff

2012-03-21 Thread Branko Čibej
On 21.03.2012 10:29, Philip Martin wrote: > In passing I note that the way APR "randomises" the hash is not all > that random. It just adds a fixed prefix to the keys passed to the > default hash function. I thought the point of the APR change was to > make it harder for the user to predict hash co

Re: Ruby bindings failing on buildbots

2012-03-21 Thread Philip Martin
Joe Swatosh writes: > Before r1293375, the node that represented 'diff1.txt' in this walk > had the "prop_mod" member set true. After r1293375, the "prop_mod" > member for this node is false. Since the implementation of > Svn::Info#get_diff_recurse checks "prop_mod" member before attempting > to

Re: random sort of svn status and svn diff

2012-03-21 Thread Philip Martin
Daniel Shahaf writes: > Sérgio Basto wrote on Wed, Mar 21, 2012 at 07:25:05 +: >> Hi, Dev list , I want to fix random sort of svn status and svn diff, on >> recent code of svn, it just put a sort somewhere, could someone point me >> the directory in the source code, where is the code of svn f

Re: random sort of svn status and svn diff

2012-03-21 Thread Daniel Shahaf
Sérgio Basto wrote on Wed, Mar 21, 2012 at 07:25:05 +: > On Wed, 2012-03-21 at 08:00 +0100, Stefan Sperling wrote: > > On Wed, Mar 21, 2012 at 03:02:53AM +, Sérgio Basto wrote: > > > On Wed, 2012-03-21 at 00:51 +, Philip Martin wrote: > > > > Sérgio Basto writes: > > > > > why the ou

Re: random sort of svn status and svn diff

2012-03-21 Thread Sérgio Basto
On Wed, 2012-03-21 at 07:25 +, Sérgio Basto wrote: > Hi, Dev list , I want to fix random sort of svn status and svn diff, on > recent code of svn, it just put a sort somewhere, could someone point me > the directory in the source code, where is the code of svn frontend > commands like diff and

Re: random sort of svn status and svn diff

2012-03-21 Thread Sérgio Basto
On Wed, 2012-03-21 at 08:00 +0100, Stefan Sperling wrote: > On Wed, Mar 21, 2012 at 03:02:53AM +, Sérgio Basto wrote: > > On Wed, 2012-03-21 at 00:51 +, Philip Martin wrote: > > > Sérgio Basto writes: > > > > why the output shouldn't be sorted by name or something else ? > > > > or why